From 139364033f53a57a9ddfc65d6daf33cd499a7d4d Mon Sep 17 00:00:00 2001 From: Jan Hentschel Date: Sun, 7 Jan 2018 13:10:31 +0100 Subject: [PATCH] HBASE-19724 Fixed Checkstyle errors in hbase-hadoop2-compat and enabled Checkstyle to fail on violations --- hbase-hadoop2-compat/pom.xml | 18 +- .../hbase/ipc/MetricsHBaseServerSourceImpl.java | 13 +- .../org/apache/hadoop/hbase/mapreduce/JobUtil.java | 12 +- .../master/MetricsAssignmentManagerSourceImpl.java | 10 +- .../master/MetricsMasterFilesystemSourceImpl.java | 2 +- .../hbase/master/MetricsMasterProcSourceImpl.java | 2 +- .../hbase/master/MetricsMasterQuotaSourceImpl.java | 5 +- .../hbase/master/MetricsMasterSourceImpl.java | 11 +- .../hbase/master/MetricsSnapshotSourceImpl.java | 2 +- .../master/balancer/MetricsBalancerSourceImpl.java | 9 +- .../MetricsStochasticBalancerSourceImpl.java | 23 +- .../hadoop/hbase/metrics/BaseSourceImpl.java | 22 +- .../org/apache/hadoop/hbase/metrics/Interns.java | 13 +- .../hadoop/hbase/metrics/MBeanSourceImpl.java | 2 +- .../hadoop/hbase/metrics/MetricsInfoImpl.java | 6 +- .../impl/GlobalMetricRegistriesAdapter.java | 7 +- .../MetricsHeapMemoryManagerSourceImpl.java | 2 +- .../MetricsRegionAggregateSourceImpl.java | 6 +- .../MetricsRegionServerSourceFactoryImpl.java | 5 +- .../MetricsRegionServerSourceImpl.java | 406 +++++++++++---------- .../regionserver/MetricsRegionSourceImpl.java | 6 +- .../MetricsTableAggregateSourceImpl.java | 8 +- .../hbase/regionserver/MetricsTableSourceImpl.java | 16 +- .../regionserver/wal/MetricsWALSourceImpl.java | 11 +- .../MetricsReplicationGlobalSourceSource.java | 13 +- .../MetricsReplicationSinkSourceImpl.java | 1 - .../regionserver/MetricsReplicationSourceImpl.java | 2 +- .../MetricsReplicationSourceSourceImpl.java | 3 + .../hadoop/hbase/rest/MetricsRESTSourceImpl.java | 25 +- .../thrift/MetricsThriftServerSourceImpl.java | 5 +- .../zookeeper/MetricsZooKeeperSourceImpl.java | 47 ++- .../hadoop/metrics2/impl/JmxCacheBuster.java | 8 +- .../metrics2/lib/DefaultMetricsSystemHelper.java | 4 +- .../metrics2/lib/DynamicMetricsRegistry.java | 39 +- .../hadoop/metrics2/lib/MetricsExecutorImpl.java | 2 +- .../hadoop/metrics2/lib/MutableHistogram.java | 2 +- .../hadoop/metrics2/lib/MutableRangeHistogram.java | 3 +- .../hadoop/metrics2/lib/MutableSizeHistogram.java | 2 +- .../hadoop/metrics2/lib/MutableTimeHistogram.java | 4 +- .../hadoop/metrics2/util/MetricQuantile.java | 18 +- .../metrics2/util/MetricSampleQuantiles.java | 18 +- .../org/apache/hadoop/hbase/HadoopShimsImpl.java | 3 +- .../master/TestMetricsMasterProcSourceImpl.java | 10 +- .../hbase/master/TestMetricsMasterSourceImpl.java | 15 +- .../hadoop/hbase/metrics/TestBaseSourceImpl.java | 8 +- .../TestMetricsRegionServerSourceImpl.java | 12 +- .../regionserver/TestMetricsRegionSourceImpl.java | 13 +- .../regionserver/TestMetricsTableSourceImpl.java | 8 +- .../regionserver/wal/TestMetricsWALSourceImpl.java | 9 +- .../TestMetricsReplicationSourceFactoryImpl.java | 9 +- .../TestMetricsReplicationSourceImpl.java | 13 +- .../hbase/rest/TestMetricsRESTSourceImpl.java | 17 +- .../hadoop/hbase/test/MetricsAssertHelperImpl.java | 14 +- .../TestMetricsThriftServerSourceFactoryImpl.java | 18 +- .../zookeeper/TestMetricsZooKeeperSourceImpl.java | 6 +- 55 files changed, 511 insertions(+), 457 deletions(-) diff --git a/hbase-hadoop2-compat/pom.xml b/hbase-hadoop2-compat/pom.xml index 0a99090b3c..f1e20ef876 100644 --- a/hbase-hadoop2-compat/pom.xml +++ b/hbase-hadoop2-compat/pom.xml @@ -74,8 +74,24 @@ limitations under the License. + + org.apache.maven.plugins + maven-checkstyle-plugin + + + checkstyle + validate + + check + + + true + + + + - +