From a9aa7648e104b17d88d90ced78536e7105e91b6e Mon Sep 17 00:00:00 2001 From: Jan Hentschel Date: Thu, 21 Dec 2017 17:11:53 +0100 Subject: [PATCH] HBASE-19581 Fixed remaining Checkstyle error in hbase-external-blockcache and enabled Checkstyle to fail on violations --- hbase-external-blockcache/pom.xml | 16 ++++++++++++++++ .../hadoop/hbase/io/hfile/MemcachedBlockCache.java | 13 ++++++------- 2 files changed, 22 insertions(+), 7 deletions(-) diff --git a/hbase-external-blockcache/pom.xml b/hbase-external-blockcache/pom.xml index 46e58c2ee5..8b048c5c6f 100644 --- a/hbase-external-blockcache/pom.xml +++ b/hbase-external-blockcache/pom.xml @@ -95,6 +95,22 @@ org.apache.maven.plugins maven-source-plugin + + org.apache.maven.plugins + maven-checkstyle-plugin + + + checkstyle + validate + + check + + + true + + + + diff --git a/hbase-external-blockcache/src/main/java/org/apache/hadoop/hbase/io/hfile/MemcachedBlockCache.java b/hbase-external-blockcache/src/main/java/org/apache/hadoop/hbase/io/hfile/MemcachedBlockCache.java index a523663381..ba6ae1e39e 100644 --- a/hbase-external-blockcache/src/main/java/org/apache/hadoop/hbase/io/hfile/MemcachedBlockCache.java +++ b/hbase-external-blockcache/src/main/java/org/apache/hadoop/hbase/io/hfile/MemcachedBlockCache.java @@ -1,4 +1,3 @@ - /** * Copyright The Apache Software Foundation * @@ -29,6 +28,12 @@ import java.util.List; import java.util.NoSuchElementException; import java.util.concurrent.ExecutionException; +import net.spy.memcached.CachedData; +import net.spy.memcached.ConnectionFactoryBuilder; +import net.spy.memcached.FailureMode; +import net.spy.memcached.MemcachedClient; +import net.spy.memcached.transcoders.Transcoder; + import org.apache.hadoop.conf.Configuration; import org.apache.hadoop.hbase.HConstants; import org.apache.hadoop.hbase.io.hfile.Cacheable.MemoryType; @@ -41,12 +46,6 @@ import org.apache.yetus.audience.InterfaceAudience; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import net.spy.memcached.CachedData; -import net.spy.memcached.ConnectionFactoryBuilder; -import net.spy.memcached.FailureMode; -import net.spy.memcached.MemcachedClient; -import net.spy.memcached.transcoders.Transcoder; - /** * Class to store blocks into memcached. * This should only be used on a cluster of Memcached daemons that are tuned well and have a -- 2.14.3 (Apple Git-98)