From ee0e7b7a565f73a5e99d17151980f80fc8be0fe2 Mon Sep 17 00:00:00 2001 From: Zhong Date: Fri, 3 Nov 2017 13:17:32 +0800 Subject: [PATCH] APACHE-KYLIN-2989: Fix close of BufferedWriter should be placed in finally block in SCCreator --- .../java/org/apache/kylin/tool/metrics/systemcube/SCCreator.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tool/src/main/java/org/apache/kylin/tool/metrics/systemcube/SCCreator.java b/tool/src/main/java/org/apache/kylin/tool/metrics/systemcube/SCCreator.java index f3bb071..38edb1b 100644 --- a/tool/src/main/java/org/apache/kylin/tool/metrics/systemcube/SCCreator.java +++ b/tool/src/main/java/org/apache/kylin/tool/metrics/systemcube/SCCreator.java @@ -255,8 +255,8 @@ public class SCCreator extends AbstractApplication { parentDir.mkdirs(); } - BufferedWriter bufferedWriter = new BufferedWriter(new FileWriter(fileName)); - bufferedWriter.append(contents); - bufferedWriter.close(); + try (BufferedWriter bufferedWriter = new BufferedWriter(new FileWriter(fileName))) { + bufferedWriter.append(contents); + } } } -- 2.5.4 (Apple Git-61)