From 5ce3c499a4d30bc91408ea59da279a47bb96805c Mon Sep 17 00:00:00 2001 From: Sunil G Date: Mon, 9 Oct 2017 15:12:54 +0530 Subject: [PATCH] YARN-7205 --- .../hadoop/yarn/api/records/ResourceTypeInfo.java | 7 ++-- .../hadoop/yarn/util/resource/ResourceUtils.java | 45 +++++++++++++--------- 2 files changed, 30 insertions(+), 22 deletions(-) diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ResourceTypeInfo.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ResourceTypeInfo.java index b6f7f14..8775342 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ResourceTypeInfo.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ResourceTypeInfo.java @@ -152,9 +152,10 @@ public static void copy(ResourceTypeInfo src, ResourceTypeInfo dst) { @Override public String toString() { StringBuilder sb = new StringBuilder(); - sb.append(""); + sb.append(this.getName()); + if (!this.getDefaultUnit().isEmpty()) { + sb.append(" (unit=").append(this.getDefaultUnit()).append(")"); + } return sb.toString(); } diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/util/resource/ResourceUtils.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/util/resource/ResourceUtils.java index 0564d74..fa6a4fa 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/util/resource/ResourceUtils.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/util/resource/ResourceUtils.java @@ -22,8 +22,6 @@ import org.apache.commons.lang.StringUtils; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; -import org.apache.hadoop.classification.InterfaceAudience; -import org.apache.hadoop.classification.InterfaceStability; import org.apache.hadoop.conf.Configuration; import org.apache.hadoop.yarn.api.protocolrecords.ResourceTypes; import org.apache.hadoop.yarn.api.records.Resource; @@ -117,19 +115,21 @@ private static void addMandatoryResources( Map res) { ResourceInformation ri; if (!res.containsKey(MEMORY)) { - LOG.info("Adding resource type - name = " + MEMORY + ", units = " - + ResourceInformation.MEMORY_MB.getUnits() + ", type = " - + ResourceTypes.COUNTABLE); - ri = ResourceInformation - .newInstance(MEMORY, - ResourceInformation.MEMORY_MB.getUnits()); + if (LOG.isDebugEnabled()) { + LOG.debug("Adding resource type - name = " + MEMORY + ", units = " + + ResourceInformation.MEMORY_MB.getUnits() + ", type = " + + ResourceTypes.COUNTABLE); + } + ri = ResourceInformation.newInstance(MEMORY, + ResourceInformation.MEMORY_MB.getUnits()); res.put(MEMORY, ri); } if (!res.containsKey(VCORES)) { - LOG.info("Adding resource type - name = " + VCORES + ", units = , type = " - + ResourceTypes.COUNTABLE); - ri = - ResourceInformation.newInstance(VCORES); + if (LOG.isDebugEnabled()) { + LOG.debug("Adding resource type - name = " + VCORES + + ", units = , type = " + ResourceTypes.COUNTABLE); + } + ri = ResourceInformation.newInstance(VCORES); res.put(VCORES, ri); } } @@ -342,11 +342,11 @@ private static void initializeResourceTypesIfNeeded(Configuration conf, } try { addResourcesFileToConf(resourceFile, conf); - LOG.debug("Found " + resourceFile + ", adding to configuration"); } catch (FileNotFoundException fe) { - LOG.debug("Unable to find '" + resourceFile + "'."); + if (LOG.isDebugEnabled()) { + LOG.debug("Unable to find '" + resourceFile + "'."); + } } - initializeResourcesMap(conf); } } @@ -387,7 +387,9 @@ private static void addResourcesFileToConf(String resourceFile, Configuration conf) throws FileNotFoundException { try { InputStream ris = getConfInputStream(resourceFile, conf); - LOG.debug("Found " + resourceFile + ", adding to configuration"); + if (LOG.isDebugEnabled()) { + LOG.debug("Found " + resourceFile + ", adding to configuration"); + } conf.addResource(ris); } catch (FileNotFoundException fe) { throw fe; @@ -471,7 +473,10 @@ public static String getUnits(String resourceValue) { } } } catch (FileNotFoundException fe) { - LOG.info("Couldn't find node resources file"); + if (LOG.isDebugEnabled()) { + LOG.debug("Couldn't find node resources file:" + + YarnConfiguration.NODE_RESOURCES_CONFIGURATION_FILE); + } } return nodeResources; } @@ -491,8 +496,10 @@ private static void addResourceInformation(String prop, String value, Long.valueOf(value.substring(0, value.length() - units.length())); nodeResources.get(resourceType).setValue(resourceValue); nodeResources.get(resourceType).setUnits(units); - LOG.debug("Setting value for resource type " + resourceType + " to " - + resourceValue + " with units " + units); + if (LOG.isDebugEnabled()) { + LOG.debug("Setting value for resource type " + resourceType + " to " + + resourceValue + " with units " + units); + } } } -- 2.10.1 (Apple Git-78)