From 308f21e8c8eea82e08a62b5cfad19f2406b282c9 Mon Sep 17 00:00:00 2001 From: sahil aggarwal Date: Sun, 22 Jan 2017 10:08:05 +0530 Subject: [PATCH] HBASE-17104: We end up here only when abort=true in which case we don't flush memstore. If abort=false then we should have definitely flushed memstore by now. --- .../main/java/org/apache/hadoop/hbase/regionserver/HRegion.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java index 0b93cb1..e1179bf 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java @@ -1690,7 +1690,12 @@ public class HRegion implements HeapSize, PropagatingConfigurationObserver, Regi if (!canFlush) { this.decrMemstoreSize(new MemstoreSize(memstoreDataSize.get(), getMemstoreHeapOverhead())); } else if (memstoreDataSize.get() != 0) { - LOG.error("Memstore size is " + memstoreDataSize.get()); + if(!abort){ + //memstore should be flushed by now if close was not abort triggered + LOG.error("Impossible! abort=false and memstore not flushed. Memstore size is " + memstoreDataSize.get()); + } else { + LOG.info("abort=true, memstore flush not triggered. Memstore size is " + memstoreDataSize.get()); + } } if (coprocessorHost != null) { status.setStatus("Running coprocessor post-close hooks"); -- 2.7.1