From e356db9d96870c3b263db143d449070d97297a11 Mon Sep 17 00:00:00 2001 From: Umesh Agashe Date: Wed, 21 Jun 2017 14:56:24 -0700 Subject: [PATCH] HBASE-18254 ServerCrashProcedure checks and waits for meta initialized, instead should check and wait for meta loaded After enabling test hbase.master.procedure.TestServerCrashProcedure#testRecoveryAndDoubleExecutionOnRsWithMeta, this bug is found in ServerCrashProcedure --- .../org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java | 2 +- .../apache/hadoop/hbase/master/procedure/TestServerCrashProcedure.java | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java index c6cd861884a10a8969a7c98d8620a3076895b23b..db4ac327bb01935d9f6be1e457f38a30546dd6a0 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java @@ -150,7 +150,7 @@ implements ServerProcedureInterface { case SERVER_CRASH_GET_REGIONS: // If hbase:meta is not assigned, yield. - if (env.getAssignmentManager().waitMetaInitialized(this)) { + if (env.getAssignmentManager().waitMetaLoaded(this)) { throw new ProcedureSuspendedException(); } diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestServerCrashProcedure.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestServerCrashProcedure.java index e34e3582ad86ec2181fd13c44f9f709411b8e201..b64905e2f531617e117aec8a00674601d8732795 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestServerCrashProcedure.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestServerCrashProcedure.java @@ -93,7 +93,6 @@ public class TestServerCrashProcedure { } @Test(timeout=60000) - @Ignore // Fix for AMv2 public void testRecoveryAndDoubleExecutionOnRsWithoutMeta() throws Exception { testRecoveryAndDoubleExecution(false); } -- 2.10.1 (Apple Git-78)