diff --git llap-client/src/java/org/apache/hadoop/hive/llap/ext/LlapTaskUmbilicalExternalClient.java llap-client/src/java/org/apache/hadoop/hive/llap/ext/LlapTaskUmbilicalExternalClient.java index c7de417..406bdda 100644 --- llap-client/src/java/org/apache/hadoop/hive/llap/ext/LlapTaskUmbilicalExternalClient.java +++ llap-client/src/java/org/apache/hadoop/hive/llap/ext/LlapTaskUmbilicalExternalClient.java @@ -196,7 +196,6 @@ public InetSocketAddress getAddress() { /** * Submit the work for actual execution. - * @throws InvalidProtocolBufferException */ public void submitWork(SubmitWorkRequestProto request, String llapHost, int llapPort) { // Register the pending events to be sent for this spec. diff --git llap-client/src/java/org/apache/hadoop/hive/llap/registry/ServiceInstance.java llap-client/src/java/org/apache/hadoop/hive/llap/registry/ServiceInstance.java index 081995c..70515c4 100644 --- llap-client/src/java/org/apache/hadoop/hive/llap/registry/ServiceInstance.java +++ llap-client/src/java/org/apache/hadoop/hive/llap/registry/ServiceInstance.java @@ -20,7 +20,7 @@ public interface ServiceInstance { /** - * Worker identity is a UUID (unique across restarts), to identify a node which died & was brought + * Worker identity is a UUID (unique across restarts), to identify a node which died & was brought * back on the same host/port */ public String getWorkerIdentity(); diff --git metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreSchemaInfo.java metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreSchemaInfo.java index 296d04b..0a5f978 100644 --- metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreSchemaInfo.java +++ metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreSchemaInfo.java @@ -99,7 +99,7 @@ String getMetaStoreSchemaVersion( * 'rolling downgrade' is happening. This is a state where hive is functional and returning non * zero status for it is misleading. * - * @param hiveVersion version of hive software + * @param productVersion version of hive software * @param dbVersion version of metastore rdbms schema * @return true if versions are compatible */ diff --git metastore/src/java/org/apache/hadoop/hive/metastore/tools/HiveSchemaHelper.java metastore/src/java/org/apache/hadoop/hive/metastore/tools/HiveSchemaHelper.java index 0127bdd..620ea5f 100644 --- metastore/src/java/org/apache/hadoop/hive/metastore/tools/HiveSchemaHelper.java +++ metastore/src/java/org/apache/hadoop/hive/metastore/tools/HiveSchemaHelper.java @@ -48,7 +48,7 @@ * @param printInfo print connection parameters * @param hiveConf hive config object * @return metastore connection object - * @throws org.apache.hadoop.hive.metastore.api.MetaException + * @throws org.apache.hadoop.hive.metastore.HiveMetaException */ public static Connection getConnectionToMetastore(String userName, String password, String url, String driver, boolean printInfo, diff --git spark-client/src/main/java/org/apache/hive/spark/client/SparkClient.java spark-client/src/main/java/org/apache/hive/spark/client/SparkClient.java index e952f27..1922e41 100644 --- spark-client/src/main/java/org/apache/hive/spark/client/SparkClient.java +++ spark-client/src/main/java/org/apache/hive/spark/client/SparkClient.java @@ -49,15 +49,16 @@ /** * Asks the remote context to run a job immediately. - *
+ ** Normally, the remote context will queue jobs and execute them based on how many worker * threads have been configured. This method will run the submitted job in the same thread * processing the RPC message, so that queueing does not apply. - *
+ * + ** It's recommended that this method only be used to run code that finishes quickly. This * avoids interfering with the normal operation of the context. - *
- * Note: the {@link JobContext#monitor()} functionality is not available when using this method. + * + * Note: the JobContext#monitor() functionality is not available when using this method. * * @param job The job to execute. * @return A future to monitor the result of the job. diff --git spark-client/src/main/java/org/apache/hive/spark/client/rpc/RpcDispatcher.java spark-client/src/main/java/org/apache/hive/spark/client/rpc/RpcDispatcher.java index 2b6ab29..00f5a17 100644 --- spark-client/src/main/java/org/apache/hive/spark/client/rpc/RpcDispatcher.java +++ spark-client/src/main/java/org/apache/hive/spark/client/rpc/RpcDispatcher.java @@ -37,14 +37,15 @@ /** * An implementation of ChannelInboundHandler that dispatches incoming messages to an instance * method based on the method signature. - * + ** A handler's signature must be of the form: - *
+ * *protected void handle(ChannelHandlerContext, MessageType)- * + *
* Where "MessageType" must match exactly the type of the message to handle. Polymorphism is not * supported. Handlers can return a value, which becomes the RPC reply; if a null is returned, then * a reply is still sent, with an empty payload. + *
*/ @InterfaceAudience.Private public abstract class RpcDispatcher extends SimpleChannelInboundHandler