diff --git hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestRMFailover.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestRMFailover.java index 4bf6a78..1baaf67 100644 --- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestRMFailover.java +++ hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestRMFailover.java @@ -183,14 +183,13 @@ public void testAutomaticFailover() cluster.getActiveRMIndex()); rm.handleTransitionToStandByInNewThread(); int maxWaitingAttempts = 2000; - while (maxWaitingAttempts-- > 0 ) { + for (; maxWaitingAttempts > 0; maxWaitingAttempts--) { if (rm.getRMContext().getHAServiceState() == HAServiceState.STANDBY) { break; } Thread.sleep(1); } - Assert.assertFalse("RM didn't transition to Standby ", - maxWaitingAttempts == 0); + assertFalse("RM didn't transition to Standby ", maxWaitingAttempts == 0); verifyConnections(); } @@ -394,14 +393,14 @@ public void run() { testThread.join(); int maxWaitingAttempts = 2000; - while (maxWaitingAttempts-- > 0) { + for (; maxWaitingAttempts > 0; maxWaitingAttempts--) { if (resourceManager.getRMContext().getHAServiceState() == HAServiceState.STANDBY) { break; } Thread.sleep(1); } - assertFalse("RM didn't transition to Standby ", maxWaitingAttempts < 0); + assertFalse("RM didn't transition to Standby ", maxWaitingAttempts == 0); } /**