From 1678670a00a8fec88d68e09655534f2a3bf9ef75 Mon Sep 17 00:00:00 2001 From: kangkaisen Date: Thu, 29 Dec 2016 21:37:26 +0800 Subject: [PATCH] KYLIN-2337 Remove expensive toString in SortedIteratorMergerWithLimit --- core-cube/src/main/java/org/apache/kylin/gridtable/GTRecord.java | 1 + .../apache/kylin/storage/gtrecord/SortedIteratorMergerWithLimit.java | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/core-cube/src/main/java/org/apache/kylin/gridtable/GTRecord.java b/core-cube/src/main/java/org/apache/kylin/gridtable/GTRecord.java index 4d26029..f4480c8 100644 --- a/core-cube/src/main/java/org/apache/kylin/gridtable/GTRecord.java +++ b/core-cube/src/main/java/org/apache/kylin/gridtable/GTRecord.java @@ -234,6 +234,7 @@ public class GTRecord implements Comparable, Cloneable { return toString(info.colAll); } + /** toString for MemoryHungry Measure is expensive, please invoke carefully */ public String toString(ImmutableBitSet selectedColumns) { Object[] values = new Object[selectedColumns.cardinality()]; getValues(selectedColumns, values); diff --git a/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/SortedIteratorMergerWithLimit.java b/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/SortedIteratorMergerWithLimit.java index 2f2691e..6a7e713 100644 --- a/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/SortedIteratorMergerWithLimit.java +++ b/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/SortedIteratorMergerWithLimit.java @@ -126,7 +126,7 @@ public class SortedIteratorMergerWithLimit extends SortedIt //TODO: remove this check when validated if (last != null) { - Preconditions.checkState(comparator.compare(last, fetched) <= 0, "Not sorted! last: " + last + " fetched: " + fetched); + Preconditions.checkState(comparator.compare(last, fetched) <= 0, "Not sorted!"); } last = fetched; -- 2.10.1 (Apple Git-78)