From 504de6c1866d10ef97b43478951cc8449f72c9be Mon Sep 17 00:00:00 2001 From: Dustin Pho Date: Sat, 24 Sep 2016 14:58:37 -0700 Subject: [PATCH] HBASE-16661 Add last major compaction age to per-region metrics --- .../hadoop/hbase/regionserver/MetricsRegionSource.java | 1 + .../hadoop/hbase/regionserver/MetricsRegionWrapper.java | 5 +++++ .../hbase/regionserver/MetricsRegionSourceImpl.java | 4 ++++ .../hbase/regionserver/TestMetricsRegionSourceImpl.java | 5 +++++ .../org/apache/hadoop/hbase/regionserver/HRegion.java | 9 +++------ .../hbase/regionserver/MetricsRegionWrapperImpl.java | 17 +++++++++++++++++ .../org/apache/hadoop/hbase/regionserver/Region.java | 4 ++-- .../hbase/regionserver/MetricsRegionWrapperStub.java | 5 +++++ 8 files changed, 42 insertions(+), 8 deletions(-) diff --git a/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java b/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java index 911c757..c4678c8 100644 --- a/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java +++ b/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java @@ -29,6 +29,7 @@ public interface MetricsRegionSource extends Comparable { String SIZE_VALUE_NAME = "size"; String COMPACTIONS_COMPLETED_COUNT = "compactionsCompletedCount"; String COMPACTIONS_FAILED_COUNT = "compactionsFailedCount"; + String LAST_MAJOR_COMPACTION_AGE = "lastMajorCompactionAge"; String NUM_BYTES_COMPACTED_COUNT = "numBytesCompactedCount"; String NUM_FILES_COMPACTED_COUNT = "numFilesCompactedCount"; String COMPACTIONS_COMPLETED_DESC = "Number of compactions that have completed."; diff --git a/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapper.java b/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapper.java index e3fd5c3..cfc0742 100644 --- a/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapper.java +++ b/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapper.java @@ -106,6 +106,11 @@ public interface MetricsRegionWrapper { long getNumCompactionsCompleted(); /** + * @return Age of the last major compaction + */ + long getLastMajorCompactionAge(); + + /** * Returns the total number of compactions that have been reported as failed on this region. * Note that a given compaction can be reported as both completed and failed if an exception * is thrown in the processing after {@code HRegion.compact()}. diff --git a/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java b/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java index c0d71d5..1c04400 100644 --- a/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java +++ b/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java @@ -269,6 +269,10 @@ public class MetricsRegionSourceImpl implements MetricsRegionSource { MetricsRegionSource.COMPACTIONS_FAILED_DESC), this.regionWrapper.getNumCompactionsFailed()); mrb.addCounter(Interns.info( + regionNamePrefix + MetricsRegionSource.LAST_MAJOR_COMPACTION_AGE, + MetricsRegionSource.LAST_MAJOR_COMPACTION_AGE), + this.regionWrapper.getLastMajorCompactionAge()); + mrb.addCounter(Interns.info( regionNamePrefix + MetricsRegionSource.NUM_BYTES_COMPACTED_COUNT, MetricsRegionSource.NUM_BYTES_COMPACTED_DESC), this.regionWrapper.getNumBytesCompacted()); diff --git a/hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java b/hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java index cb97570..6724939 100644 --- a/hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java +++ b/hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java @@ -147,6 +147,11 @@ public class TestMetricsRegionSourceImpl { } @Override + public long getLastMajorCompactionAge() { + return 0; + } + + @Override public long getNumCompactionsCompleted() { return 0; } diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java index debaec9..98546a7 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java @@ -1714,7 +1714,7 @@ public class HRegion implements HeapSize, PropagatingConfigurationObserver, Regi } @Override - public long getOldestHfileTs(boolean majorCompactioOnly) throws IOException { + public long getOldestHfileTs(boolean majorCompactionOnly) throws IOException { long result = Long.MAX_VALUE; for (Store store : getStores()) { Collection storeFiles = store.getStorefiles(); @@ -1724,12 +1724,9 @@ public class HRegion implements HeapSize, PropagatingConfigurationObserver, Regi if (sfReader == null) continue; HFile.Reader reader = sfReader.getHFileReader(); if (reader == null) continue; - if (majorCompactioOnly) { + if (majorCompactionOnly) { byte[] val = reader.loadFileInfo().get(StoreFile.MAJOR_COMPACTION_KEY); - if (val == null) continue; - if (val == null || !Bytes.toBoolean(val)) { - continue; - } + if (val == null || !Bytes.toBoolean(val)) continue; } result = Math.min(result, reader.getFileContext().getFileCreateTime()); } diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperImpl.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperImpl.java index 01e6d06..aed75c2 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperImpl.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperImpl.java @@ -25,15 +25,20 @@ import java.util.concurrent.ScheduledExecutorService; import java.util.concurrent.ScheduledFuture; import java.util.concurrent.TimeUnit; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; import org.apache.hadoop.hbase.classification.InterfaceAudience; import org.apache.hadoop.hbase.CompatibilitySingletonFactory; import org.apache.hadoop.hbase.HRegionInfo; import org.apache.hadoop.hbase.HTableDescriptor; +import org.apache.hadoop.hbase.util.EnvironmentEdgeManager; import org.apache.hadoop.metrics2.MetricsExecutor; @InterfaceAudience.Private public class MetricsRegionWrapperImpl implements MetricsRegionWrapper, Closeable { + private static final Log LOG = LogFactory.getLog(MetricsRegionWrapperImpl.class); + public static final int PERIOD = 45; public static final String UNKNOWN = "unknown"; @@ -141,6 +146,18 @@ public class MetricsRegionWrapperImpl implements MetricsRegionWrapper, Closeable } @Override + public long getLastMajorCompactionAge() { + long lastMajorCompactionTs = 0L; + try { + lastMajorCompactionTs = this.region.getOldestHfileTs(true); + } catch (IOException ioe) { + LOG.error("Could not load HFile info ", ioe); + } + long now = EnvironmentEdgeManager.currentTime(); + return now - lastMajorCompactionTs; + } + + @Override public long getNumCompactionsFailed() { return this.region.compactionsFailed.get(); } diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Region.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Region.java index efd68b8..c5ac89d 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Region.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Region.java @@ -141,10 +141,10 @@ public interface Region extends ConfigurationObserver { /** * This can be used to determine the last time all files of this region were major compacted. - * @param majorCompactioOnly Only consider HFile that are the result of major compaction + * @param majorCompactionOnly Only consider HFile that are the result of major compaction * @return the timestamp of the oldest HFile for all stores of this region */ - long getOldestHfileTs(boolean majorCompactioOnly) throws IOException; + long getOldestHfileTs(boolean majorCompactionOnly) throws IOException; /** * @return map of column family names to max sequence id that was read from storage when this diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperStub.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperStub.java index 72b8b64..1a4e121 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperStub.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperStub.java @@ -121,6 +121,11 @@ public class MetricsRegionWrapperStub implements MetricsRegionWrapper { } @Override + public long getLastMajorCompactionAge() { + return 0; + } + + @Override public long getNumCompactionsFailed() { return 0; } -- 2.8.0-rc2