From 4feb0b030b4f36d408840797733e567f9447f375 Mon Sep 17 00:00:00 2001 From: Umesh Agashe Date: Mon, 12 Sep 2016 11:20:27 -0700 Subject: [PATCH] HBASE-16491 Adds @InterfaceAudience annotation to a few rsgroup related classes/ interfaces --- .../main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java | 2 ++ .../main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManager.java | 2 ++ .../java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java | 2 ++ .../src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupSerDe.java | 2 ++ .../org/apache/hadoop/hbase/rsgroup/VerifyingRSGroupAdminClient.java | 2 ++ 5 files changed, 10 insertions(+) diff --git a/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java b/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java index 49b02be..1fe8d09 100644 --- a/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java +++ b/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java @@ -43,6 +43,7 @@ import org.apache.hadoop.hbase.NamespaceDescriptor; import org.apache.hadoop.hbase.ProcedureInfo; import org.apache.hadoop.hbase.ServerName; import org.apache.hadoop.hbase.TableName; +import org.apache.hadoop.hbase.classification.InterfaceAudience; import org.apache.hadoop.hbase.client.MasterSwitchType; import org.apache.hadoop.hbase.constraint.ConstraintException; import org.apache.hadoop.hbase.coprocessor.CoprocessorService; @@ -80,6 +81,7 @@ import org.apache.hadoop.hbase.protobuf.generated.RSGroupAdminProtos.RemoveRSGro import org.apache.hadoop.hbase.protobuf.generated.RSGroupAdminProtos.RemoveRSGroupResponse; +@InterfaceAudience.Private public class RSGroupAdminEndpoint extends RSGroupAdminService implements CoprocessorService, Coprocessor, MasterObserver { diff --git a/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManager.java b/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManager.java index 434c85f..309985e 100644 --- a/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManager.java +++ b/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManager.java @@ -29,12 +29,14 @@ import java.util.Set; import org.apache.hadoop.hbase.NamespaceDescriptor; import org.apache.hadoop.hbase.TableName; import org.apache.hadoop.hbase.util.Bytes; +import org.apache.hadoop.hbase.classification.InterfaceAudience; /** * Interface used to manage RSGroupInfo storage. An implementation * has the option to support offline mode. * See {@link RSGroupBasedLoadBalancer} */ +@InterfaceAudience.Private public interface RSGroupInfoManager { //Assigned before user tables public static final TableName RSGROUP_TABLE_NAME = diff --git a/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java b/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java index 52cd339..e9f322e 100644 --- a/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java +++ b/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java @@ -57,6 +57,7 @@ import org.apache.hadoop.hbase.MetaTableAccessor.DefaultVisitorBase; import org.apache.hadoop.hbase.NamespaceDescriptor; import org.apache.hadoop.hbase.ServerName; import org.apache.hadoop.hbase.TableName; +import org.apache.hadoop.hbase.classification.InterfaceAudience; import org.apache.hadoop.hbase.client.ClusterConnection; import org.apache.hadoop.hbase.client.Delete; import org.apache.hadoop.hbase.client.Get; @@ -90,6 +91,7 @@ import org.apache.zookeeper.KeeperException; * It also makes use of zookeeper to store group information needed * for bootstrapping during offline mode. */ +@InterfaceAudience.Private public class RSGroupInfoManagerImpl implements RSGroupInfoManager, ServerListener { private static final Log LOG = LogFactory.getLog(RSGroupInfoManagerImpl.class); diff --git a/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupSerDe.java b/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupSerDe.java index 530db58..6baaf07 100644 --- a/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupSerDe.java +++ b/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupSerDe.java @@ -31,6 +31,7 @@ import org.apache.commons.logging.LogFactory; import org.apache.hadoop.hbase.client.Result; import org.apache.hadoop.hbase.client.Scan; import org.apache.hadoop.hbase.client.Table; +import org.apache.hadoop.hbase.classification.InterfaceAudience; import org.apache.hadoop.hbase.exceptions.DeserializationException; import org.apache.hadoop.hbase.protobuf.ProtobufUtil; import org.apache.hadoop.hbase.protobuf.generated.RSGroupProtos; @@ -39,6 +40,7 @@ import org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher; import org.apache.zookeeper.KeeperException; //TODO do better encapsulation of SerDe logic from GroupInfoManager and GroupTracker +@InterfaceAudience.Private public class RSGroupSerDe { private static final Log LOG = LogFactory.getLog(RSGroupSerDe.class); diff --git a/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/VerifyingRSGroupAdminClient.java b/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/VerifyingRSGroupAdminClient.java index d1f4898..26853b7 100644 --- a/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/VerifyingRSGroupAdminClient.java +++ b/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/VerifyingRSGroupAdminClient.java @@ -24,6 +24,7 @@ import com.google.common.collect.Sets; import com.google.common.net.HostAndPort; import org.apache.hadoop.conf.Configuration; import org.apache.hadoop.hbase.TableName; +import org.apache.hadoop.hbase.classification.InterfaceAudience; import org.apache.hadoop.hbase.client.ConnectionFactory; import org.apache.hadoop.hbase.client.Result; import org.apache.hadoop.hbase.client.Scan; @@ -42,6 +43,7 @@ import java.util.List; import java.util.Map; import java.util.Set; +@InterfaceAudience.Private public class VerifyingRSGroupAdminClient extends RSGroupAdmin { private Table table; private ZooKeeperWatcher zkw; -- 2.7.4 (Apple Git-66)