From abf301aa49b77c4da159bf4a8eb7eb7835fd2041 Mon Sep 17 00:00:00 2001 From: Elliott Clark Date: Fri, 13 May 2016 09:17:49 -0700 Subject: [PATCH] HBASE-15821 Document TestUtil --- hbase-native-client/test-util/test-util.cc | 12 +++++++----- hbase-native-client/test-util/test-util.h | 6 +++++- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/hbase-native-client/test-util/test-util.cc b/hbase-native-client/test-util/test-util.cc index e5fba48..8428418 100644 --- a/hbase-native-client/test-util/test-util.cc +++ b/hbase-native-client/test-util/test-util.cc @@ -24,13 +24,15 @@ using hbase::TestUtil; using folly::Random; -const static int STR_LEN = 32; +std::string TestUtil::RandString(int len) { + // Create the whole string. + // Filling everything with z's + auto s = std::string(len, 'z'); -std::string TestUtil::RandString() { - auto s = std::string(STR_LEN, 'z'); - - for (int i = 0; i < STR_LEN; i++) { + // Now pick a bunch of random numbers + for (int i = 0; i < len; i++) { auto r = Random::rand32('a', 'z'); + // Cast that to ascii. s[i] = static_cast(r); } return s; diff --git a/hbase-native-client/test-util/test-util.h b/hbase-native-client/test-util/test-util.h index 395b157..40d882a 100644 --- a/hbase-native-client/test-util/test-util.h +++ b/hbase-native-client/test-util/test-util.h @@ -43,7 +43,11 @@ public: * Run a command in the hbase shell. */ void RunShellCmd(const std::string& command); - static std::string RandString(); + + /** + * Create a random string + */ + static std::string RandString(int len = 32); private: folly::test::TemporaryDirectory temp_dir_; -- 2.8.0-rc2