From 6bc355721e1f5ec3934cf014f042702345d7e7b7 Mon Sep 17 00:00:00 2001 From: Andrew Purtell Date: Wed, 10 Feb 2016 10:19:49 -0800 Subject: [PATCH] HBASE-15229 Canary Tools should not call System.Exit on error (Vishal Khandelwal) --- .../src/main/java/org/apache/hadoop/hbase/tool/Canary.java | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java index 3cc3b7b..d99bc18 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java @@ -590,9 +590,9 @@ public final class Canary implements Tool { if (this.failOnError && monitor.hasError()) { monitorThread.interrupt(); if (monitor.initialized) { - System.exit(monitor.errorCode); + return monitor.errorCode; } else { - System.exit(INIT_ERROR_EXIT_CODE); + return INIT_ERROR_EXIT_CODE; } } currentTimeLength = System.currentTimeMillis() - startTime; @@ -601,17 +601,16 @@ public final class Canary implements Tool { + ") after timeout limit:" + this.timeout + " will be killed itself !!"); if (monitor.initialized) { - System.exit(TIMEOUT_ERROR_EXIT_CODE); + return TIMEOUT_ERROR_EXIT_CODE; } else { - System.exit(INIT_ERROR_EXIT_CODE); + return INIT_ERROR_EXIT_CODE; } - break; } } if (this.failOnError && monitor.finalCheckForErrors()) { monitorThread.interrupt(); - System.exit(monitor.errorCode); + return monitor.errorCode; } } finally { if (monitor != null) monitor.close(); @@ -623,7 +622,7 @@ public final class Canary implements Tool { connection.close(); } - return(monitor.errorCode); + return monitor.errorCode; } private void printUsageAndExit() { -- 2.4.9 (Apple Git-60)