commit c9644b7ec9e6439e7a35070e8adc03b1db06ade3 Author: Daniel Dai Date: Tue Oct 27 16:53:41 2015 -0700 HIVE-12279: Testcase to verify session temporary files are removed after HIVE-11768 diff --git a/service/src/test/org/apache/hive/service/cli/session/TestSessionCleanup.java b/service/src/test/org/apache/hive/service/cli/session/TestSessionCleanup.java new file mode 100644 index 0000000..e38a52a --- /dev/null +++ b/service/src/test/org/apache/hive/service/cli/session/TestSessionCleanup.java @@ -0,0 +1,77 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hive.service.cli.session; + +import java.io.File; +import java.io.FilenameFilter; +import java.util.Arrays; +import java.util.Collections; +import java.util.HashSet; +import java.util.Set; + +import junit.framework.TestCase; + +import org.apache.hadoop.hive.conf.HiveConf; +import org.apache.hadoop.hive.conf.HiveConf.ConfVars; +import org.apache.hive.service.cli.SessionHandle; +import org.apache.hive.service.cli.thrift.EmbeddedThriftBinaryCLIService; +import org.apache.hive.service.cli.thrift.ThriftCLIServiceClient; +import org.junit.Assert; +import org.junit.Test; + +public class TestSessionCleanup extends TestCase { + + @Test + // This is to test session temporary files are cleaned up after HIVE-11768 + public void testTempSessionFileCleanup() throws Exception { + EmbeddedThriftBinaryCLIService service = new EmbeddedThriftBinaryCLIService(); + service.init(null); + ThriftCLIServiceClient client = new ThriftCLIServiceClient(service); + + Set existingPipeoutFiles = new HashSet(Arrays.asList(getPipeoutFiles())); + SessionHandle sessionHandle = client.openSession("user1", "foobar", + Collections.emptyMap()); + client.executeStatement(sessionHandle, "set a=b", null); + File operationLogRootDir = new File( + new HiveConf().getVar(ConfVars.HIVE_SERVER2_LOGGING_OPERATION_LOG_LOCATION)); + Assert.assertNotEquals(operationLogRootDir.list().length, 0); + client.closeSession(sessionHandle); + + // Check if session files are removed + Assert.assertEquals(operationLogRootDir.list().length, 0); + + // Check if the pipeout files are removed + Set finalPipeoutFiles = new HashSet(Arrays.asList(getPipeoutFiles())); + finalPipeoutFiles.removeAll(existingPipeoutFiles); + Assert.assertTrue(finalPipeoutFiles.isEmpty()); + } + + private String[] getPipeoutFiles() { + File localScratchDir = new File( + new HiveConf().getVar(HiveConf.ConfVars.LOCALSCRATCHDIR)); + String[] pipeoutFiles = localScratchDir.list(new FilenameFilter() { + @Override + public boolean accept(File dir, String name) { + if (name.endsWith("pipeout")) return true; + return false; + } + }); + return pipeoutFiles; + } +}