From 639387b8bbe365c28f326e408e9e48e5007f59c7 Mon Sep 17 00:00:00 2001 From: David McWhorter Date: Tue, 20 Oct 2015 16:27:49 -0400 Subject: [PATCH] HIVE-6712 Fix JDBC driver handling of setAutoCommit Change behavior to allow setAutoCommit(true) to succeed silently and setAutoCommit(false) to throw an exception and fail, as all Hive transactions automatically commit and hive does not yet support manual transactions (see https://cwiki.apache.org/confluence/display/Hive/Hive+Transactions#HiveTransactions-Limitations). --- jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java b/jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java index 2969bc6..6492d6b 100644 --- a/jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java +++ b/jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java @@ -1216,8 +1216,8 @@ public void rollback(Savepoint savepoint) throws SQLException { @Override public void setAutoCommit(boolean autoCommit) throws SQLException { - if (autoCommit) { - throw new SQLException("enabling autocommit is not supported"); + if (!autoCommit) { + throw new SQLException("disabling autocommit is not supported"); } } -- 2.5.1