Index: src/main/java/org/apache/jackrabbit/oak/plugins/index/IndexUpdate.java =================================================================== --- src/main/java/org/apache/jackrabbit/oak/plugins/index/IndexUpdate.java (revision 1708292) +++ src/main/java/org/apache/jackrabbit/oak/plugins/index/IndexUpdate.java (working copy) @@ -316,10 +316,13 @@ public static class MissingIndexProviderStrategy { + private boolean failOnMissingIndexProvider = Boolean + .getBoolean("IndexUpdate.failOnMissingIndexProvider"); + private final Set ignore = newHashSet("disabled"); - public void onMissingIndex(String type, NodeBuilder definition, String indexPath) - throws CommitFailedException { + public void onMissingIndex(String type, NodeBuilder definition, + String indexPath) throws CommitFailedException { if (isDisabled(type)) { return; } @@ -329,15 +332,26 @@ // already true, skip the update return; } - log.warn( - "Missing index provider of type [{}], requesting reindex on [{}]", - type, indexPath); - definition.setProperty(REINDEX_PROPERTY_NAME, true); + + if (failOnMissingIndexProvider) { + throw new CommitFailedException("IndexUpdate", 1, + "Missing index provider detected for type [" + type + + "] on index [" + indexPath + "]"); + } else { + log.warn( + "Missing index provider of type [{}], requesting reindex on [{}]", + type, indexPath); + definition.setProperty(REINDEX_PROPERTY_NAME, true); + } } boolean isDisabled(String type) { return ignore.contains(type); } + + void setFailOnMissingIndexProvider(boolean failOnMissingIndexProvider) { + this.failOnMissingIndexProvider = failOnMissingIndexProvider; + } } public IndexUpdate withMissingProviderStrategy( Index: src/test/java/org/apache/jackrabbit/oak/plugins/index/IndexUpdateTest.java =================================================================== --- src/test/java/org/apache/jackrabbit/oak/plugins/index/IndexUpdateTest.java (revision 1708313) +++ src/test/java/org/apache/jackrabbit/oak/plugins/index/IndexUpdateTest.java (working copy) @@ -32,6 +32,7 @@ import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertNull; import static org.junit.Assert.assertTrue; +import static org.junit.Assert.fail; import java.util.Set; @@ -40,6 +41,7 @@ import org.apache.jackrabbit.oak.api.CommitFailedException; import org.apache.jackrabbit.oak.api.PropertyState; import org.apache.jackrabbit.oak.api.Type; +import org.apache.jackrabbit.oak.plugins.index.IndexUpdate.MissingIndexProviderStrategy; import org.apache.jackrabbit.oak.plugins.index.property.PropertyIndexEditorProvider; import org.apache.jackrabbit.oak.plugins.index.property.PropertyIndexLookup; import org.apache.jackrabbit.oak.plugins.memory.EmptyNodeState; @@ -50,6 +52,7 @@ import org.apache.jackrabbit.oak.spi.commit.CommitInfo; import org.apache.jackrabbit.oak.spi.commit.Editor; import org.apache.jackrabbit.oak.spi.commit.EditorHook; +import org.apache.jackrabbit.oak.spi.commit.EditorProvider; import org.apache.jackrabbit.oak.spi.query.Filter; import org.apache.jackrabbit.oak.spi.query.PropertyValues; import org.apache.jackrabbit.oak.spi.state.NodeBuilder; @@ -390,6 +393,47 @@ azerty.getProperty(REINDEX_PROPERTY_NAME)); } + /** + * OAK-3505 Provide an optionally stricter policy for missing synchronous + * index editor providers + */ + @Test + public void testMissingProviderFailsCommit() throws Exception { + + final IndexUpdateCallback noop = new IndexUpdateCallback() { + @Override + public void indexUpdate() { + } + }; + final MissingIndexProviderStrategy mips = new MissingIndexProviderStrategy(); + mips.setFailOnMissingIndexProvider(true); + + EditorHook hook = new EditorHook(new EditorProvider() { + @Override + public Editor getRootEditor(NodeState before, NodeState after, + NodeBuilder builder, CommitInfo info) + throws CommitFailedException { + return new IndexUpdate(emptyProvider(), null, after, builder, + noop).withMissingProviderStrategy(mips); + } + }); + + NodeState before = builder.getNodeState(); + + createIndexDefinition(builder.child(INDEX_DEFINITIONS_NAME), + "rootIndex", true, false, ImmutableSet.of("foo"), null); + builder.child(INDEX_DEFINITIONS_NAME).child("azerty"); + builder.child("testRoot").setProperty("foo", "abc"); + NodeState after = builder.getNodeState(); + + try { + hook.processCommit(before, after, CommitInfo.EMPTY); + fail("commit should fail on missing index provider"); + } catch (CommitFailedException ex) { + // expected + } + } + @Test public void testReindexCount() throws Exception{ builder.child("testRoot").setProperty("foo", "abc");