commit 63a2fb5143ab41d84b6b44001b63806534b26bdd Author: stack Date: Mon Sep 14 08:32:52 2015 -0700 HBASE-14421 TestFastFail* are flakey; ADDENDUM 3 Exclude another should assert in TestFastFail diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFastFail.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFastFail.java index da31a7d..4121c16 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFastFail.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFastFail.java @@ -268,14 +268,13 @@ public class TestFastFail { assertEquals("The regionservers that returned true should equal to the" + " number of successful threads", numThreadsReturnedTrue, numSuccessfullThreads.get()); - assertTrue( - "There should be atleast one thread that retried instead of failing", - MyPreemptiveFastFailInterceptor.numBraveSouls.get() > 0); - /* 'should' is not worthy of an assert. Disabling because randomly this seems to randomly * not but true. St.Ack 20151012 * assertTrue( + "There should be atleast one thread that retried instead of failing", + MyPreemptiveFastFailInterceptor.numBraveSouls.get() > 0); + assertTrue( "There should be atleast one PreemptiveFastFail exception," + " otherwise, the test makes little sense." + "numPreemptiveFastFailExceptions: "