From a20a191b898c820134566da964808854f36ab84c Mon Sep 17 00:00:00 2001 From: gaodayue Date: Fri, 28 Aug 2015 17:54:14 +0800 Subject: [PATCH] KYLIN-975 fix bug when user configures database.for.intermediatetable --- job/src/main/java/org/apache/kylin/job/AbstractJobBuilder.java | 3 ++- job/src/main/java/org/apache/kylin/job/cube/GarbageCollectionStep.java | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/job/src/main/java/org/apache/kylin/job/AbstractJobBuilder.java b/job/src/main/java/org/apache/kylin/job/AbstractJobBuilder.java index 7ad8763..e6fde23 100644 --- a/job/src/main/java/org/apache/kylin/job/AbstractJobBuilder.java +++ b/job/src/main/java/org/apache/kylin/job/AbstractJobBuilder.java @@ -50,8 +50,9 @@ public abstract class AbstractJobBuilder { return cmd.append(" -").append(paraName).append(" ").append(paraValue); } + // return in full-qualified name, that is "dbname.tablename" protected String getIntermediateHiveTableName(IJoinedFlatTableDesc intermediateTableDesc, String jobUuid) { - return intermediateTableDesc.getTableName(jobUuid); + return engineConfig.getConfig().getHiveDatabaseForIntermediateTable() + "." + intermediateTableDesc.getTableName(jobUuid); } protected String getIntermediateHiveTableLocation(IJoinedFlatTableDesc intermediateTableDesc, String jobUUID) { diff --git a/job/src/main/java/org/apache/kylin/job/cube/GarbageCollectionStep.java b/job/src/main/java/org/apache/kylin/job/cube/GarbageCollectionStep.java index 2014131..4cb4a80 100644 --- a/job/src/main/java/org/apache/kylin/job/cube/GarbageCollectionStep.java +++ b/job/src/main/java/org/apache/kylin/job/cube/GarbageCollectionStep.java @@ -83,7 +83,7 @@ public class GarbageCollectionStep extends AbstractExecutable { private void dropHiveTable(ExecutableContext context) throws IOException { final String hiveTable = this.getOldHiveTable(); if (StringUtils.isNotEmpty(hiveTable)) { - final String dropSQL = "USE " + KylinConfig.getInstanceFromEnv().getHiveDatabaseForIntermediateTable() + ";" + " DROP TABLE IF EXISTS " + hiveTable + ";"; + final String dropSQL = "DROP TABLE IF EXISTS " + hiveTable + ";"; final String dropHiveCMD = "hive -e \"" + dropSQL + "\""; ShellCmdOutput shellCmdOutput = new ShellCmdOutput(); context.getConfig().getCliCommandExecutor().execute(dropHiveCMD, shellCmdOutput); -- 2.3.2 (Apple Git-55)