From fc9e938fa399ef66478f1bd6a851bcd172923b91 Mon Sep 17 00:00:00 2001 From: Gopal V Date: Tue, 18 Aug 2015 01:47:41 -0700 Subject: [PATCH] HIVE-11594: Column Stats quoting --- .../apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java | 6 +++--- ql/src/test/queries/clientpositive/columnstats_quoting.q | 8 ++++++++ 2 files changed, 11 insertions(+), 3 deletions(-) create mode 100644 ql/src/test/queries/clientpositive/columnstats_quoting.q diff --git ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java index a5f0a7f..8b7a2e8 100644 --- ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java +++ ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java @@ -175,7 +175,7 @@ private StringBuilder genPartitionClause(Map partSpec) throws Sem } else { whereClause.append(" and "); } - whereClause.append(partKey).append(" = ").append(genPartValueString(partKey, value)); + whereClause.append("`").append(partKey).append("` = ").append(genPartValueString(partKey, value)); } } @@ -308,9 +308,9 @@ private String genRewrittenQuery(List colNames, int numBitVectors, Map 0) { rewrittenQueryBuilder.append(" , "); } - rewrittenQueryBuilder.append("compute_stats("); + rewrittenQueryBuilder.append("compute_stats(`"); rewrittenQueryBuilder.append(colNames.get(i)); - rewrittenQueryBuilder.append(" , "); + rewrittenQueryBuilder.append("` , "); rewrittenQueryBuilder.append(numBitVectors); rewrittenQueryBuilder.append(" )"); } diff --git ql/src/test/queries/clientpositive/columnstats_quoting.q ql/src/test/queries/clientpositive/columnstats_quoting.q new file mode 100644 index 0000000..1bf4f91 --- /dev/null +++ ql/src/test/queries/clientpositive/columnstats_quoting.q @@ -0,0 +1,8 @@ +DROP TABLE IF EXISTS user_web_events; +create temporary table user_web_events(`user id` bigint, `user name` string); + +explain analyze table user_web_events compute statistics for columns; +analyze table user_web_events compute statistics for columns; + +explain analyze table user_web_events compute statistics for columns `user id`; +analyze table user_web_events compute statistics for columns `user id`; -- 2.4.0