diff --git oak-core/src/test/java/org/apache/jackrabbit/oak/security/user/UserManagerImplTest.java oak-core/src/test/java/org/apache/jackrabbit/oak/security/user/UserManagerImplTest.java index bc29c4e..f1bc23d 100644 --- oak-core/src/test/java/org/apache/jackrabbit/oak/security/user/UserManagerImplTest.java +++ oak-core/src/test/java/org/apache/jackrabbit/oak/security/user/UserManagerImplTest.java @@ -91,34 +91,16 @@ public class UserManagerImplTest extends AbstractSecurityTest { } @Test - public void testSetPassword() throws Exception { - User user = userMgr.createUser(testUserId, "pw"); - root.commit(); - - List pwds = new ArrayList(); - pwds.add("pw"); - pwds.add(""); - pwds.add("{sha1}pw"); - - Tree userTree = root.getTree(user.getPath()); - for (String pw : pwds) { - userMgr.setPassword(userTree, testUserId, pw, true); - String pwHash = userTree.getProperty(UserConstants.REP_PASSWORD).getValue(Type.STRING); - assertNotNull(pwHash); - assertTrue(PasswordUtil.isSame(pwHash, pw)); - } + public void testGetAuthorizableDoesNotThrowIAEOnEmptyString() throws Exception { + // in Jackrabbit it used to throw a IAE + userMgr.getAuthorizable(""); + } - for (String pw : pwds) { - userMgr.setPassword(userTree, testUserId, pw, false); - String pwHash = userTree.getProperty(UserConstants.REP_PASSWORD).getValue(Type.STRING); - assertNotNull(pwHash); - if (!pw.startsWith("{")) { - assertTrue(PasswordUtil.isSame(pwHash, pw)); - } else { - assertFalse(PasswordUtil.isSame(pwHash, pw)); - assertEquals(pw, pwHash); - } - } + @Test + public void testGetAuthorizableDoesNotThrowIAEOnNull() throws Exception { + // in Jackrabbit it used to throw a IAE + // in Oak it throws a NPE + userMgr.getAuthorizable((String) null); } @Test