From 4c9fd372b8bdd97a6e3592a1eacbd9b7ff8b54d0 Mon Sep 17 00:00:00 2001 From: Andrew Purtell Date: Wed, 8 Jul 2015 09:59:04 -0700 Subject: [PATCH] HBASE-14042 Fix FATAL level logging in FSHLog where logged for non fatal exceptions --- .../main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java index fad4d29..8941523 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java @@ -1242,7 +1242,7 @@ class FSHLog implements HLog, Syncable { // we need fail all the writes with txid <= txidToSync to avoid // 'data loss' where user get successful write response but can't // read the writes! - LOG.fatal("should never happen: has unsynced writes but writer is null!"); + LOG.error("should never happen: has unsynced writes but writer is null!"); asyncIOE = new IOException("has unsynced writes but writer is null!"); failedTxid.set(this.txidToSync); } else { @@ -1252,7 +1252,7 @@ class FSHLog implements HLog, Syncable { } postSync(); } catch (IOException e) { - LOG.fatal("Error while AsyncSyncer sync, request close of hlog ", e); + LOG.warn("Error while AsyncSyncer sync, request close of hlog ", e); requestLogRoll(); asyncIOE = e; @@ -1529,7 +1529,7 @@ class FSHLog implements HLog, Syncable { } this.metrics.finishAppend(took, len); } catch (IOException e) { - LOG.fatal("Could not append. Requesting close of hlog", e); + LOG.warn("Could not append. Requesting close of hlog", e); requestLogRoll(); throw e; } -- 2.2.2