diff --git metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java index 5d8718c..8a23bcc 100644 --- metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java +++ metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java @@ -6036,7 +6036,6 @@ public static void startMetaStore(int port, HadoopThriftAuthBridge bridge, } tServer.serve(); } catch (Throwable x) { - x.printStackTrace(); HMSHandler.LOG.error(StringUtils.stringifyException(x)); throw x; } diff --git ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java index 04c89ae..275adf7 100644 --- ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java +++ ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java @@ -1579,7 +1579,7 @@ private int unarchive(Hive db, AlterTableSimpleDesc simpleDesc) try { ret = ToolRunner.run(fss, args.toArray(new String[0])); } catch (Exception e) { - e.printStackTrace(); + LOG.warn("ToolRunner.run() failed", e); throw new HiveException(e); } diff --git ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java index 553113e..7d3130f 100644 --- ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java +++ ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java @@ -442,7 +442,7 @@ private void initializeSpecPath() { } catch (HiveException e) { throw e; } catch (Exception e) { - e.printStackTrace(); + LOG.warn("Unexpected failure", e); throw new HiveException(e); } return result; @@ -573,7 +573,7 @@ protected void createBucketFiles(FSPaths fsp) throws HiveException { autoDelete = fs.deleteOnExit(fsp.outPaths[0]); } } catch (Exception e) { - e.printStackTrace(); + LOG.warn("Unexpected failure", e); throw new HiveException(e); } diff --git ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableDummyOperator.java ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableDummyOperator.java index 2829a9d..6586a37 100644 --- ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableDummyOperator.java +++ ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableDummyOperator.java @@ -42,7 +42,6 @@ this.outputObjInspector = serde.getObjectInspector(); } catch (Exception e) { LOG.error("Generating output obj inspector from dummy object error", e); - e.printStackTrace(); } return result; } diff --git ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java index 069d91a..31f2d40 100644 --- ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java +++ ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java @@ -124,7 +124,7 @@ public void process(Object row, int tag) throws HiveException { } storage[alias].addRow(nr); } catch (Exception e) { - e.printStackTrace(); + LOG.warn("Unexpected failure", e); throw new HiveException(e); } } diff --git ql/src/java/org/apache/hadoop/hive/ql/exec/JoinUtil.java ql/src/java/org/apache/hadoop/hive/ql/exec/JoinUtil.java index 7b57550..316a9d2 100644 --- ql/src/java/org/apache/hadoop/hive/ql/exec/JoinUtil.java +++ ql/src/java/org/apache/hadoop/hive/ql/exec/JoinUtil.java @@ -22,6 +22,8 @@ import java.util.Map; import java.util.Map.Entry; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; import org.apache.hadoop.conf.Configuration; import org.apache.hadoop.hive.ql.exec.persistence.RowContainer; import org.apache.hadoop.hive.ql.io.HiveSequenceFileOutputFormat; @@ -47,6 +49,7 @@ import org.apache.hive.common.util.ReflectionUtil; public class JoinUtil { + public static final Log LOG = LogFactory.getLog(JoinUtil.class); /** * Represents the join result between two tables @@ -273,7 +276,7 @@ public static SerDe getSpillSerDe(byte alias, TableDesc[] spillTableDesc, try { SerDeUtils.initializeSerDe(sd, null, desc.getProperties(), null); } catch (SerDeException e) { - e.printStackTrace(); + LOG.warn("Call to SerDeUtils.initializeSerDe() failed", e); return null; } return sd; diff --git ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java index d7a08ec..56b1bc9 100644 --- ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java +++ ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java @@ -225,7 +225,6 @@ public int execute(DriverContext driverContext) { FileSystem fs = emptyScratchDir.getFileSystem(job); fs.mkdirs(emptyScratchDir); } catch (IOException e) { - e.printStackTrace(); console.printError("Error launching map-reduce job", "\n" + org.apache.hadoop.util.StringUtils.stringifyException(e)); return 5;