From cd2f52f814890b73eb27f3435685fffe1723ef2d Mon Sep 17 00:00:00 2001 From: Jun Rao Date: Tue, 27 Jan 2015 08:16:14 -0800 Subject: [PATCH] fix metric name by adding tags as scope --- core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala b/core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala index e9e4918..a94d816 100644 --- a/core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala +++ b/core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala @@ -61,9 +61,16 @@ trait KafkaMetricsGroup extends Logging { nameBuilder.append(name) } - KafkaMetricsGroup.toMBeanName(tags).map(mbeanName => nameBuilder.append(",").append(mbeanName)) + var scope: String = null + val tagsName = KafkaMetricsGroup.toMBeanName(tags) + tagsName match { + case Some(t) => + nameBuilder.append(",").append(t) + scope = t + case None => + } - new MetricName(group, typeName, name, null, nameBuilder.toString()) + new MetricName(group, typeName, name, scope, nameBuilder.toString()) } def newGauge[T](name: String, metric: Gauge[T], tags: scala.collection.Map[String, String] = Map.empty) = -- 1.8.5.2 (Apple Git-48)