From c59fac6c089c044fb835a702c87fb06bb84c78df Mon Sep 17 00:00:00 2001 From: Gwen Shapira Date: Mon, 19 Jan 2015 10:33:24 -0800 Subject: [PATCH 1/2] warn about acks > 1 or < -1 --- core/src/main/scala/kafka/server/KafkaApis.scala | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/core/src/main/scala/kafka/server/KafkaApis.scala b/core/src/main/scala/kafka/server/KafkaApis.scala index 7def852..7b78da7 100644 --- a/core/src/main/scala/kafka/server/KafkaApis.scala +++ b/core/src/main/scala/kafka/server/KafkaApis.scala @@ -194,6 +194,12 @@ class KafkaApis(val requestChannel: RequestChannel, (request.requestObj.asInstanceOf[ProducerRequest], None) } + if (produceRequest.requiredAcks > 1 || produceRequest.requiredAcks < -1) { + warn("Client %s (%s) sent a request with request.required.acks > 1 or < -1. This request parameter is now deprecated" + + " and will be removed in next release. Please consult Kafka documentation for supported and recommended configuration.", + produceRequest.clientId, request.remoteAddress) + } + val sTime = SystemTime.milliseconds val localProduceResults = appendToLocalLog(produceRequest, offsetCommitRequestOpt.nonEmpty) debug("Produce to local log in %d ms".format(SystemTime.milliseconds - sTime)) -- 1.9.3 (Apple Git-50) From d0c6dde069362377ae043b0fa5e5bcc7e672fec1 Mon Sep 17 00:00:00 2001 From: Gwen Shapira Date: Mon, 19 Jan 2015 10:57:16 -0800 Subject: [PATCH 2/2] fix string format --- core/src/main/scala/kafka/server/KafkaApis.scala | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/core/src/main/scala/kafka/server/KafkaApis.scala b/core/src/main/scala/kafka/server/KafkaApis.scala index 7b78da7..06eacdf 100644 --- a/core/src/main/scala/kafka/server/KafkaApis.scala +++ b/core/src/main/scala/kafka/server/KafkaApis.scala @@ -195,9 +195,9 @@ class KafkaApis(val requestChannel: RequestChannel, } if (produceRequest.requiredAcks > 1 || produceRequest.requiredAcks < -1) { - warn("Client %s (%s) sent a request with request.required.acks > 1 or < -1. This request parameter is now deprecated" + - " and will be removed in next release. Please consult Kafka documentation for supported and recommended configuration.", - produceRequest.clientId, request.remoteAddress) + warn("""Client %s (%s) sent a request with request.required.acks > 1 or < -1. This request parameter is now deprecated + and will be removed in next release. Please consult Kafka documentation for supported and recommended configuration.""".format( + produceRequest.clientId, request.remoteAddress)) } val sTime = SystemTime.milliseconds -- 1.9.3 (Apple Git-50)