From 7ce1d20c9dd346fa9f7bc9c0ff82342543af9e63 Mon Sep 17 00:00:00 2001 From: Ewen Cheslack-Postava Date: Wed, 15 Oct 2014 11:53:24 -0700 Subject: [PATCH 1/2] KAFKA-1108 Log IOException messages during controlled shutdown. --- core/src/main/scala/kafka/server/KafkaServer.scala | 1 + 1 file changed, 1 insertion(+) diff --git a/core/src/main/scala/kafka/server/KafkaServer.scala b/core/src/main/scala/kafka/server/KafkaServer.scala index 07c0a07..fd14a9b 100644 --- a/core/src/main/scala/kafka/server/KafkaServer.scala +++ b/core/src/main/scala/kafka/server/KafkaServer.scala @@ -236,6 +236,7 @@ class KafkaServer(val config: KafkaConfig, time: Time = SystemTime) extends Logg case ioe: java.io.IOException => channel.disconnect() channel = null + info("Error during controlled shutdown: %s".format(ioe.getMessage)) // ignore and try again } } -- 2.1.2 From e7f1e143d65f099c36181403e0f29f21279a2817 Mon Sep 17 00:00:00 2001 From: Ewen Cheslack-Postava Date: Thu, 16 Oct 2014 13:51:35 -0700 Subject: [PATCH 2/2] More informative message and increase log level to warn. --- core/src/main/scala/kafka/server/KafkaServer.scala | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/core/src/main/scala/kafka/server/KafkaServer.scala b/core/src/main/scala/kafka/server/KafkaServer.scala index fd14a9b..4de8123 100644 --- a/core/src/main/scala/kafka/server/KafkaServer.scala +++ b/core/src/main/scala/kafka/server/KafkaServer.scala @@ -220,7 +220,6 @@ class KafkaServer(val config: KafkaConfig, time: Time = SystemTime) extends Logg channel.send(request) response = channel.receive() - val shutdownResponse = ControlledShutdownResponse.readFrom(response.buffer) if (shutdownResponse.errorCode == ErrorMapping.NoError && shutdownResponse.partitionsRemaining != null && shutdownResponse.partitionsRemaining.size == 0) { @@ -236,7 +235,7 @@ class KafkaServer(val config: KafkaConfig, time: Time = SystemTime) extends Logg case ioe: java.io.IOException => channel.disconnect() channel = null - info("Error during controlled shutdown: %s".format(ioe.getMessage)) + warn("Error during controlled shutdown, possibly because leader movement took longer than the configured socket.timeout.ms: %s".format(ioe.getMessage)) // ignore and try again } } -- 2.1.2