diff --git ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java index 395b5e6..465aebd 100644 --- ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java +++ ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java @@ -281,6 +281,7 @@ import org.eigenbase.util.CompositeList; import org.eigenbase.util.ImmutableIntList; import org.eigenbase.util.Pair; +import org.eigenbase.util.Util; import com.google.common.base.Function; import com.google.common.collect.ImmutableList; @@ -13603,7 +13604,7 @@ private RelNode genSelectForWindowing(QB qb, RelNode srcRel) throws SemanticExce } private RelNode genSelectRelNode(List optiqColLst, RowResolver out_rwsch, - RelNode srcRel) { + RelNode srcRel) throws OptiqSemanticException { // 1. Build Column Names // TODO: Should this be external names ArrayList columnNames = new ArrayList(); @@ -13611,6 +13612,15 @@ private RelNode genSelectRelNode(List optiqColLst, RowResolver out_rwsc columnNames.add(getColumnInternalName(i)); } + // 1.1 Ensure columnNames are unique + if (!Util.isDistinct(columnNames)) { + String msg = String.format( + "Select list contains multiple expressions with the same name %s." + + columnNames); + LOG.debug(msg); + throw new OptiqSemanticException(msg); + } + // 2. Prepend column names with '_o_' /* * Hive treats names that start with '_c' as internalNames; so change the