### Eclipse Workspace Patch 1.0 #P hive_trunk Index: metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java =================================================================== --- metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java (revision 1619663) +++ metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java (working copy) @@ -47,7 +47,7 @@ private static final Map EQUIVALENT_VERSIONS = ImmutableMap.of("0.13.1", "0.13.0"); - public MetaStoreSchemaInfo(String hiveHome, HiveConf hiveConf, String dbType) throws HiveMetaException { + public MetaStoreSchemaInfo(String hiveHome, HiveConf hiveConf, String dbType) throws HiveMetaException, IOException { this.hiveHome = hiveHome; this.dbType = dbType; this.hiveConf = hiveConf; @@ -55,9 +55,9 @@ List upgradeOrderList = new ArrayList(); String upgradeListFile = getMetaStoreScriptDir() + File.separator + VERSION_UPGRADE_LIST + "." + dbType; + BufferedReader bfReader = null; try { - BufferedReader bfReader = - new BufferedReader(new FileReader(upgradeListFile)); + bfReader = new BufferedReader(new FileReader(upgradeListFile)); String currSchemaVersion; while ((currSchemaVersion = bfReader.readLine()) != null) { upgradeOrderList.add(currSchemaVersion.trim()); @@ -66,6 +66,8 @@ throw new HiveMetaException("File " + upgradeListFile + "not found ", e); } catch (IOException e) { throw new HiveMetaException("Error reading " + upgradeListFile, e); + } finally { + bfReader.close(); } hiveSchemaVersions = upgradeOrderList.toArray(new String[0]); }