Index: src/site/xdoc/manual/layouts.xml.vm =================================================================== --- src/site/xdoc/manual/layouts.xml.vm (revision 1613738) +++ src/site/xdoc/manual/layouts.xml.vm (working copy) @@ -329,6 +329,7 @@ SimpleDateFormat.

The predefined formats are + DEFAULT, ABSOLUTE, COMPACT, DATE, @@ -345,12 +346,16 @@ Example - %d{ISO8601} + %d{DEFAULT} 2012-11-02 14:34:02,781 + %d{ISO8601} + 2012-11-02T14:34:02,781 + + %d{ISO8601_BASIC} - 20121102 143402,781 + 20121102T143402,781 %d{ABSOLUTE} Index: log4j-core/src/test/java/org/apache/logging/log4j/core/pattern/DatePatternConverterTest.java =================================================================== --- log4j-core/src/test/java/org/apache/logging/log4j/core/pattern/DatePatternConverterTest.java (revision 1613738) +++ log4j-core/src/test/java/org/apache/logging/log4j/core/pattern/DatePatternConverterTest.java (working copy) @@ -39,7 +39,7 @@ StringBuilder sb = new StringBuilder(); converter.format(event, sb); - String expected = "2011-12-30T10:56:35,987"; + String expected = "2011-12-30 10:56:35,987"; assertEquals(expected, sb.toString()); } @@ -71,7 +71,7 @@ StringBuilder sb = new StringBuilder(); converter.format(date(2001, 1, 1), sb); - String expected = "2001-02-01T14:15:16,123"; + String expected = "2001-02-01 14:15:16,123"; assertEquals(expected, sb.toString()); } @@ -81,7 +81,7 @@ StringBuilder sb = new StringBuilder(); converter.format(sb, date(2001, 1, 1), date(2002, 2, 2), date(2003, 3, 3)); - String expected = "2001-02-01T14:15:16,123"; // only process first date + String expected = "2001-02-01 14:15:16,123"; // only process first date assertEquals(expected, sb.toString()); } @@ -93,8 +93,8 @@ } @Test - public void testGetPatternReturnsISO8601ByDefault() { - assertEquals(DatePatternConverter.ISO8601_PATTERN, DatePatternConverter.newInstance(null).getPattern()); + public void testGetPatternReturnsCorrectDefault() { + assertEquals(DatePatternConverter.DEFAULT_PATTERN, DatePatternConverter.newInstance(null).getPattern()); } } Index: log4j-core/src/test/resources/log4j2-perf2.xml =================================================================== --- log4j-core/src/test/resources/log4j2-perf2.xml (revision 1613738) +++ log4j-core/src/test/resources/log4j2-perf2.xml (working copy) @@ -20,7 +20,7 @@ - %d{ISO8601} %5p [%t] %c{1} %X{transactionId} - %m%n + %d %5p [%t] %c{1} %X{transactionId} - %m%n @@ -29,4 +29,4 @@ - \ No newline at end of file + Index: log4j-core/src/test/resources/log4j2-console-style-ansi.xml =================================================================== --- log4j-core/src/test/resources/log4j2-console-style-ansi.xml (revision 1613738) +++ log4j-core/src/test/resources/log4j2-console-style-ansi.xml (working copy) @@ -19,7 +19,7 @@ - + @@ -28,4 +28,4 @@ - \ No newline at end of file + Index: log4j-core/src/test/resources/log4j2-console-highlight-logback.xml =================================================================== --- log4j-core/src/test/resources/log4j2-console-highlight-logback.xml (revision 1613738) +++ log4j-core/src/test/resources/log4j2-console-highlight-logback.xml (working copy) @@ -19,7 +19,7 @@ - + @@ -28,4 +28,4 @@ - \ No newline at end of file + Index: log4j-core/src/test/resources/log4j2-perf-filter.xml =================================================================== --- log4j-core/src/test/resources/log4j2-perf-filter.xml (revision 1613738) +++ log4j-core/src/test/resources/log4j2-perf-filter.xml (working copy) @@ -24,7 +24,7 @@ - %d{ISO8601} %5p [%t] %c{1} %X{transactionId} - %m%n + %d %5p [%t] %c{1} %X{transactionId} - %m%n @@ -33,4 +33,4 @@ - \ No newline at end of file + Index: log4j-core/src/test/resources/log4j2-console-highlight-default.xml =================================================================== --- log4j-core/src/test/resources/log4j2-console-highlight-default.xml (revision 1613738) +++ log4j-core/src/test/resources/log4j2-console-highlight-default.xml (working copy) @@ -19,7 +19,7 @@ - + @@ -28,4 +28,4 @@ - \ No newline at end of file + Index: log4j-core/src/test/resources/log4j2-console-style-name-ansi.xml =================================================================== --- log4j-core/src/test/resources/log4j2-console-style-name-ansi.xml (revision 1613738) +++ log4j-core/src/test/resources/log4j2-console-style-name-ansi.xml (working copy) @@ -19,7 +19,7 @@ - + @@ -28,4 +28,4 @@ - \ No newline at end of file + Index: log4j-core/src/test/resources/logback-perf-filter.xml =================================================================== --- log4j-core/src/test/resources/logback-perf-filter.xml (revision 1613738) +++ log4j-core/src/test/resources/logback-perf-filter.xml (working copy) @@ -26,11 +26,11 @@ target/testlogback.log - %d{ISO8601} %5p [%t] %c{0} %X{transactionId} - %m%n + %d %5p [%t] %c{0} %X{transactionId} - %m%n - \ No newline at end of file + Index: log4j-core/src/test/resources/log4j2-perf.xml =================================================================== --- log4j-core/src/test/resources/log4j2-perf.xml (revision 1613738) +++ log4j-core/src/test/resources/log4j2-perf.xml (working copy) @@ -20,7 +20,7 @@ - %d{ISO8601} %5p [%t] %c{1} %X{transactionId} - %m%n + %d %5p [%t] %c{1} %X{transactionId} - %m%n @@ -29,4 +29,4 @@ - \ No newline at end of file + Index: log4j-core/src/test/resources/log4j2-console-style-no-ansi.xml =================================================================== --- log4j-core/src/test/resources/log4j2-console-style-no-ansi.xml (revision 1613738) +++ log4j-core/src/test/resources/log4j2-console-style-no-ansi.xml (working copy) @@ -20,7 +20,7 @@ + pattern="%style{%d}{black} %style{[%t]}{blue} %style{%-5level:}{yellow} %style{%msg%n%throwable}{green}" /> Index: log4j-core/src/test/resources/logback-perf2.xml =================================================================== --- log4j-core/src/test/resources/logback-perf2.xml (revision 1613738) +++ log4j-core/src/test/resources/logback-perf2.xml (working copy) @@ -19,11 +19,11 @@ target/testlogback.log - %d{ISO8601} %5p [%t] %c{0} %X{transactionId} - %m%n + %d %5p [%t] %c{0} %X{transactionId} - %m%n - \ No newline at end of file + Index: log4j-core/src/test/resources/log4j2-console-highlight.xml =================================================================== --- log4j-core/src/test/resources/log4j2-console-highlight.xml (revision 1613738) +++ log4j-core/src/test/resources/log4j2-console-highlight.xml (working copy) @@ -19,7 +19,7 @@ - + @@ -28,4 +28,4 @@ - \ No newline at end of file + Index: log4j-core/src/test/resources/logback-perf.xml =================================================================== --- log4j-core/src/test/resources/logback-perf.xml (revision 1613738) +++ log4j-core/src/test/resources/logback-perf.xml (working copy) @@ -20,11 +20,11 @@ target/testlogback.log false - %d{ISO8601} %5p [%t] %c{0} %X{transactionId} - %m%n + %d %5p [%t] %c{0} %X{transactionId} - %m%n - \ No newline at end of file + Index: log4j-core/src/test/resources/log4j12-perf2.xml =================================================================== --- log4j-core/src/test/resources/log4j12-perf2.xml (revision 1613738) +++ log4j-core/src/test/resources/log4j12-perf2.xml (working copy) @@ -21,11 +21,11 @@ - + - \ No newline at end of file + Index: log4j-core/src/test/resources/log4j2-console.xml =================================================================== --- log4j-core/src/test/resources/log4j2-console.xml (revision 1613738) +++ log4j-core/src/test/resources/log4j2-console.xml (working copy) @@ -19,7 +19,7 @@ - + @@ -28,4 +28,4 @@ - \ No newline at end of file + Index: log4j-core/src/test/resources/AsyncLoggerTimestampMessageTest.xml =================================================================== --- log4j-core/src/test/resources/AsyncLoggerTimestampMessageTest.xml (revision 0) +++ log4j-core/src/test/resources/AsyncLoggerTimestampMessageTest.xml (revision 0) @@ -0,0 +1,17 @@ + + + + + + %d{UNIX_MILLIS} %m%n + + + + + + + + + + \ No newline at end of file Index: log4j-core/src/test/resources/log4j2-319.xml =================================================================== --- log4j-core/src/test/resources/log4j2-319.xml (revision 1613738) +++ log4j-core/src/test/resources/log4j2-319.xml (working copy) @@ -20,7 +20,7 @@ - + @@ -29,4 +29,4 @@ - \ No newline at end of file + Index: log4j-core/src/test/resources/log4j12-perf.xml =================================================================== --- log4j-core/src/test/resources/log4j12-perf.xml (revision 1613738) +++ log4j-core/src/test/resources/log4j12-perf.xml (working copy) @@ -21,11 +21,11 @@ - + - \ No newline at end of file + Index: log4j-core/src/test/resources/logback-subst.xml =================================================================== --- log4j-core/src/test/resources/logback-subst.xml (revision 1613738) +++ log4j-core/src/test/resources/logback-subst.xml (working copy) @@ -18,11 +18,11 @@ - %d{ISO8601} %5p [%t] %c{0} - %m%n + %d %5p [%t] %c{0} - %m%n - \ No newline at end of file + Index: log4j-core/src/test/resources/logback-flume.xml =================================================================== --- log4j-core/src/test/resources/logback-flume.xml (revision 1613738) +++ log4j-core/src/test/resources/logback-flume.xml (working copy) @@ -18,11 +18,11 @@ - %d{ISO8601} %5p [%t] %c{0} %X{transactionId} - %m%n + %d %5p [%t] %c{0} %X{transactionId} - %m%n - \ No newline at end of file + Index: log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java =================================================================== --- log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java (revision 1613738) +++ log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java (working copy) @@ -105,6 +105,16 @@ private static final String DATE_AND_TIME_PATTERN = "dd MMM yyyy HH:mm:ss,SSS"; /** + * DEFAULT string literal. + */ + private static final String DEFAULT_FORMAT = "DEFAULT"; + + /** + * SimpleTimePattern for DEFAULT. + */ + static final String DEFAULT_PATTERN = "yyyy-MM-dd HH:mm:ss,SSS"; + + /** * ISO8601_BASIC string literal. */ private static final String ISO8601_BASIC_FORMAT = "ISO8601_BASIC"; @@ -169,7 +179,9 @@ String pattern = null; Formatter tempFormatter = null; - if (patternOption == null || patternOption.equalsIgnoreCase(ISO8601_FORMAT)) { + if (patternOption == null || patternOption.equalsIgnoreCase(DEFAULT_FORMAT)) { + pattern = DEFAULT_PATTERN; + } else if (patternOption.equalsIgnoreCase(ISO8601_FORMAT)) { pattern = ISO8601_PATTERN; } else if (patternOption.equalsIgnoreCase(ISO8601_BASIC_FORMAT)) { pattern = ISO8601_BASIC_PATTERN; @@ -195,8 +207,8 @@ } catch (final IllegalArgumentException e) { LOGGER.warn("Could not instantiate SimpleDateFormat with pattern " + patternOption, e); - // default to the ISO8601 format - tempFormat = new SimpleDateFormat(ISO8601_PATTERN); + // default to the DEFAULT format + tempFormat = new SimpleDateFormat(DEFAULT_PATTERN); } // if the option list contains a TZ option, then set it.