diff --git a/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/property/OrderedPropertyIndex.java b/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/property/OrderedPropertyIndex.java index 0fb6c35..908bcf2 100644 --- a/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/property/OrderedPropertyIndex.java +++ b/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/property/OrderedPropertyIndex.java @@ -19,10 +19,13 @@ package org.apache.jackrabbit.oak.plugins.index.property; import static org.apache.jackrabbit.oak.plugins.index.property.OrderedIndex.TYPE; +import org.apache.jackrabbit.oak.spi.query.Filter; import org.apache.jackrabbit.oak.spi.state.NodeState; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; public class OrderedPropertyIndex extends PropertyIndex { - + private static final Logger log = LoggerFactory.getLogger(OrderedPropertyIndex.class); @Override public String getIndexName() { return TYPE; @@ -32,4 +35,11 @@ public class OrderedPropertyIndex extends PropertyIndex { PropertyIndexLookup getLookup(NodeState root) { return new OrderedPropertyIndexLookup(root); } + + @Override + public double getCost(Filter filter, NodeState root) { + //we don't want the index to be used yet + log.warn("this index will always return Double.POSITIVE_INFINITY and therefore never work"); + return Double.POSITIVE_INFINITY; + } } diff --git a/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/property/LowCostOrderedPropertyIndexProvider.java b/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/property/LowCostOrderedPropertyIndexProvider.java new file mode 100644 index 0000000..69b4c13 --- /dev/null +++ b/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/property/LowCostOrderedPropertyIndexProvider.java @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.jackrabbit.oak.plugins.index.property; + +import java.util.List; + +import org.apache.jackrabbit.oak.spi.query.Filter; +import org.apache.jackrabbit.oak.spi.query.QueryIndex; +import org.apache.jackrabbit.oak.spi.state.NodeState; + +import com.google.common.collect.ImmutableList; + +/** + * convenience provider for going around the INFINITE cost of the actual index implementation + */ +public class LowCostOrderedPropertyIndexProvider extends OrderedPropertyIndexProvider { + @Override + public List getQueryIndexes(NodeState nodeState) { + return ImmutableList. of(new LowCostOrderedPropertyIndex()); + } + + private static class LowCostOrderedPropertyIndex extends OrderedPropertyIndex { + @Override + public double getCost(Filter filter, NodeState root) { + return 1e-3; + } + } +} diff --git a/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/property/OrderedPropertyIndexQueryTest.java b/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/property/OrderedPropertyIndexQueryTest.java index 5329c4c..105228a 100644 --- a/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/property/OrderedPropertyIndexQueryTest.java +++ b/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/property/OrderedPropertyIndexQueryTest.java @@ -179,9 +179,8 @@ public class OrderedPropertyIndexQueryTest extends AbstractQueryTest { protected ContentRepository createRepository() { return new Oak().with(new InitialContent()) .with(new OpenSecurityProvider()) - // .with(new PropertyIndexProvider()) - // .with(new PropertyIndexEditorProvider()) - .with(new OrderedPropertyIndexProvider()).with(new OrderedPropertyIndexEditorProvider()) + .with(new LowCostOrderedPropertyIndexProvider()) + .with(new OrderedPropertyIndexEditorProvider()) .createContentRepository(); }