diff --git ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java index 15f1011..b8552a3 100644 --- ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java +++ ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java @@ -147,6 +147,7 @@ public void open(String sessionId, HiveConf conf) /** * Close a tez session. Will cleanup any tez/am related resources. After closing a session * no further DAGs can be executed against it. + * @param keepTmpDir whether or not to remove the scratch dir at the same time. * @throws IOException * @throws TezException */ @@ -212,7 +213,6 @@ private Path createTezDir(String sessionId) /** * Returns a local resource representing the hive-exec jar. This resource will * be used to execute the plan on the cluster. - * @param conf * @return LocalResource corresponding to the localized hive exec resource. * @throws IOException when any file system related call fails. * @throws LoginException when we are unable to determine the user. diff --git ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java index fac74a6..384342a 100644 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java +++ ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java @@ -39,7 +39,7 @@ import org.apache.hadoop.hive.ql.plan.Statistics; /** - * ConvertJoinMapJoin is an optimization that replaces a commone join + * ConvertJoinMapJoin is an optimization that replaces a common join * (aka shuffle join) with a map join (aka broadcast or fragment replicate * join when possible. Map joins have restrictions on which joins can be * converted (e.g.: full outer joins cannot be handled as map joins) as well diff --git ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinProc.java ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinProc.java index 7c2324f..1a36dab 100644 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinProc.java +++ ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinProc.java @@ -34,8 +34,8 @@ /* (non-Javadoc) * This processor addresses the RS-MJ case that occurs in tez on the small/hash - * table side of things. The connection between the work that RS will be a part of - * must be connected to the MJ work via be a broadcast edge. + * table side of things. The work that RS will be a part of must be connected + * to the MJ work via be a broadcast edge. * We should not walk down the tree when we encounter this pattern because: * the type of work (map work or reduce work) needs to be determined * on the basis of the big table side because it may be a mapwork (no need for shuffle) diff --git ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java index 92053cb..6ee6bee 100644 --- ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java +++ ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java @@ -419,7 +419,7 @@ public static TableDesc getMapJoinKeyTableDesc(Configuration conf, } /** - * Generate the table descriptor for Map-side join key. + * Generate the table descriptor for Map-side join value. */ public static TableDesc getMapJoinValueTableDesc( List fieldSchemas) { diff --git ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregatorTez.java ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregatorTez.java index 6e3a1ca..d63406e 100644 --- ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregatorTez.java +++ ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregatorTez.java @@ -27,6 +27,12 @@ import org.apache.hadoop.hive.ql.exec.tez.TezTask; import org.apache.tez.common.counters.TezCounters; +/** + * This class aggregates stats via counters and does so for Tez Tasks. + * With dbclass=counters this class will compute table/partition statistics + * using hadoop counters. They will be published using special keys and + * then retrieved on the client after the insert/ctas statement ran. + */ public class CounterStatsAggregatorTez implements StatsAggregator { private static final Log LOG = LogFactory.getLog(CounterStatsAggregatorTez.class.getName());