From ab548d99f95c9cad8a1baf9002c87ecf57895c6c Mon Sep 17 00:00:00 2001 From: Elliott Neil Clark Date: Tue, 26 Nov 2013 13:22:14 -0800 Subject: [PATCH] HBASE-10038 Fix potential Resource Leak in ZNodeCleaner --- .../src/main/java/org/apache/hadoop/hbase/ZNodeClearer.java | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/ZNodeClearer.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/ZNodeClearer.java index 52c4329..79929ef 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/ZNodeClearer.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/ZNodeClearer.java @@ -94,10 +94,14 @@ public class ZNodeClearer { throw new FileNotFoundException("No filename; set environment variable HBASE_ZNODE_FILE"); } FileReader znodeFile = new FileReader(fileName); - BufferedReader br = new BufferedReader(znodeFile); - String file_content = br.readLine(); - br.close(); - return file_content; + BufferedReader br = null; + try { + br = new BufferedReader(znodeFile); + String file_content = br.readLine(); + return file_content; + } finally { + if (br != null) br.close(); + } } /** -- 1.8.4.3