From 965de080bc7b662d6eb2d9a56d2d6e47b924264d Mon Sep 17 00:00:00 2001 From: Elliott Clark Date: Wed, 28 Aug 2013 14:59:06 -0700 Subject: [PATCH] HBASE-9370 Add logging to Schema change Chaos actions. --- .../org/apache/hadoop/hbase/chaos/actions/AddColumnAction.java | 4 ++++ .../apache/hadoop/hbase/chaos/actions/ChangeEncodingAction.java | 3 +++ .../apache/hadoop/hbase/chaos/actions/ChangeVersionsAction.java | 4 +++- .../org/apache/hadoop/hbase/chaos/actions/RemoveColumnAction.java | 4 +++- 4 files changed, 13 insertions(+), 2 deletions(-) diff --git hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/AddColumnAction.java hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/AddColumnAction.java index aa8a35c..a96d43c 100644 --- hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/AddColumnAction.java +++ hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/AddColumnAction.java @@ -32,9 +32,11 @@ import org.apache.hadoop.hbase.util.Bytes; */ public class AddColumnAction extends Action { private final byte[] tableName; + private final String tableNameString; private HBaseAdmin admin; public AddColumnAction(String tableName) { + tableNameString = tableName; this.tableName = Bytes.toBytes(tableName); } @@ -54,6 +56,8 @@ public class AddColumnAction extends Action { columnDescriptor = new HColumnDescriptor(RandomStringUtils.randomAlphabetic(5)); } + LOG.debug("Adding " + columnDescriptor + " to " + tableNameString); + tableDescriptor.addFamily(columnDescriptor); admin.modifyTable(tableName, tableDescriptor); } diff --git hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeEncodingAction.java hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeEncodingAction.java index 9fc8e58..0eb0bf9 100644 --- hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeEncodingAction.java +++ hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeEncodingAction.java @@ -32,11 +32,13 @@ import org.apache.hadoop.hbase.util.Bytes; */ public class ChangeEncodingAction extends Action { private final byte[] tableName; + private final String tableNameString; private HBaseAdmin admin; private Random random; public ChangeEncodingAction(String tableName) { + tableNameString = tableName; this.tableName = Bytes.toBytes(tableName); this.random = new Random(); } @@ -56,6 +58,7 @@ public class ChangeEncodingAction extends Action { return; } + LOG.debug("Changing encodings on " + tableNameString); // possible DataBlockEncoding id's int[] possibleIds = {0, 2, 3, 4, 6}; for (HColumnDescriptor descriptor : columnDescriptors) { diff --git hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeVersionsAction.java hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeVersionsAction.java index 499c501..2bebdb3 100644 --- hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeVersionsAction.java +++ hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeVersionsAction.java @@ -33,11 +33,13 @@ import org.apache.hadoop.hbase.util.Bytes; */ public class ChangeVersionsAction extends Action { private final byte[] tableName; + private final String tableNameString; private HBaseAdmin admin; private Random random; public ChangeVersionsAction(String tableName) { + tableNameString = tableName; this.tableName = Bytes.toBytes(tableName); this.random = new Random(); } @@ -62,7 +64,7 @@ public class ChangeVersionsAction extends Action { descriptor.setMaxVersions(versions); descriptor.setMinVersions(versions); } - + LOG.debug("Changing versions on " + tableNameString); admin.modifyTable(tableName, tableDescriptor); } } diff --git hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RemoveColumnAction.java hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RemoveColumnAction.java index 583dc55..72f6b6d 100644 --- hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RemoveColumnAction.java +++ hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RemoveColumnAction.java @@ -33,10 +33,12 @@ import org.apache.hadoop.hbase.util.Bytes; public class RemoveColumnAction extends Action { private final byte[] tableName; private final Set protectedColumns; + private final String tableNameString; private HBaseAdmin admin; private Random random; public RemoveColumnAction(String tableName, Set protectedColumns) { + tableNameString = tableName; this.tableName = Bytes.toBytes(tableName); this.protectedColumns = protectedColumns; random = new Random(); @@ -62,7 +64,7 @@ public class RemoveColumnAction extends Action { protectedColumns.contains(columnDescriptors[index].getNameAsString())) { index = random.nextInt(columnDescriptors.length); } - + LOG.debug("Removing " + columnDescriptors[index].getName() + " from " + tableNameString); tableDescriptor.removeFamily(columnDescriptors[index].getName()); admin.modifyTable(tableName, tableDescriptor); -- 1.7.10.2 (Apple Git-33)