diff --git a/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java b/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java index 193ace1..8966905 100644 --- a/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java +++ b/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java @@ -334,7 +334,7 @@ public class ZKProcedureMemberRpcs implements ProcedureMemberRpcs { } public void start(final String memberName, final ProcedureMember listener) { - LOG.debug("Starting procedure member '" + this.memberName + "'"); + LOG.debug("Starting procedure member '" + memberName + "'"); this.member = listener; this.memberName = memberName; watchForAbortedProcedures(); @@ -346,4 +346,4 @@ public class ZKProcedureMemberRpcs implements ProcedureMemberRpcs { zkController.close(); } -} \ No newline at end of file +} diff --git a/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java b/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java index b168855..09eb8a8 100644 --- a/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java +++ b/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java @@ -835,8 +835,9 @@ public class HRegionServer implements HRegionInterface, HBaseRPCErrorHandler, this.healthCheckChore.interrupt(); } + // Stop the snapshot handler, forcefully killing all running tasks try { - if (snapshotManager != null) snapshotManager.stop(this.abortRequested); + if (snapshotManager != null) snapshotManager.stop(this.abortRequested || this.killed); } catch (IOException e) { LOG.warn("Failed to close snapshot handler cleanly", e); } @@ -857,13 +858,6 @@ public class HRegionServer implements HRegionInterface, HBaseRPCErrorHandler, // handlers are stuck waiting on meta or root. if (this.catalogTracker != null) this.catalogTracker.stop(); - // stop the snapshot handler, forcefully killing all running tasks - try { - if (snapshotManager != null) snapshotManager.stop(this.abortRequested || this.killed); - } catch (IOException e) { - LOG.warn("Failed to close snapshot handler cleanly", e); - } - // Closing the compactSplit thread before closing meta regions if (!this.killed && containsMetaTableRegions()) { if (!abortRequested || this.fsOk) {