Index: lucene/core/src/test/org/apache/lucene/codecs/lucene40/TestReuseDocsEnum.java =================================================================== --- lucene/core/src/test/org/apache/lucene/codecs/lucene40/TestReuseDocsEnum.java (revision 1503742) +++ lucene/core/src/test/org/apache/lucene/codecs/lucene40/TestReuseDocsEnum.java (working copy) @@ -162,7 +162,7 @@ return null; } TermsEnum iterator = terms.iterator(null); - if (iterator.seekExact(term, true)) { + if (iterator.seekExact(term)) { return iterator.docs(bits, null, random().nextBoolean() ? DocsEnum.FLAG_FREQS : DocsEnum.FLAG_NONE); } return null; Index: lucene/core/src/test/org/apache/lucene/codecs/lucene41/TestBlockPostingsFormat3.java =================================================================== --- lucene/core/src/test/org/apache/lucene/codecs/lucene41/TestBlockPostingsFormat3.java (revision 1503742) +++ lucene/core/src/test/org/apache/lucene/codecs/lucene41/TestBlockPostingsFormat3.java (working copy) @@ -235,21 +235,21 @@ leftEnum = leftTerms.iterator(leftEnum); rightEnum = rightTerms.iterator(rightEnum); - assertEquals(leftEnum.seekExact(b, false), rightEnum.seekExact(b, false)); - assertEquals(leftEnum.seekExact(b, true), rightEnum.seekExact(b, true)); + assertEquals(leftEnum.seekExact(b), rightEnum.seekExact(b)); + assertEquals(leftEnum.seekExact(b), rightEnum.seekExact(b)); SeekStatus leftStatus; SeekStatus rightStatus; - leftStatus = leftEnum.seekCeil(b, false); - rightStatus = rightEnum.seekCeil(b, false); + leftStatus = leftEnum.seekCeil(b); + rightStatus = rightEnum.seekCeil(b); assertEquals(leftStatus, rightStatus); if (leftStatus != SeekStatus.END) { assertEquals(leftEnum.term(), rightEnum.term()); } - leftStatus = leftEnum.seekCeil(b, true); - rightStatus = rightEnum.seekCeil(b, true); + leftStatus = leftEnum.seekCeil(b); + rightStatus = rightEnum.seekCeil(b); assertEquals(leftStatus, rightStatus); if (leftStatus != SeekStatus.END) { assertEquals(leftEnum.term(), rightEnum.term()); Index: lucene/core/src/test/org/apache/lucene/search/spans/MultiSpansWrapper.java =================================================================== --- lucene/core/src/test/org/apache/lucene/search/spans/MultiSpansWrapper.java (revision 1503742) +++ lucene/core/src/test/org/apache/lucene/search/spans/MultiSpansWrapper.java (working copy) @@ -60,7 +60,7 @@ TreeSet terms = new TreeSet(); query.extractTerms(terms); for (Term term : terms) { - termContexts.put(term, TermContext.build(topLevelReaderContext, term, true)); + termContexts.put(term, TermContext.build(topLevelReaderContext, term)); } final List leaves = topLevelReaderContext.leaves(); if(leaves.size() == 1) { Index: lucene/core/src/test/org/apache/lucene/search/TestMinShouldMatch2.java =================================================================== --- lucene/core/src/test/org/apache/lucene/search/TestMinShouldMatch2.java (revision 1503742) +++ lucene/core/src/test/org/apache/lucene/search/TestMinShouldMatch2.java (working copy) @@ -294,7 +294,7 @@ if (ord >= 0) { boolean success = ords.add(ord); assert success; // no dups - TermContext context = TermContext.build(reader.getContext(), term, true); + TermContext context = TermContext.build(reader.getContext(), term); SimWeight w = weight.similarity.computeWeight(1f, searcher.collectionStatistics("field"), searcher.termStatistics(term, context)); Index: lucene/core/src/test/org/apache/lucene/index/TestPerSegmentDeletes.java =================================================================== --- lucene/core/src/test/org/apache/lucene/index/TestPerSegmentDeletes.java (revision 1503742) +++ lucene/core/src/test/org/apache/lucene/index/TestPerSegmentDeletes.java (working copy) @@ -227,7 +227,7 @@ Fields fields = MultiFields.getFields(reader); Terms cterms = fields.terms(term.field); TermsEnum ctermsEnum = cterms.iterator(null); - if (ctermsEnum.seekExact(new BytesRef(term.text()), false)) { + if (ctermsEnum.seekExact(new BytesRef(term.text()))) { DocsEnum docsEnum = _TestUtil.docs(random(), ctermsEnum, bits, null, DocsEnum.FLAG_NONE); return toArray(docsEnum); } Index: lucene/core/src/test/org/apache/lucene/index/TestDocsAndPositions.java =================================================================== --- lucene/core/src/test/org/apache/lucene/index/TestDocsAndPositions.java (revision 1503742) +++ lucene/core/src/test/org/apache/lucene/index/TestDocsAndPositions.java (working copy) @@ -95,7 +95,7 @@ Terms terms = reader.terms(fieldName); if (terms != null) { TermsEnum te = terms.iterator(null); - if (te.seekExact(bytes, true)) { + if (te.seekExact(bytes)) { return te.docsAndPositions(liveDocs, null); } } @@ -341,7 +341,7 @@ // now reuse and check again TermsEnum te = r.terms("foo").iterator(null); - assertTrue(te.seekExact(new BytesRef("bar"), true)); + assertTrue(te.seekExact(new BytesRef("bar"))); disi = _TestUtil.docs(random(), te, null, disi, DocsEnum.FLAG_NONE); docid = disi.docID(); assertEquals(-1, docid); @@ -366,7 +366,7 @@ // now reuse and check again TermsEnum te = r.terms("foo").iterator(null); - assertTrue(te.seekExact(new BytesRef("bar"), true)); + assertTrue(te.seekExact(new BytesRef("bar"))); disi = te.docsAndPositions(null, disi); docid = disi.docID(); assertEquals(-1, docid); Index: lucene/core/src/test/org/apache/lucene/index/TestDocTermOrds.java =================================================================== --- lucene/core/src/test/org/apache/lucene/index/TestDocTermOrds.java (revision 1503742) +++ lucene/core/src/test/org/apache/lucene/index/TestDocTermOrds.java (working copy) @@ -332,7 +332,7 @@ Terms terms = MultiFields.getTerms(r, "field"); if (terms != null) { TermsEnum termsEnum = terms.iterator(null); - TermsEnum.SeekStatus result = termsEnum.seekCeil(prefixRef, false); + TermsEnum.SeekStatus result = termsEnum.seekCeil(prefixRef); if (result != TermsEnum.SeekStatus.END) { assertFalse("term=" + termsEnum.term().utf8ToString() + " matches prefix=" + prefixRef.utf8ToString(), StringHelper.startsWith(termsEnum.term(), prefixRef)); } else { @@ -454,16 +454,16 @@ assertEquals(SeekStatus.END, termsEnum.seekCeil(new BytesRef("zzz"))); // seekExact() - assertTrue(termsEnum.seekExact(new BytesRef("beer"), true)); + assertTrue(termsEnum.seekExact(new BytesRef("beer"))); assertEquals("beer", termsEnum.term().utf8ToString()); assertEquals(0, termsEnum.ord()); - assertTrue(termsEnum.seekExact(new BytesRef("hello"), true)); + assertTrue(termsEnum.seekExact(new BytesRef("hello"))); assertEquals("hello", termsEnum.term().utf8ToString()); assertEquals(1, termsEnum.ord()); - assertTrue(termsEnum.seekExact(new BytesRef("world"), true)); + assertTrue(termsEnum.seekExact(new BytesRef("world"))); assertEquals("world", termsEnum.term().utf8ToString()); assertEquals(2, termsEnum.ord()); - assertFalse(termsEnum.seekExact(new BytesRef("bogus"), true)); + assertFalse(termsEnum.seekExact(new BytesRef("bogus"))); // seek(ord) termsEnum.seekExact(0); Index: lucene/core/src/test/org/apache/lucene/index/TestPostingsOffsets.java =================================================================== --- lucene/core/src/test/org/apache/lucene/index/TestPostingsOffsets.java (revision 1503742) +++ lucene/core/src/test/org/apache/lucene/index/TestPostingsOffsets.java (working copy) @@ -301,7 +301,7 @@ final FieldCache.Ints docIDToID = FieldCache.DEFAULT.getInts(sub, "id", false); for(String term : terms) { //System.out.println(" term=" + term); - if (termsEnum.seekExact(new BytesRef(term), random().nextBoolean())) { + if (termsEnum.seekExact(new BytesRef(term))) { docs = termsEnum.docs(null, docs); assertNotNull(docs); int doc; Index: lucene/core/src/test/org/apache/lucene/index/TestStressIndexing2.java =================================================================== --- lucene/core/src/test/org/apache/lucene/index/TestStressIndexing2.java (revision 1503742) +++ lucene/core/src/test/org/apache/lucene/index/TestStressIndexing2.java (working copy) @@ -354,7 +354,7 @@ } termDocs1 = _TestUtil.docs(random(), termsEnum, liveDocs1, termDocs1, DocsEnum.FLAG_NONE); - if (termsEnum2.seekExact(term, false)) { + if (termsEnum2.seekExact(term)) { termDocs2 = _TestUtil.docs(random(), termsEnum2, liveDocs2, termDocs2, DocsEnum.FLAG_NONE); } else { termDocs2 = null; Index: lucene/core/src/test/org/apache/lucene/index/TestTermsEnum.java =================================================================== --- lucene/core/src/test/org/apache/lucene/index/TestTermsEnum.java (revision 1503742) +++ lucene/core/src/test/org/apache/lucene/index/TestTermsEnum.java (working copy) @@ -111,7 +111,7 @@ System.out.println("TEST: iter seekCeil target=" + target.utf8ToString() + " exists=" + exists); } // seekCeil - final TermsEnum.SeekStatus status = termsEnum.seekCeil(target, random().nextBoolean()); + final TermsEnum.SeekStatus status = termsEnum.seekCeil(target); if (VERBOSE) { System.out.println(" got " + status); } @@ -134,7 +134,7 @@ System.out.println("TEST: iter seekExact target=" + target.utf8ToString() + " exists=" + exists); } // seekExact - final boolean result = termsEnum.seekExact(target, false); + final boolean result = termsEnum.seekExact(target); if (VERBOSE) { System.out.println(" got " + result); } @@ -571,7 +571,7 @@ // sugar private boolean seekExact(TermsEnum te, String term) throws IOException { - return te.seekExact(new BytesRef(term), random().nextBoolean()); + return te.seekExact(new BytesRef(term)); } // sugar @@ -666,13 +666,13 @@ if (VERBOSE) { System.out.println(" seekExact"); } - assertEquals(loc >= 0, te.seekExact(t, random().nextBoolean())); + assertEquals(loc >= 0, te.seekExact(t)); } else { if (VERBOSE) { System.out.println(" seekCeil"); } - final TermsEnum.SeekStatus result = te.seekCeil(t, random().nextBoolean()); + final TermsEnum.SeekStatus result = te.seekCeil(t); if (VERBOSE) { System.out.println(" got " + result); } Index: lucene/core/src/test/org/apache/lucene/index/TestPayloadsOnVectors.java =================================================================== --- lucene/core/src/test/org/apache/lucene/index/TestPayloadsOnVectors.java (revision 1503742) +++ lucene/core/src/test/org/apache/lucene/index/TestPayloadsOnVectors.java (working copy) @@ -70,7 +70,7 @@ Terms terms = reader.getTermVector(1, "field"); assert terms != null; TermsEnum termsEnum = terms.iterator(null); - assertTrue(termsEnum.seekExact(new BytesRef("withPayload"), true)); + assertTrue(termsEnum.seekExact(new BytesRef("withPayload"))); DocsAndPositionsEnum de = termsEnum.docsAndPositions(null, null); assertEquals(0, de.nextDoc()); assertEquals(0, de.nextPosition()); @@ -112,7 +112,7 @@ Terms terms = reader.getTermVector(0, "field"); assert terms != null; TermsEnum termsEnum = terms.iterator(null); - assertTrue(termsEnum.seekExact(new BytesRef("withPayload"), true)); + assertTrue(termsEnum.seekExact(new BytesRef("withPayload"))); DocsAndPositionsEnum de = termsEnum.docsAndPositions(null, null); assertEquals(0, de.nextDoc()); assertEquals(3, de.nextPosition()); Index: lucene/core/src/test/org/apache/lucene/index/TestTermsEnum2.java =================================================================== --- lucene/core/src/test/org/apache/lucene/index/TestTermsEnum2.java (revision 1503742) +++ lucene/core/src/test/org/apache/lucene/index/TestTermsEnum2.java (working copy) @@ -117,10 +117,10 @@ // term is accepted if (random().nextBoolean()) { // seek exact - assertTrue(te.seekExact(term, random().nextBoolean())); + assertTrue(te.seekExact(term)); } else { // seek ceil - assertEquals(SeekStatus.FOUND, te.seekCeil(term, random().nextBoolean())); + assertEquals(SeekStatus.FOUND, te.seekCeil(term)); assertEquals(term, te.term()); } } @@ -138,10 +138,10 @@ if (c == 0) { assertEquals(term, te.next()); } else if (c == 1) { - assertEquals(SeekStatus.FOUND, te.seekCeil(term, random().nextBoolean())); + assertEquals(SeekStatus.FOUND, te.seekCeil(term)); assertEquals(term, te.term()); } else { - assertTrue(te.seekExact(term, random().nextBoolean())); + assertTrue(te.seekExact(term)); } } } Index: lucene/core/src/test/org/apache/lucene/util/fst/TestFSTs.java =================================================================== --- lucene/core/src/test/org/apache/lucene/util/fst/TestFSTs.java (revision 1503742) +++ lucene/core/src/test/org/apache/lucene/util/fst/TestFSTs.java (working copy) @@ -932,20 +932,15 @@ } } - final boolean useCache = random().nextBoolean(); - if (VERBOSE) { - System.out.println(" useCache=" + useCache); - } - final TermsEnum.SeekStatus status; if (nextID == null) { - if (termsEnum.seekExact(new BytesRef(id), useCache)) { + if (termsEnum.seekExact(new BytesRef(id))) { status = TermsEnum.SeekStatus.FOUND; } else { status = TermsEnum.SeekStatus.NOT_FOUND; } } else { - status = termsEnum.seekCeil(new BytesRef(id), useCache); + status = termsEnum.seekCeil(new BytesRef(id)); } if (nextID != null) { Index: lucene/core/src/java/org/apache/lucene/codecs/compressing/CompressingTermVectorsReader.java =================================================================== --- lucene/core/src/java/org/apache/lucene/codecs/compressing/CompressingTermVectorsReader.java (revision 1503742) +++ lucene/core/src/java/org/apache/lucene/codecs/compressing/CompressingTermVectorsReader.java (working copy) @@ -824,7 +824,7 @@ } @Override - public SeekStatus seekCeil(BytesRef text, boolean useCache) + public SeekStatus seekCeil(BytesRef text) throws IOException { if (ord < numTerms && ord >= 0) { final int cmp = term().compareTo(text); Index: lucene/core/src/java/org/apache/lucene/codecs/lucene40/Lucene40TermVectorsReader.java =================================================================== --- lucene/core/src/java/org/apache/lucene/codecs/lucene40/Lucene40TermVectorsReader.java (revision 1503742) +++ lucene/core/src/java/org/apache/lucene/codecs/lucene40/Lucene40TermVectorsReader.java (working copy) @@ -433,7 +433,7 @@ // NOTE: slow! (linear scan) @Override - public SeekStatus seekCeil(BytesRef text, boolean useCache) + public SeekStatus seekCeil(BytesRef text) throws IOException { if (nextTerm != 0) { final int cmp = text.compareTo(term); Index: lucene/core/src/java/org/apache/lucene/codecs/lucene42/Lucene42DocValuesProducer.java =================================================================== --- lucene/core/src/java/org/apache/lucene/codecs/lucene42/Lucene42DocValuesProducer.java (revision 1503742) +++ lucene/core/src/java/org/apache/lucene/codecs/lucene42/Lucene42DocValuesProducer.java (working copy) @@ -490,7 +490,7 @@ } @Override - public SeekStatus seekCeil(BytesRef text, boolean useCache) throws IOException { + public SeekStatus seekCeil(BytesRef text) throws IOException { if (in.seekCeil(text) == null) { return SeekStatus.END; } else if (term().equals(text)) { @@ -503,7 +503,7 @@ } @Override - public boolean seekExact(BytesRef text, boolean useCache) throws IOException { + public boolean seekExact(BytesRef text) throws IOException { if (in.seekExact(text) == null) { return false; } else { Index: lucene/core/src/java/org/apache/lucene/codecs/BlockTreeTermsReader.java =================================================================== --- lucene/core/src/java/org/apache/lucene/codecs/BlockTreeTermsReader.java (revision 1503742) +++ lucene/core/src/java/org/apache/lucene/codecs/BlockTreeTermsReader.java (working copy) @@ -1222,7 +1222,7 @@ } @Override - public boolean seekExact(BytesRef text, boolean useCache) { + public boolean seekExact(BytesRef text) { throw new UnsupportedOperationException(); } @@ -1237,7 +1237,7 @@ } @Override - public SeekStatus seekCeil(BytesRef text, boolean useCache) { + public SeekStatus seekCeil(BytesRef text) { throw new UnsupportedOperationException(); } } @@ -1499,7 +1499,7 @@ } @Override - public boolean seekExact(final BytesRef target, final boolean useCache) throws IOException { + public boolean seekExact(final BytesRef target) throws IOException { if (index == null) { throw new IllegalStateException("terms index was not loaded"); @@ -1760,7 +1760,7 @@ } @Override - public SeekStatus seekCeil(final BytesRef target, final boolean useCache) throws IOException { + public SeekStatus seekCeil(final BytesRef target) throws IOException { if (index == null) { throw new IllegalStateException("terms index was not loaded"); } @@ -2096,7 +2096,7 @@ // this method catches up all internal state so next() // works properly: //if (DEBUG) System.out.println(" re-seek to pending term=" + term.utf8ToString() + " " + term); - final boolean result = seekExact(term, false); + final boolean result = seekExact(term); assert result; } Index: lucene/core/src/java/org/apache/lucene/search/payloads/PayloadSpanUtil.java =================================================================== --- lucene/core/src/java/org/apache/lucene/search/payloads/PayloadSpanUtil.java (revision 1503742) +++ lucene/core/src/java/org/apache/lucene/search/payloads/PayloadSpanUtil.java (working copy) @@ -182,7 +182,7 @@ TreeSet terms = new TreeSet(); query.extractTerms(terms); for (Term term : terms) { - termContexts.put(term, TermContext.build(context, term, true)); + termContexts.put(term, TermContext.build(context, term)); } for (AtomicReaderContext atomicReaderContext : context.leaves()) { final Spans spans = query.getSpans(atomicReaderContext, atomicReaderContext.reader().getLiveDocs(), termContexts); Index: lucene/core/src/java/org/apache/lucene/search/TermQuery.java =================================================================== --- lucene/core/src/java/org/apache/lucene/search/TermQuery.java (revision 1503742) +++ lucene/core/src/java/org/apache/lucene/search/TermQuery.java (working copy) @@ -163,7 +163,7 @@ final TermContext termState; if (perReaderTermState == null || perReaderTermState.topReaderContext != context) { // make TermQuery single-pass if we don't have a PRTS or if the context differs! - termState = TermContext.build(context, term, true); // cache term lookups! + termState = TermContext.build(context, term); } else { // PRTS was pre-build for this IS termState = this.perReaderTermState; Index: lucene/core/src/java/org/apache/lucene/search/spans/SpanWeight.java =================================================================== --- lucene/core/src/java/org/apache/lucene/search/spans/SpanWeight.java (revision 1503742) +++ lucene/core/src/java/org/apache/lucene/search/spans/SpanWeight.java (working copy) @@ -52,7 +52,7 @@ final TermStatistics termStats[] = new TermStatistics[terms.size()]; int i = 0; for (Term term : terms) { - TermContext state = TermContext.build(context, term, true); + TermContext state = TermContext.build(context, term); termStats[i] = searcher.termStatistics(term, state); termContexts.put(term, state); i++; Index: lucene/core/src/java/org/apache/lucene/search/spans/SpanTermQuery.java =================================================================== --- lucene/core/src/java/org/apache/lucene/search/spans/SpanTermQuery.java (revision 1503742) +++ lucene/core/src/java/org/apache/lucene/search/spans/SpanTermQuery.java (working copy) @@ -98,7 +98,7 @@ final Terms terms = fields.terms(term.field()); if (terms != null) { final TermsEnum termsEnum = terms.iterator(null); - if (termsEnum.seekExact(term.bytes(), true)) { + if (termsEnum.seekExact(term.bytes())) { state = termsEnum.termState(); } else { state = null; Index: lucene/core/src/java/org/apache/lucene/search/MultiPhraseQuery.java =================================================================== --- lucene/core/src/java/org/apache/lucene/search/MultiPhraseQuery.java (revision 1503742) +++ lucene/core/src/java/org/apache/lucene/search/MultiPhraseQuery.java (working copy) @@ -149,7 +149,7 @@ for (Term term: terms) { TermContext termContext = termContexts.get(term); if (termContext == null) { - termContext = TermContext.build(context, term, true); + termContext = TermContext.build(context, term); termContexts.put(term, termContext); } allTermStats.add(searcher.termStatistics(term, termContext)); Index: lucene/core/src/java/org/apache/lucene/search/FuzzyTermsEnum.java =================================================================== --- lucene/core/src/java/org/apache/lucene/search/FuzzyTermsEnum.java (revision 1503742) +++ lucene/core/src/java/org/apache/lucene/search/FuzzyTermsEnum.java (working copy) @@ -303,13 +303,13 @@ } @Override - public boolean seekExact(BytesRef text, boolean useCache) throws IOException { - return actualEnum.seekExact(text, useCache); + public boolean seekExact(BytesRef text) throws IOException { + return actualEnum.seekExact(text); } @Override - public SeekStatus seekCeil(BytesRef text, boolean useCache) throws IOException { - return actualEnum.seekCeil(text, useCache); + public SeekStatus seekCeil(BytesRef text) throws IOException { + return actualEnum.seekCeil(text); } @Override Index: lucene/core/src/java/org/apache/lucene/search/PhraseQuery.java =================================================================== --- lucene/core/src/java/org/apache/lucene/search/PhraseQuery.java (revision 1503742) +++ lucene/core/src/java/org/apache/lucene/search/PhraseQuery.java (working copy) @@ -218,7 +218,7 @@ TermStatistics termStats[] = new TermStatistics[terms.size()]; for (int i = 0; i < terms.size(); i++) { final Term term = terms.get(i); - states[i] = TermContext.build(context, term, true); + states[i] = TermContext.build(context, term); termStats[i] = searcher.termStatistics(term, states[i]); } stats = similarity.computeWeight(getBoost(), searcher.collectionStatistics(field), termStats); @@ -269,7 +269,7 @@ // PhraseQuery on a field that did not index // positions. if (postingsEnum == null) { - assert te.seekExact(t.bytes(), false) : "termstate found but no term exists in reader"; + assert te.seekExact(t.bytes()) : "termstate found but no term exists in reader"; // term does exist, but has no positions throw new IllegalStateException("field \"" + t.field() + "\" was indexed without position data; cannot run PhraseQuery (term=" + t.text() + ")"); } Index: lucene/core/src/java/org/apache/lucene/index/DocTermOrds.java =================================================================== --- lucene/core/src/java/org/apache/lucene/index/DocTermOrds.java (revision 1503742) +++ lucene/core/src/java/org/apache/lucene/index/DocTermOrds.java (working copy) @@ -659,7 +659,7 @@ } @Override - public SeekStatus seekCeil(BytesRef target, boolean useCache) throws IOException { + public SeekStatus seekCeil(BytesRef target) throws IOException { // already here if (term != null && term.equals(target)) { @@ -729,7 +729,7 @@ //System.out.println(" do seek term=" + base.utf8ToString()); ord = idx << indexIntervalBits; delta = (int) (targetOrd - ord); - final TermsEnum.SeekStatus seekStatus = termsEnum.seekCeil(base, true); + final TermsEnum.SeekStatus seekStatus = termsEnum.seekCeil(base); assert seekStatus == TermsEnum.SeekStatus.FOUND; } else { //System.out.println("seek w/in block"); Index: lucene/core/src/java/org/apache/lucene/index/MultiTermsEnum.java =================================================================== --- lucene/core/src/java/org/apache/lucene/index/MultiTermsEnum.java (revision 1503742) +++ lucene/core/src/java/org/apache/lucene/index/MultiTermsEnum.java (working copy) @@ -144,7 +144,7 @@ } @Override - public boolean seekExact(BytesRef term, boolean useCache) throws IOException { + public boolean seekExact(BytesRef term) throws IOException { queue.clear(); numTop = 0; @@ -173,13 +173,13 @@ } else if (cmp < 0) { status = false; } else { - status = currentSubs[i].terms.seekExact(term, useCache); + status = currentSubs[i].terms.seekExact(term); } } else { status = false; } } else { - status = currentSubs[i].terms.seekExact(term, useCache); + status = currentSubs[i].terms.seekExact(term); } if (status) { @@ -195,7 +195,7 @@ } @Override - public SeekStatus seekCeil(BytesRef term, boolean useCache) throws IOException { + public SeekStatus seekCeil(BytesRef term) throws IOException { queue.clear(); numTop = 0; lastSeekExact = false; @@ -225,13 +225,13 @@ } else if (cmp < 0) { status = SeekStatus.NOT_FOUND; } else { - status = currentSubs[i].terms.seekCeil(term, useCache); + status = currentSubs[i].terms.seekCeil(term); } } else { status = SeekStatus.END; } } else { - status = currentSubs[i].terms.seekCeil(term, useCache); + status = currentSubs[i].terms.seekCeil(term); } if (status == SeekStatus.FOUND) { Index: lucene/core/src/java/org/apache/lucene/index/TermContext.java =================================================================== --- lucene/core/src/java/org/apache/lucene/index/TermContext.java (revision 1503742) +++ lucene/core/src/java/org/apache/lucene/index/TermContext.java (working copy) @@ -78,7 +78,7 @@ *

* Note: the given context must be a top-level context. */ - public static TermContext build(IndexReaderContext context, Term term, boolean cache) + public static TermContext build(IndexReaderContext context, Term term) throws IOException { assert context != null && context.isTopLevel; final String field = term.field(); @@ -92,7 +92,7 @@ final Terms terms = fields.terms(field); if (terms != null) { final TermsEnum termsEnum = terms.iterator(null); - if (termsEnum.seekExact(bytes, cache)) { + if (termsEnum.seekExact(bytes)) { final TermState termState = termsEnum.termState(); //if (DEBUG) System.out.println(" found"); perReaderTermState.register(termState, ctx.ord, termsEnum.docFreq(), termsEnum.totalTermFreq()); Index: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java =================================================================== --- lucene/core/src/java/org/apache/lucene/index/CheckIndex.java (revision 1503742) +++ lucene/core/src/java/org/apache/lucene/index/CheckIndex.java (working copy) @@ -1117,7 +1117,7 @@ long totDocCountNoDeletes = 0; long totDocFreq = 0; for(int i=0;i= 0) { currentOrd = ord; @@ -61,7 +61,7 @@ } @Override - public boolean seekExact(BytesRef text, boolean useCache) throws IOException { + public boolean seekExact(BytesRef text) throws IOException { long ord = values.lookupTerm(text); if (ord >= 0) { term.offset = 0; Index: lucene/core/src/java/org/apache/lucene/index/SortedDocValuesTermsEnum.java =================================================================== --- lucene/core/src/java/org/apache/lucene/index/SortedDocValuesTermsEnum.java (revision 1503742) +++ lucene/core/src/java/org/apache/lucene/index/SortedDocValuesTermsEnum.java (working copy) @@ -37,7 +37,7 @@ } @Override - public SeekStatus seekCeil(BytesRef text, boolean useCache /* ignored */) throws IOException { + public SeekStatus seekCeil(BytesRef text) throws IOException { int ord = values.lookupTerm(text); if (ord >= 0) { currentOrd = ord; @@ -61,7 +61,7 @@ } @Override - public boolean seekExact(BytesRef text, boolean useCache) throws IOException { + public boolean seekExact(BytesRef text) throws IOException { int ord = values.lookupTerm(text); if (ord >= 0) { term.offset = 0; Index: lucene/join/src/test/org/apache/lucene/search/join/TestJoinUtil.java =================================================================== --- lucene/join/src/test/org/apache/lucene/search/join/TestJoinUtil.java (revision 1503742) +++ lucene/join/src/test/org/apache/lucene/search/join/TestJoinUtil.java (working copy) @@ -557,7 +557,7 @@ joinValues.addAll(joinValueToJoinScores.keySet()); for (BytesRef joinValue : joinValues) { termsEnum = terms.iterator(termsEnum); - if (termsEnum.seekExact(joinValue, true)) { + if (termsEnum.seekExact(joinValue)) { docsEnum = termsEnum.docs(slowCompositeReader.getLiveDocs(), docsEnum, DocsEnum.FLAG_NONE); JoinScore joinScore = joinValueToJoinScores.get(joinValue); Index: lucene/join/src/java/org/apache/lucene/search/join/TermsIncludingScoreQuery.java =================================================================== --- lucene/join/src/java/org/apache/lucene/search/join/TermsIncludingScoreQuery.java (revision 1503742) +++ lucene/join/src/java/org/apache/lucene/search/join/TermsIncludingScoreQuery.java (working copy) @@ -241,7 +241,7 @@ } scoreUpto = upto; - if (termsEnum.seekExact(terms.get(ords[upto++], spare), true)) { + if (termsEnum.seekExact(terms.get(ords[upto++], spare))) { docsEnum = reuse = termsEnum.docs(acceptDocs, reuse, DocsEnum.FLAG_NONE); } } @@ -337,7 +337,7 @@ BytesRef spare = new BytesRef(); DocsEnum docsEnum = null; for (int i = 0; i < terms.size(); i++) { - if (termsEnum.seekExact(terms.get(ords[i], spare), true)) { + if (termsEnum.seekExact(terms.get(ords[i], spare))) { docsEnum = termsEnum.docs(acceptDocs, docsEnum, DocsEnum.FLAG_NONE); float score = TermsIncludingScoreQuery.this.scores[ords[i]]; for (int doc = docsEnum.nextDoc(); doc != DocIdSetIterator.NO_MORE_DOCS; doc = docsEnum.nextDoc()) { @@ -393,7 +393,7 @@ BytesRef spare = new BytesRef(); DocsEnum docsEnum = null; for (int i = 0; i < terms.size(); i++) { - if (termsEnum.seekExact(terms.get(ords[i], spare), true)) { + if (termsEnum.seekExact(terms.get(ords[i], spare))) { docsEnum = termsEnum.docs(acceptDocs, docsEnum, DocsEnum.FLAG_NONE); float score = TermsIncludingScoreQuery.this.scores[ords[i]]; for (int doc = docsEnum.nextDoc(); doc != DocIdSetIterator.NO_MORE_DOCS; doc = docsEnum.nextDoc()) { Index: lucene/memory/src/test/org/apache/lucene/index/memory/MemoryIndexTest.java =================================================================== --- lucene/memory/src/test/org/apache/lucene/index/memory/MemoryIndexTest.java (revision 1503742) +++ lucene/memory/src/test/org/apache/lucene/index/memory/MemoryIndexTest.java (working copy) @@ -327,7 +327,7 @@ // now reuse and check again TermsEnum te = reader.terms("foo").iterator(null); - assertTrue(te.seekExact(new BytesRef("bar"), true)); + assertTrue(te.seekExact(new BytesRef("bar"))); disi = te.docs(null, disi, DocsEnum.FLAG_NONE); docid = disi.docID(); assertEquals(-1, docid); @@ -361,7 +361,7 @@ // now reuse and check again TermsEnum te = reader.terms("foo").iterator(null); - assertTrue(te.seekExact(new BytesRef("bar"), true)); + assertTrue(te.seekExact(new BytesRef("bar"))); disi = te.docsAndPositions(null, disi); docid = disi.docID(); assertEquals(-1, docid); Index: lucene/memory/src/java/org/apache/lucene/index/memory/MemoryIndex.java =================================================================== --- lucene/memory/src/java/org/apache/lucene/index/memory/MemoryIndex.java (revision 1503742) +++ lucene/memory/src/java/org/apache/lucene/index/memory/MemoryIndex.java (working copy) @@ -885,13 +885,13 @@ @Override - public boolean seekExact(BytesRef text, boolean useCache) { + public boolean seekExact(BytesRef text) { termUpto = binarySearch(text, br, 0, info.terms.size()-1, info.terms, info.sortedTerms, BytesRef.getUTF8SortedAsUnicodeComparator()); return termUpto >= 0; } @Override - public SeekStatus seekCeil(BytesRef text, boolean useCache) { + public SeekStatus seekCeil(BytesRef text) { termUpto = binarySearch(text, br, 0, info.terms.size()-1, info.terms, info.sortedTerms, BytesRef.getUTF8SortedAsUnicodeComparator()); if (termUpto < 0) { // not found; choose successor termUpto = -termUpto-1; Index: lucene/grouping/src/java/org/apache/lucene/search/grouping/term/TermGroupFacetCollector.java =================================================================== --- lucene/grouping/src/java/org/apache/lucene/search/grouping/term/TermGroupFacetCollector.java (revision 1503742) +++ lucene/grouping/src/java/org/apache/lucene/search/grouping/term/TermGroupFacetCollector.java (working copy) @@ -303,7 +303,7 @@ int facetOrd; if (groupedFacetHit.facetValue != null) { - if (facetOrdTermsEnum == null || !facetOrdTermsEnum.seekExact(groupedFacetHit.facetValue, true)) { + if (facetOrdTermsEnum == null || !facetOrdTermsEnum.seekExact(groupedFacetHit.facetValue)) { continue; } facetOrd = (int) facetOrdTermsEnum.ord(); @@ -319,7 +319,7 @@ if (facetPrefix != null) { TermsEnum.SeekStatus seekStatus; if (facetOrdTermsEnum != null) { - seekStatus = facetOrdTermsEnum.seekCeil(facetPrefix, true); + seekStatus = facetOrdTermsEnum.seekCeil(facetPrefix); } else { seekStatus = TermsEnum.SeekStatus.END; } @@ -334,7 +334,7 @@ BytesRef facetEndPrefix = BytesRef.deepCopyOf(facetPrefix); facetEndPrefix.append(UnicodeUtil.BIG_TERM); - seekStatus = facetOrdTermsEnum.seekCeil(facetEndPrefix, true); + seekStatus = facetOrdTermsEnum.seekCeil(facetEndPrefix); if (seekStatus != TermsEnum.SeekStatus.END) { endFacetOrd = (int) facetOrdTermsEnum.ord(); } else { Index: lucene/test-framework/src/java/org/apache/lucene/codecs/mockrandom/MockRandomPostingsFormat.java =================================================================== --- lucene/test-framework/src/java/org/apache/lucene/codecs/mockrandom/MockRandomPostingsFormat.java (revision 1503742) +++ lucene/test-framework/src/java/org/apache/lucene/codecs/mockrandom/MockRandomPostingsFormat.java (working copy) @@ -400,8 +400,6 @@ } } - final int termsCacheSize = _TestUtil.nextInt(random, 1, 1024); - success = false; try { fields = new BlockTermsReader(indexReader, @@ -410,7 +408,6 @@ state.segmentInfo, postingsReader, state.context, - termsCacheSize, state.segmentSuffix); success = true; } finally { Index: lucene/test-framework/src/java/org/apache/lucene/codecs/mocksep/MockSepPostingsFormat.java =================================================================== --- lucene/test-framework/src/java/org/apache/lucene/codecs/mocksep/MockSepPostingsFormat.java (revision 1503742) +++ lucene/test-framework/src/java/org/apache/lucene/codecs/mocksep/MockSepPostingsFormat.java (working copy) @@ -110,7 +110,6 @@ state.segmentInfo, postingsReader, state.context, - 1024, state.segmentSuffix); success = true; return ret; Index: lucene/test-framework/src/java/org/apache/lucene/codecs/lucene41ords/Lucene41WithOrds.java =================================================================== --- lucene/test-framework/src/java/org/apache/lucene/codecs/lucene41ords/Lucene41WithOrds.java (revision 1503742) +++ lucene/test-framework/src/java/org/apache/lucene/codecs/lucene41ords/Lucene41WithOrds.java (working copy) @@ -87,8 +87,6 @@ } } - public final static int TERMS_CACHE_SIZE = 1024; - @Override public FieldsProducer fieldsProducer(SegmentReadState state) throws IOException { PostingsReaderBase postings = new Lucene41PostingsReader(state.directory, state.fieldInfos, state.segmentInfo, state.context, state.segmentSuffix); @@ -117,7 +115,6 @@ state.segmentInfo, postings, state.context, - TERMS_CACHE_SIZE, state.segmentSuffix); success = true; return ret; Index: lucene/test-framework/src/java/org/apache/lucene/codecs/mockintblock/MockFixedIntBlockPostingsFormat.java =================================================================== --- lucene/test-framework/src/java/org/apache/lucene/codecs/mockintblock/MockFixedIntBlockPostingsFormat.java (revision 1503742) +++ lucene/test-framework/src/java/org/apache/lucene/codecs/mockintblock/MockFixedIntBlockPostingsFormat.java (working copy) @@ -187,7 +187,6 @@ state.segmentInfo, postingsReader, state.context, - 1024, state.segmentSuffix); success = true; return ret; Index: lucene/test-framework/src/java/org/apache/lucene/codecs/mockintblock/MockVariableIntBlockPostingsFormat.java =================================================================== --- lucene/test-framework/src/java/org/apache/lucene/codecs/mockintblock/MockVariableIntBlockPostingsFormat.java (revision 1503742) +++ lucene/test-framework/src/java/org/apache/lucene/codecs/mockintblock/MockVariableIntBlockPostingsFormat.java (working copy) @@ -212,7 +212,6 @@ state.segmentInfo, postingsReader, state.context, - 1024, state.segmentSuffix); success = true; return ret; Index: lucene/test-framework/src/java/org/apache/lucene/codecs/ramonly/RAMOnlyPostingsFormat.java =================================================================== --- lucene/test-framework/src/java/org/apache/lucene/codecs/ramonly/RAMOnlyPostingsFormat.java (revision 1503742) +++ lucene/test-framework/src/java/org/apache/lucene/codecs/ramonly/RAMOnlyPostingsFormat.java (working copy) @@ -336,7 +336,7 @@ } @Override - public SeekStatus seekCeil(BytesRef term, boolean useCache) { + public SeekStatus seekCeil(BytesRef term) { current = term.utf8ToString(); it = null; if (ramField.termToDocs.containsKey(current)) { Index: lucene/test-framework/src/java/org/apache/lucene/search/ShardSearchingTestBase.java =================================================================== --- lucene/test-framework/src/java/org/apache/lucene/search/ShardSearchingTestBase.java (revision 1503742) +++ lucene/test-framework/src/java/org/apache/lucene/search/ShardSearchingTestBase.java (working copy) @@ -185,7 +185,7 @@ } try { for(Term term : terms) { - final TermContext termContext = TermContext.build(s.getIndexReader().getContext(), term, false); + final TermContext termContext = TermContext.build(s.getIndexReader().getContext(), term); stats.put(term, s.termStatistics(term, termContext)); } } finally { Index: lucene/test-framework/src/java/org/apache/lucene/index/BasePostingsFormatTestCase.java =================================================================== --- lucene/test-framework/src/java/org/apache/lucene/index/BasePostingsFormatTestCase.java (revision 1503742) +++ lucene/test-framework/src/java/org/apache/lucene/index/BasePostingsFormatTestCase.java (working copy) @@ -983,7 +983,7 @@ termsEnum = terms.iterator(null); if (!useTermState) { - assertTrue(termsEnum.seekExact(fieldAndTerm.term, true)); + assertTrue(termsEnum.seekExact(fieldAndTerm.term)); } else { termsEnum.seekExact(fieldAndTerm.term, termState); } Index: lucene/test-framework/src/java/org/apache/lucene/index/BaseTermVectorsFormatTestCase.java =================================================================== --- lucene/test-framework/src/java/org/apache/lucene/index/BaseTermVectorsFormatTestCase.java (revision 1503742) +++ lucene/test-framework/src/java/org/apache/lucene/index/BaseTermVectorsFormatTestCase.java (working copy) @@ -500,9 +500,9 @@ assertNull(termsEnum.next()); for (int i = 0; i < 5; ++i) { if (random().nextBoolean()) { - assertTrue(termsEnum.seekExact(RandomPicks.randomFrom(random(), tk.termBytes), random().nextBoolean())); + assertTrue(termsEnum.seekExact(RandomPicks.randomFrom(random(), tk.termBytes))); } else { - assertEquals(SeekStatus.FOUND, termsEnum.seekCeil(RandomPicks.randomFrom(random(), tk.termBytes), random().nextBoolean())); + assertEquals(SeekStatus.FOUND, termsEnum.seekCeil(RandomPicks.randomFrom(random(), tk.termBytes))); } } } Index: lucene/test-framework/src/java/org/apache/lucene/index/AssertingAtomicReader.java =================================================================== --- lucene/test-framework/src/java/org/apache/lucene/index/AssertingAtomicReader.java (revision 1503742) +++ lucene/test-framework/src/java/org/apache/lucene/index/AssertingAtomicReader.java (working copy) @@ -185,9 +185,9 @@ } @Override - public SeekStatus seekCeil(BytesRef term, boolean useCache) throws IOException { + public SeekStatus seekCeil(BytesRef term) throws IOException { assert term.isValid(); - SeekStatus result = super.seekCeil(term, useCache); + SeekStatus result = super.seekCeil(term); if (result == SeekStatus.END) { state = State.UNPOSITIONED; } else { @@ -197,9 +197,9 @@ } @Override - public boolean seekExact(BytesRef text, boolean useCache) throws IOException { + public boolean seekExact(BytesRef text) throws IOException { assert text.isValid(); - if (super.seekExact(text, useCache)) { + if (super.seekExact(text)) { state = State.POSITIONED; return true; } else { Index: lucene/test-framework/src/java/org/apache/lucene/index/BaseDocValuesFormatTestCase.java =================================================================== --- lucene/test-framework/src/java/org/apache/lucene/index/BaseDocValuesFormatTestCase.java (revision 1503742) +++ lucene/test-framework/src/java/org/apache/lucene/index/BaseDocValuesFormatTestCase.java (working copy) @@ -746,16 +746,16 @@ assertEquals(SeekStatus.END, termsEnum.seekCeil(new BytesRef("zzz"))); // seekExact() - assertTrue(termsEnum.seekExact(new BytesRef("beer"), true)); + assertTrue(termsEnum.seekExact(new BytesRef("beer"))); assertEquals("beer", termsEnum.term().utf8ToString()); assertEquals(0, termsEnum.ord()); - assertTrue(termsEnum.seekExact(new BytesRef("hello"), true)); + assertTrue(termsEnum.seekExact(new BytesRef("hello"))); assertEquals(Codec.getDefault().toString(), "hello", termsEnum.term().utf8ToString()); assertEquals(1, termsEnum.ord()); - assertTrue(termsEnum.seekExact(new BytesRef("world"), true)); + assertTrue(termsEnum.seekExact(new BytesRef("world"))); assertEquals("world", termsEnum.term().utf8ToString()); assertEquals(2, termsEnum.ord()); - assertFalse(termsEnum.seekExact(new BytesRef("bogus"), true)); + assertFalse(termsEnum.seekExact(new BytesRef("bogus"))); // seek(ord) termsEnum.seekExact(0); @@ -1788,16 +1788,16 @@ assertEquals(SeekStatus.END, termsEnum.seekCeil(new BytesRef("zzz"))); // seekExact() - assertTrue(termsEnum.seekExact(new BytesRef("beer"), true)); + assertTrue(termsEnum.seekExact(new BytesRef("beer"))); assertEquals("beer", termsEnum.term().utf8ToString()); assertEquals(0, termsEnum.ord()); - assertTrue(termsEnum.seekExact(new BytesRef("hello"), true)); + assertTrue(termsEnum.seekExact(new BytesRef("hello"))); assertEquals("hello", termsEnum.term().utf8ToString()); assertEquals(1, termsEnum.ord()); - assertTrue(termsEnum.seekExact(new BytesRef("world"), true)); + assertTrue(termsEnum.seekExact(new BytesRef("world"))); assertEquals("world", termsEnum.term().utf8ToString()); assertEquals(2, termsEnum.ord()); - assertFalse(termsEnum.seekExact(new BytesRef("bogus"), true)); + assertFalse(termsEnum.seekExact(new BytesRef("bogus"))); // seek(ord) termsEnum.seekExact(0); Index: lucene/test-framework/src/java/org/apache/lucene/util/LuceneTestCase.java =================================================================== --- lucene/test-framework/src/java/org/apache/lucene/util/LuceneTestCase.java (revision 1503742) +++ lucene/test-framework/src/java/org/apache/lucene/util/LuceneTestCase.java (working copy) @@ -1751,14 +1751,13 @@ rightEnum = rightTerms.iterator(rightEnum); } - final boolean useCache = random().nextBoolean(); final boolean seekExact = random().nextBoolean(); if (seekExact) { - assertEquals(info, leftEnum.seekExact(b, useCache), rightEnum.seekExact(b, useCache)); + assertEquals(info, leftEnum.seekExact(b), rightEnum.seekExact(b)); } else { - SeekStatus leftStatus = leftEnum.seekCeil(b, useCache); - SeekStatus rightStatus = rightEnum.seekCeil(b, useCache); + SeekStatus leftStatus = leftEnum.seekCeil(b); + SeekStatus rightStatus = rightEnum.seekCeil(b); assertEquals(info, leftStatus, rightStatus); if (leftStatus != SeekStatus.END) { assertEquals(info, leftEnum.term(), rightEnum.term()); Index: lucene/test-framework/src/java/org/apache/lucene/util/_TestUtil.java =================================================================== --- lucene/test-framework/src/java/org/apache/lucene/util/_TestUtil.java (revision 1503742) +++ lucene/test-framework/src/java/org/apache/lucene/util/_TestUtil.java (working copy) @@ -928,7 +928,7 @@ return null; } final TermsEnum termsEnum = terms.iterator(null); - if (!termsEnum.seekExact(term, random.nextBoolean())) { + if (!termsEnum.seekExact(term)) { return null; } return docs(random, termsEnum, liveDocs, reuse, flags); Index: lucene/highlighter/src/java/org/apache/lucene/search/postingshighlight/PostingsHighlighter.java =================================================================== --- lucene/highlighter/src/java/org/apache/lucene/search/postingshighlight/PostingsHighlighter.java (revision 1503742) +++ lucene/highlighter/src/java/org/apache/lucene/search/postingshighlight/PostingsHighlighter.java (working copy) @@ -459,7 +459,7 @@ continue; } else if (de == null) { postings[i] = EMPTY; // initially - if (!termsEnum.seekExact(terms[i], true)) { + if (!termsEnum.seekExact(terms[i])) { continue; // term not found } de = postings[i] = termsEnum.docsAndPositions(null, null, DocsAndPositionsEnum.FLAG_OFFSETS); Index: lucene/highlighter/src/java/org/apache/lucene/search/highlight/WeightedSpanTermExtractor.java =================================================================== --- lucene/highlighter/src/java/org/apache/lucene/search/highlight/WeightedSpanTermExtractor.java (revision 1503742) +++ lucene/highlighter/src/java/org/apache/lucene/search/highlight/WeightedSpanTermExtractor.java (working copy) @@ -282,7 +282,7 @@ TreeSet extractedTerms = new TreeSet(); q.extractTerms(extractedTerms); for (Term term : extractedTerms) { - termContexts.put(term, TermContext.build(context, term, true)); + termContexts.put(term, TermContext.build(context, term)); } Bits acceptDocs = context.reader().getLiveDocs(); final Spans spans = q.getSpans(context, acceptDocs, termContexts); Index: lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/JoinDocFreqValueSource.java =================================================================== --- lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/JoinDocFreqValueSource.java (revision 1503742) +++ lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/JoinDocFreqValueSource.java (working copy) @@ -69,7 +69,7 @@ { try { terms.get(doc, ref); - if (termsEnum.seekExact(ref, true)) { + if (termsEnum.seekExact(ref)) { return termsEnum.docFreq(); } else { return 0; Index: lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/TFValueSource.java =================================================================== --- lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/TFValueSource.java (revision 1503742) +++ lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/TFValueSource.java (working copy) @@ -67,7 +67,7 @@ if (terms != null) { final TermsEnum termsEnum = terms.iterator(null); - if (termsEnum.seekExact(indexedBytes, false)) { + if (termsEnum.seekExact(indexedBytes)) { docs = termsEnum.docs(null, null); } else { docs = null; Index: lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/TermFreqValueSource.java =================================================================== --- lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/TermFreqValueSource.java (revision 1503742) +++ lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/TermFreqValueSource.java (working copy) @@ -60,7 +60,7 @@ if (terms != null) { final TermsEnum termsEnum = terms.iterator(null); - if (termsEnum.seekExact(indexedBytes, false)) { + if (termsEnum.seekExact(indexedBytes)) { docs = termsEnum.docs(null, null); } else { docs = null; Index: lucene/queries/src/java/org/apache/lucene/queries/CommonTermsQuery.java =================================================================== --- lucene/queries/src/java/org/apache/lucene/queries/CommonTermsQuery.java (revision 1503742) +++ lucene/queries/src/java/org/apache/lucene/queries/CommonTermsQuery.java (working copy) @@ -246,7 +246,7 @@ assert termsEnum != null; if (termsEnum == TermsEnum.EMPTY) continue; - if (termsEnum.seekExact(term.bytes(), false)) { + if (termsEnum.seekExact(term.bytes())) { if (termContext == null) { contextArray[i] = new TermContext(reader.getContext(), termsEnum.termState(), context.ord, termsEnum.docFreq(), Index: lucene/queries/src/java/org/apache/lucene/queries/TermsFilter.java =================================================================== --- lucene/queries/src/java/org/apache/lucene/queries/TermsFilter.java (revision 1503742) +++ lucene/queries/src/java/org/apache/lucene/queries/TermsFilter.java (working copy) @@ -193,7 +193,7 @@ for (int i = termsAndField.start; i < termsAndField.end; i++) { spare.offset = offsets[i]; spare.length = offsets[i+1] - offsets[i]; - if (termsEnum.seekExact(spare, false)) { // don't use cache since we could pollute the cache here easily + if (termsEnum.seekExact(spare)) { docs = termsEnum.docs(acceptDocs, docs, DocsEnum.FLAG_NONE); // no freq since we don't need them if (result == null) { if (docs.nextDoc() != DocIdSetIterator.NO_MORE_DOCS) { Index: lucene/facet/src/java/org/apache/lucene/facet/util/FacetsPayloadMigrationReader.java =================================================================== --- lucene/facet/src/java/org/apache/lucene/facet/util/FacetsPayloadMigrationReader.java (revision 1503742) +++ lucene/facet/src/java/org/apache/lucene/facet/util/FacetsPayloadMigrationReader.java (working copy) @@ -90,7 +90,7 @@ Terms terms = fields.terms(term.field()); if (terms != null) { TermsEnum te = terms.iterator(null); // no use for reusing - if (te.seekExact(term.bytes(), true)) { + if (te.seekExact(term.bytes())) { // we're not expected to be called for deleted documents dpe = te.docsAndPositions(null, null, DocsAndPositionsEnum.FLAG_PAYLOADS); } Index: lucene/facet/src/java/org/apache/lucene/facet/search/DrillSidewaysQuery.java =================================================================== --- lucene/facet/src/java/org/apache/lucene/facet/search/DrillSidewaysQuery.java (revision 1503742) +++ lucene/facet/src/java/org/apache/lucene/facet/search/DrillSidewaysQuery.java (working copy) @@ -130,7 +130,7 @@ continue; } for(int i=0;i 0) { // leap frog (termsEnum is beyond where we would otherwise seek) - assert ! context.reader().terms(fieldName).iterator(null).seekExact(curVNodeTerm, false) : "should be absent"; + assert ! context.reader().terms(fieldName).iterator(null).seekExact(curVNodeTerm) : "should be absent"; } else { if (compare < 0) { // Seek ! - TermsEnum.SeekStatus seekStatus = termsEnum.seekCeil(curVNodeTerm, true); + TermsEnum.SeekStatus seekStatus = termsEnum.seekCeil(curVNodeTerm); if (seekStatus == TermsEnum.SeekStatus.END) break; // all done thisTerm = termsEnum.term(); Index: lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextFieldsReader.java =================================================================== --- lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextFieldsReader.java (revision 1503742) +++ lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextFieldsReader.java (working copy) @@ -109,7 +109,7 @@ } @Override - public boolean seekExact(BytesRef text, boolean useCache /* ignored */) throws IOException { + public boolean seekExact(BytesRef text) throws IOException { final BytesRefFSTEnum.InputOutput>> result = fstEnum.seekExact(text); if (result != null) { @@ -125,7 +125,7 @@ } @Override - public SeekStatus seekCeil(BytesRef text, boolean useCache /* ignored */) throws IOException { + public SeekStatus seekCeil(BytesRef text) throws IOException { //System.out.println("seek to text=" + text.utf8ToString()); final BytesRefFSTEnum.InputOutput>> result = fstEnum.seekCeil(text); Index: lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextTermVectorsReader.java =================================================================== --- lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextTermVectorsReader.java (revision 1503742) +++ lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextTermVectorsReader.java (working copy) @@ -331,7 +331,7 @@ } @Override - public SeekStatus seekCeil(BytesRef text, boolean useCache) throws IOException { + public SeekStatus seekCeil(BytesRef text) throws IOException { iterator = terms.tailMap(text).entrySet().iterator(); if (!iterator.hasNext()) { return SeekStatus.END; Index: lucene/codecs/src/java/org/apache/lucene/codecs/blockterms/BlockTermsReader.java =================================================================== --- lucene/codecs/src/java/org/apache/lucene/codecs/blockterms/BlockTermsReader.java (revision 1503742) +++ lucene/codecs/src/java/org/apache/lucene/codecs/blockterms/BlockTermsReader.java (working copy) @@ -69,9 +69,6 @@ private final TreeMap fields = new TreeMap(); - // Caches the most recently looked-up field + terms: - private final DoubleBarrelLRUCache termsCache; - // Reads the terms index private TermsIndexReaderBase indexReader; @@ -113,11 +110,10 @@ // private String segment; public BlockTermsReader(TermsIndexReaderBase indexReader, Directory dir, FieldInfos fieldInfos, SegmentInfo info, PostingsReaderBase postingsReader, IOContext context, - int termsCacheSize, String segmentSuffix) + String segmentSuffix) throws IOException { this.postingsReader = postingsReader; - termsCache = new DoubleBarrelLRUCache(termsCacheSize); // this.segment = segment; in = dir.openInput(IndexFileNames.segmentFileName(info.name, segmentSuffix, BlockTermsWriter.TERMS_EXTENSION), @@ -362,13 +358,13 @@ // return NOT_FOUND so it's a waste for us to fill in // the term that was actually NOT_FOUND @Override - public SeekStatus seekCeil(final BytesRef target, final boolean useCache) throws IOException { + public SeekStatus seekCeil(final BytesRef target) throws IOException { if (indexEnum == null) { throw new IllegalStateException("terms index was not loaded"); } - //System.out.println("BTR.seek seg=" + segment + " target=" + fieldInfo.name + ":" + target.utf8ToString() + " " + target + " current=" + term().utf8ToString() + " " + term() + " useCache=" + useCache + " indexIsCurrent=" + indexIsCurrent + " didIndexNext=" + didIndexNext + " seekPending=" + seekPending + " divisor=" + indexReader.getDivisor() + " this=" + this); + //System.out.println("BTR.seek seg=" + segment + " target=" + fieldInfo.name + ":" + target.utf8ToString() + " " + target + " current=" + term().utf8ToString() + " " + term() + " indexIsCurrent=" + indexIsCurrent + " didIndexNext=" + didIndexNext + " seekPending=" + seekPending + " divisor=" + indexReader.getDivisor() + " this=" + this); if (didIndexNext) { if (nextIndexTerm == null) { //System.out.println(" nextIndexTerm=null"); @@ -377,23 +373,6 @@ } } - // Check cache - if (useCache) { - fieldTerm.term = target; - // TODO: should we differentiate "frozen" - // TermState (ie one that was cloned and - // cached/returned by termState()) from the - // malleable (primary) one? - final TermState cachedState = termsCache.get(fieldTerm); - if (cachedState != null) { - seekPending = true; - //System.out.println(" cached!"); - seekExact(target, cachedState); - //System.out.println(" term=" + term.utf8ToString()); - return SeekStatus.FOUND; - } - } - boolean doSeek = true; // See if we can avoid seeking, because target term @@ -574,14 +553,6 @@ // Done! Exact match. Stop here, fill in // real term, return FOUND. //System.out.println(" FOUND"); - - if (useCache) { - // Store in cache - decodeMetaData(); - //System.out.println(" cache! state=" + state); - termsCache.put(new FieldAndTerm(fieldTerm), (BlockTermState) state.clone()); - } - return SeekStatus.FOUND; } else { //System.out.println(" NOT_FOUND"); Index: lucene/codecs/src/java/org/apache/lucene/codecs/memory/MemoryPostingsFormat.java =================================================================== --- lucene/codecs/src/java/org/apache/lucene/codecs/memory/MemoryPostingsFormat.java (revision 1503742) +++ lucene/codecs/src/java/org/apache/lucene/codecs/memory/MemoryPostingsFormat.java (working copy) @@ -654,7 +654,7 @@ } @Override - public boolean seekExact(BytesRef text, boolean useCache /* ignored */) throws IOException { + public boolean seekExact(BytesRef text) throws IOException { //System.out.println("te.seekExact text=" + field.name + ":" + text.utf8ToString() + " this=" + this); current = fstEnum.seekExact(text); didDecode = false; @@ -662,7 +662,7 @@ } @Override - public SeekStatus seekCeil(BytesRef text, boolean useCache /* ignored */) throws IOException { + public SeekStatus seekCeil(BytesRef text) throws IOException { //System.out.println("te.seek text=" + field.name + ":" + text.utf8ToString() + " this=" + this); current = fstEnum.seekCeil(text); if (current == null) { Index: lucene/codecs/src/java/org/apache/lucene/codecs/memory/DirectPostingsFormat.java =================================================================== --- lucene/codecs/src/java/org/apache/lucene/codecs/memory/DirectPostingsFormat.java (revision 1503742) +++ lucene/codecs/src/java/org/apache/lucene/codecs/memory/DirectPostingsFormat.java (working copy) @@ -684,7 +684,7 @@ } @Override - public SeekStatus seekCeil(BytesRef term, boolean useCache) { + public SeekStatus seekCeil(BytesRef term) { // TODO: we should use the skip pointers; should be // faster than bin search; we should also hold // & reuse current state so seeking forwards is @@ -707,7 +707,7 @@ } @Override - public boolean seekExact(BytesRef term, boolean useCache) { + public boolean seekExact(BytesRef term) { // TODO: we should use the skip pointers; should be // faster than bin search; we should also hold // & reuse current state so seeking forwards is @@ -1413,7 +1413,7 @@ } @Override - public SeekStatus seekCeil(BytesRef term, boolean useCache) { + public SeekStatus seekCeil(BytesRef term) { throw new UnsupportedOperationException(); } Index: lucene/codecs/src/java/org/apache/lucene/codecs/bloom/BloomFilteringPostingsFormat.java =================================================================== --- lucene/codecs/src/java/org/apache/lucene/codecs/bloom/BloomFilteringPostingsFormat.java (revision 1503742) +++ lucene/codecs/src/java/org/apache/lucene/codecs/bloom/BloomFilteringPostingsFormat.java (working copy) @@ -331,7 +331,7 @@ } @Override - public final boolean seekExact(BytesRef text, boolean useCache) + public final boolean seekExact(BytesRef text) throws IOException { // The magical fail-fast speed up that is the entire point of all of // this code - save a disk seek if there is a match on an in-memory @@ -341,13 +341,13 @@ if (filter.contains(text) == ContainsResult.NO) { return false; } - return delegate().seekExact(text, useCache); + return delegate().seekExact(text); } @Override - public final SeekStatus seekCeil(BytesRef text, boolean useCache) + public final SeekStatus seekCeil(BytesRef text) throws IOException { - return delegate().seekCeil(text, useCache); + return delegate().seekCeil(text); } @Override Index: lucene/suggest/src/java/org/apache/lucene/search/spell/SpellChecker.java =================================================================== --- lucene/suggest/src/java/org/apache/lucene/search/spell/SpellChecker.java (revision 1503742) +++ lucene/suggest/src/java/org/apache/lucene/search/spell/SpellChecker.java (working copy) @@ -525,7 +525,7 @@ if (!isEmpty) { for (TermsEnum te : termsEnums) { - if (te.seekExact(currentTerm, false)) { + if (te.seekExact(currentTerm)) { continue terms; } } Index: solr/core/src/test/org/apache/solr/request/TestFaceting.java =================================================================== --- solr/core/src/test/org/apache/solr/request/TestFaceting.java (revision 1503742) +++ solr/core/src/test/org/apache/solr/request/TestFaceting.java (working copy) @@ -112,7 +112,7 @@ // test seeking before term if (size>0) { - assertEquals(size>0, te.seekCeil(new BytesRef("000"), true) != TermsEnum.SeekStatus.END); + assertEquals(size>0, te.seekCeil(new BytesRef("000")) != TermsEnum.SeekStatus.END); assertEquals(0, te.ord()); assertEquals(t(0), te.term().utf8ToString()); } Index: solr/core/src/test/org/apache/solr/search/TestRTGBase.java =================================================================== --- solr/core/src/test/org/apache/solr/search/TestRTGBase.java (revision 1503742) +++ solr/core/src/test/org/apache/solr/search/TestRTGBase.java (working copy) @@ -132,7 +132,7 @@ if (terms == null) return -1; BytesRef termBytes = t.bytes(); final TermsEnum termsEnum = terms.iterator(null); - if (!termsEnum.seekExact(termBytes, false)) { + if (!termsEnum.seekExact(termBytes)) { return -1; } DocsEnum docs = termsEnum.docs(MultiFields.getLiveDocs(r), null, DocsEnum.FLAG_NONE); Index: solr/core/src/java/org/apache/solr/handler/component/QueryElevationComponent.java =================================================================== --- solr/core/src/java/org/apache/solr/handler/component/QueryElevationComponent.java (revision 1503742) +++ solr/core/src/java/org/apache/solr/handler/component/QueryElevationComponent.java (working copy) @@ -562,7 +562,7 @@ for (String id : elevations.ids) { term.copyChars(id); - if (seen.contains(id) == false && termsEnum.seekExact(term, false)) { + if (seen.contains(id) == false && termsEnum.seekExact(term)) { docsEnum = termsEnum.docs(liveDocs, docsEnum, DocsEnum.FLAG_NONE); if (docsEnum != null) { int docId = docsEnum.nextDoc(); Index: solr/core/src/java/org/apache/solr/handler/component/TermsComponent.java =================================================================== --- solr/core/src/java/org/apache/solr/handler/component/TermsComponent.java (revision 1503742) +++ solr/core/src/java/org/apache/solr/handler/component/TermsComponent.java (working copy) @@ -163,7 +163,7 @@ BytesRef term = null; if (lowerBytes != null) { - if (termsEnum.seekCeil(lowerBytes, true) == TermsEnum.SeekStatus.END) { + if (termsEnum.seekCeil(lowerBytes) == TermsEnum.SeekStatus.END) { termsEnum = null; } else { term = termsEnum.term(); Index: solr/core/src/java/org/apache/solr/request/SimpleFacets.java =================================================================== --- solr/core/src/java/org/apache/solr/request/SimpleFacets.java (revision 1503742) +++ solr/core/src/java/org/apache/solr/request/SimpleFacets.java (working copy) @@ -768,7 +768,7 @@ // facet.offset when sorting by index order. if (startTermBytes != null) { - if (termsEnum.seekCeil(startTermBytes, true) == TermsEnum.SeekStatus.END) { + if (termsEnum.seekCeil(startTermBytes) == TermsEnum.SeekStatus.END) { termsEnum = null; } else { term = termsEnum.term(); Index: solr/core/src/java/org/apache/solr/request/UnInvertedField.java =================================================================== --- solr/core/src/java/org/apache/solr/request/UnInvertedField.java (revision 1503742) +++ solr/core/src/java/org/apache/solr/request/UnInvertedField.java (working copy) @@ -231,13 +231,13 @@ TermsEnum te = getOrdTermsEnum(searcher.getAtomicReader()); if (te != null && prefix != null && prefix.length() > 0) { final BytesRef prefixBr = new BytesRef(prefix); - if (te.seekCeil(prefixBr, true) == TermsEnum.SeekStatus.END) { + if (te.seekCeil(prefixBr) == TermsEnum.SeekStatus.END) { startTerm = numTermsInField; } else { startTerm = (int) te.ord(); } prefixBr.append(UnicodeUtil.BIG_TERM); - if (te.seekCeil(prefixBr, true) == TermsEnum.SeekStatus.END) { + if (te.seekCeil(prefixBr) == TermsEnum.SeekStatus.END) { endTerm = numTermsInField; } else { endTerm = (int) te.ord(); Index: solr/core/src/java/org/apache/solr/search/JoinQParserPlugin.java =================================================================== --- solr/core/src/java/org/apache/solr/search/JoinQParserPlugin.java (revision 1503742) +++ solr/core/src/java/org/apache/solr/search/JoinQParserPlugin.java (working copy) @@ -309,7 +309,7 @@ if (prefix == null) { term = termsEnum.next(); } else { - if (termsEnum.seekCeil(prefix, true) != TermsEnum.SeekStatus.END) { + if (termsEnum.seekCeil(prefix) != TermsEnum.SeekStatus.END) { term = termsEnum.term(); } } Index: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java =================================================================== --- solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java (revision 1503742) +++ solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java (working copy) @@ -718,7 +718,7 @@ if (terms == null) return -1; BytesRef termBytes = t.bytes(); final TermsEnum termsEnum = terms.iterator(null); - if (!termsEnum.seekExact(termBytes, false)) { + if (!termsEnum.seekExact(termBytes)) { return -1; } DocsEnum docs = termsEnum.docs(atomicReader.getLiveDocs(), null, DocsEnum.FLAG_NONE); @@ -742,7 +742,7 @@ if (terms == null) continue; TermsEnum te = terms.iterator(null); - if (te.seekExact(idBytes, true)) { + if (te.seekExact(idBytes)) { DocsEnum docs = te.docs(reader.getLiveDocs(), null, DocsEnum.FLAG_NONE); int id = docs.nextDoc(); if (id == DocIdSetIterator.NO_MORE_DOCS) continue; Index: solr/core/src/java/org/apache/solr/search/function/FileFloatSource.java =================================================================== --- solr/core/src/java/org/apache/solr/search/function/FileFloatSource.java (revision 1503742) +++ solr/core/src/java/org/apache/solr/search/function/FileFloatSource.java (working copy) @@ -297,7 +297,7 @@ continue; // go to next line in file.. leave values as default. } - if (!termsEnum.seekExact(internalKey, false)) { + if (!termsEnum.seekExact(internalKey)) { if (notFoundCount<10) { // collect first 10 not found for logging notFound.add(key); }