Index: core/src/main/java/org/apache/hcatalog/mapreduce/HCatStorageHandler.java =================================================================== --- core/src/main/java/org/apache/hcatalog/mapreduce/HCatStorageHandler.java (revision 1460809) +++ core/src/main/java/org/apache/hcatalog/mapreduce/HCatStorageHandler.java (working copy) @@ -29,7 +29,7 @@ import org.apache.hadoop.mapred.OutputFormat; /** - * The abstract Class HCatStorageHandler would server as the base class for all + * The abstract class HCatStorageHandler would serve as the base class for all * the storage handlers required for non-native tables in HCatalog. */ public abstract class HCatStorageHandler implements HiveStorageHandler { @@ -37,16 +37,16 @@ //TODO move this to HiveStorageHandler /** - * This method is called to allow the StorageHandlers the chance - * to populate the JobContext.getConfiguration() with properties that - * maybe be needed by the handler's bundled artifacts (ie InputFormat, SerDe, etc). - * Key value pairs passed into jobProperties is guaranteed to be set in the job's - * configuration object. User's can retrieve "context" information from tableDesc. - * User's should avoid mutating tableDesc and only make changes in jobProperties. + * This method is called to allow the StorageHandlers + * to populate the JobContext.getConfiguration() with properties + * needed by the handler's bundled artifacts (eg, InputFormat, SerDe, etc). + * Key-value pairs passed in as jobProperties are guaranteed to be set in the job's + * configuration object. Users can retrieve "context" information from tableDesc. + * Users should avoid changing tableDesc directly and only make changes via jobProperties. * This method is expected to be idempotent such that a job called with the * same tableDesc values should return the same key-value pairs in jobProperties. * Any external state set by this method should remain the same if this method is - * called again. It is up to the user to determine how best guarantee this invariant. + * called again. It is up to the user to determine how best to guarantee this invariant. * * This method in particular is to create a configuration for input. * @param tableDesc @@ -57,16 +57,16 @@ //TODO move this to HiveStorageHandler /** - * This method is called to allow the StorageHandlers the chance - * to populate the JobContext.getConfiguration() with properties that - * maybe be needed by the handler's bundled artifacts (ie InputFormat, SerDe, etc). - * Key value pairs passed into jobProperties is guaranteed to be set in the job's - * configuration object. User's can retrieve "context" information from tableDesc. - * User's should avoid mutating tableDesc and only make changes in jobProperties. + * This method is called to allow the StorageHandlers + * to populate the JobContext.getConfiguration() with properties + * needed by the handler's bundled artifacts (eg, InputFormat, SerDe, etc). + * Key-value pairs passed in as jobProperties are guaranteed to be set in the job's + * configuration object. Users can retrieve "context" information from tableDesc. + * Users should avoid changing tableDesc directly and only make changes via jobProperties. * This method is expected to be idempotent such that a job called with the * same tableDesc values should return the same key-value pairs in jobProperties. * Any external state set by this method should remain the same if this method is - * called again. It is up to the user to determine how best guarantee this invariant. + * called again. It is up to the user to determine how best to guarantee this invariant. * * This method in particular is to create a configuration for output. * @param tableDesc