Index: core/src/main/java/org/apache/hcatalog/mapreduce/InputJobInfo.java =================================================================== --- core/src/main/java/org/apache/hcatalog/mapreduce/InputJobInfo.java (revision 1425038) +++ core/src/main/java/org/apache/hcatalog/mapreduce/InputJobInfo.java (working copy) @@ -69,6 +69,7 @@ * @param databaseName the db name * @param tableName the table name * @param filter the partition filter + * @param properties implementation specific job properties */ public static InputJobInfo create(String databaseName, String tableName, @@ -77,6 +78,20 @@ return new InputJobInfo(databaseName, tableName, filter, properties); } + /** + * Initializes a new InputJobInfo + * for reading data from a table. + * @param databaseName the db name + * @param tableName the table name + * @param filter the partition filter + */ + public static InputJobInfo create(String databaseName, + String tableName, + String filter) { + return create(databaseName, tableName, filter, null); + } + + private InputJobInfo(String databaseName, String tableName, String filter, Index: core/src/test/java/org/apache/hcatalog/mapreduce/TestInputJobInfo.java =================================================================== --- core/src/test/java/org/apache/hcatalog/mapreduce/TestInputJobInfo.java (revision 0) +++ core/src/test/java/org/apache/hcatalog/mapreduce/TestInputJobInfo.java (revision 0) @@ -0,0 +1,47 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hcatalog.mapreduce; + +import java.util.Properties; + +import junit.framework.Assert; + +import org.junit.Test; + +public class TestInputJobInfo extends HCatBaseTest { + + @Test + public void test4ArgCreate() throws Exception { + Properties p = new Properties(); + p.setProperty("key", "value"); + InputJobInfo jobInfo = InputJobInfo.create("Db", "Table", "Filter", p); + Assert.assertEquals("Db", jobInfo.getDatabaseName()); + Assert.assertEquals("Table", jobInfo.getTableName()); + Assert.assertEquals("Filter", jobInfo.getFilter()); + Assert.assertEquals("value", jobInfo.getProperties().getProperty("key")); + } + + @Test + public void test3ArgCreate() throws Exception { + InputJobInfo jobInfo = InputJobInfo.create("Db", "Table", "Filter"); + Assert.assertEquals("Db", jobInfo.getDatabaseName()); + Assert.assertEquals("Table", jobInfo.getTableName()); + Assert.assertEquals("Filter", jobInfo.getFilter()); + Assert.assertEquals(0, jobInfo.getProperties().size()); + } +}