diff --git build-support/checkstyle/coding_style.xml build-support/checkstyle/coding_style.xml index 9c16bda..5e17129 100644 --- build-support/checkstyle/coding_style.xml +++ build-support/checkstyle/coding_style.xml @@ -38,6 +38,8 @@ imposed on others. + + diff --git core/src/main/java/org/apache/hadoop/mapred/HCatMapRedUtil.java core/src/main/java/org/apache/hadoop/mapred/HCatMapRedUtil.java index bc7280e..718ae31 100644 --- core/src/main/java/org/apache/hadoop/mapred/HCatMapRedUtil.java +++ core/src/main/java/org/apache/hadoop/mapred/HCatMapRedUtil.java @@ -24,6 +24,8 @@ import org.apache.hcatalog.shims.HCatHadoopShims; public class HCatMapRedUtil { + private HCatMapRedUtil() {} + public static TaskAttemptContext createTaskAttemptContext(org.apache.hadoop.mapreduce.TaskAttemptContext context) { return createTaskAttemptContext(new JobConf(context.getConfiguration()), org.apache.hadoop.mapred.TaskAttemptID.forName(context.getTaskAttemptID().toString()), diff --git core/src/main/java/org/apache/hcatalog/cli/HCatCli.java core/src/main/java/org/apache/hcatalog/cli/HCatCli.java index f305fe2..a0ed98c 100644 --- core/src/main/java/org/apache/hcatalog/cli/HCatCli.java +++ core/src/main/java/org/apache/hcatalog/cli/HCatCli.java @@ -53,6 +53,8 @@ import org.apache.hcatalog.common.HCatUtil; public class HCatCli { + private HCatCli() {} + @SuppressWarnings("static-access") public static void main(String[] args) { diff --git core/src/main/java/org/apache/hcatalog/common/HCatUtil.java core/src/main/java/org/apache/hcatalog/common/HCatUtil.java index 0aa1014..63c4a95 100644 --- core/src/main/java/org/apache/hcatalog/common/HCatUtil.java +++ core/src/main/java/org/apache/hcatalog/common/HCatUtil.java @@ -79,6 +79,8 @@ public class HCatUtil { private static volatile HiveClientCache hiveClientCache; private final static int DEFAULT_HIVE_CACHE_EXPIRY_TIME_SECONDS = 2 * 60; + private HCatUtil() {} + public static boolean checkJobContextIfRunningFromBackend(JobContext j) { if (j.getConfiguration().get("mapred.task.id", "").equals("")) { return false; diff --git core/src/main/java/org/apache/hcatalog/data/HCatRecordObjectInspectorFactory.java core/src/main/java/org/apache/hcatalog/data/HCatRecordObjectInspectorFactory.java index de9f79d..6a014a1 100644 --- core/src/main/java/org/apache/hcatalog/data/HCatRecordObjectInspectorFactory.java +++ core/src/main/java/org/apache/hcatalog/data/HCatRecordObjectInspectorFactory.java @@ -45,6 +45,8 @@ public class HCatRecordObjectInspectorFactory { static HashMap cachedObjectInspectors = new HashMap(); + private HCatRecordObjectInspectorFactory() {} + /** * Returns HCatRecordObjectInspector given a StructTypeInfo type definition for the record to look into * @param typeInfo Type definition for the record to look into diff --git core/src/main/java/org/apache/hcatalog/data/schema/HCatSchemaUtils.java core/src/main/java/org/apache/hcatalog/data/schema/HCatSchemaUtils.java index 5e95439..1557cff 100644 --- core/src/main/java/org/apache/hcatalog/data/schema/HCatSchemaUtils.java +++ core/src/main/java/org/apache/hcatalog/data/schema/HCatSchemaUtils.java @@ -38,6 +38,8 @@ import org.apache.hcatalog.data.schema.HCatFieldSchema.Type; public class HCatSchemaUtils { + private HCatSchemaUtils() {} + public static CollectionBuilder getStructSchemaBuilder() { return new CollectionBuilder(); } diff --git core/src/main/java/org/apache/hcatalog/data/transfer/DataTransferFactory.java core/src/main/java/org/apache/hcatalog/data/transfer/DataTransferFactory.java index f10ec8c..e493490 100644 --- core/src/main/java/org/apache/hcatalog/data/transfer/DataTransferFactory.java +++ core/src/main/java/org/apache/hcatalog/data/transfer/DataTransferFactory.java @@ -34,6 +34,8 @@ import org.apache.hcatalog.data.transfer.state.StateProvider; public class DataTransferFactory { + private DataTransferFactory() {} + /** * This should be called once from master node to obtain an instance of * {@link HCatReader}. diff --git core/src/main/java/org/apache/hcatalog/mapreduce/InitializeInput.java core/src/main/java/org/apache/hcatalog/mapreduce/InitializeInput.java index e91ddc7..dd1ef73 100644 --- core/src/main/java/org/apache/hcatalog/mapreduce/InitializeInput.java +++ core/src/main/java/org/apache/hcatalog/mapreduce/InitializeInput.java @@ -49,6 +49,8 @@ public class InitializeInput { private static final Logger LOG = LoggerFactory.getLogger(InitializeInput.class); + private InitializeInput() {} + /** * @see org.apache.hcatalog.mapreduce.InitializeInput#setInput(org.apache.hadoop.conf.Configuration, InputJobInfo) */ diff --git core/src/main/java/org/apache/hcatalog/mapreduce/InternalUtil.java core/src/main/java/org/apache/hcatalog/mapreduce/InternalUtil.java index 42c98c1..1d6d3d2 100644 --- core/src/main/java/org/apache/hcatalog/mapreduce/InternalUtil.java +++ core/src/main/java/org/apache/hcatalog/mapreduce/InternalUtil.java @@ -58,6 +58,8 @@ import java.util.Properties; class InternalUtil { private static final Logger LOG = LoggerFactory.getLogger(InternalUtil.class); + private InternalUtil() {} + static StorerInfo extractStorerInfo(StorageDescriptor sd, Map properties) throws IOException { Properties hcatProperties = new Properties(); for (String key : properties.keySet()) { diff --git core/src/main/java/org/apache/hcatalog/oozie/JavaAction.java core/src/main/java/org/apache/hcatalog/oozie/JavaAction.java index f45f0e3..b70c0ef 100644 --- core/src/main/java/org/apache/hcatalog/oozie/JavaAction.java +++ core/src/main/java/org/apache/hcatalog/oozie/JavaAction.java @@ -27,6 +27,8 @@ import org.apache.hcatalog.cli.SemanticAnalysis.HCatSemanticAnalyzer; public class JavaAction { + private JavaAction() {} + public static void main(String[] args) throws Exception { HiveConf conf = new HiveConf(); diff --git core/src/test/java/org/apache/hcatalog/HcatTestUtils.java core/src/test/java/org/apache/hcatalog/HcatTestUtils.java index 3348339..b001e08 100644 --- core/src/test/java/org/apache/hcatalog/HcatTestUtils.java +++ core/src/test/java/org/apache/hcatalog/HcatTestUtils.java @@ -48,6 +48,8 @@ public class HcatTestUtils { public static FsPermission perm500 = FsPermission.createImmutable((short) 0500); // -r-x------ public static FsPermission perm555 = FsPermission.createImmutable((short) 0555); // -r-xr-xr-x + private HcatTestUtils() {} + /** * Returns the database path. */ diff --git core/src/test/java/org/apache/hcatalog/data/HCatDataCheckUtil.java core/src/test/java/org/apache/hcatalog/data/HCatDataCheckUtil.java index dc09fdb..7863b75 100644 --- core/src/test/java/org/apache/hcatalog/data/HCatDataCheckUtil.java +++ core/src/test/java/org/apache/hcatalog/data/HCatDataCheckUtil.java @@ -38,6 +38,8 @@ public class HCatDataCheckUtil { private static final Logger LOG = LoggerFactory.getLogger(HCatDataCheckUtil.class); + private HCatDataCheckUtil() {} + public static Driver instantiateDriver(MiniCluster cluster) { HiveConf hiveConf = new HiveConf(HCatDataCheckUtil.class); for (Entry e : cluster.getProperties().entrySet()) { diff --git webhcat/svr/src/main/java/org/apache/hcatalog/templeton/UgiFactory.java webhcat/svr/src/main/java/org/apache/hcatalog/templeton/UgiFactory.java index 5763ba3..8e8cf35 100644 --- webhcat/svr/src/main/java/org/apache/hcatalog/templeton/UgiFactory.java +++ webhcat/svr/src/main/java/org/apache/hcatalog/templeton/UgiFactory.java @@ -26,6 +26,8 @@ public class UgiFactory { private static ConcurrentHashMap userUgiMap = new ConcurrentHashMap(); + private UgiFactory() {} + static UserGroupInformation getUgi(String user) throws IOException { UserGroupInformation ugi = userUgiMap.get(user); if (ugi == null) { diff --git webhcat/svr/src/main/java/org/apache/hcatalog/templeton/tool/TempletonUtils.java webhcat/svr/src/main/java/org/apache/hcatalog/templeton/tool/TempletonUtils.java index 67bd8fd..f7db5fa 100644 --- webhcat/svr/src/main/java/org/apache/hcatalog/templeton/tool/TempletonUtils.java +++ webhcat/svr/src/main/java/org/apache/hcatalog/templeton/tool/TempletonUtils.java @@ -40,6 +40,9 @@ import org.apache.hadoop.util.StringUtils; * General utility methods. */ public class TempletonUtils { + + private TempletonUtils() {} + /** * Is the object non-empty? */