Index: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ProtobufRpcEngine.java =================================================================== --- hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ProtobufRpcEngine.java (revision 1409645) +++ hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ProtobufRpcEngine.java (working copy) @@ -325,7 +325,7 @@ //which implementation of the protocol should be used to service the //current request, etc. Ideally, we shouldn't land up in a situation //where we need to support such a use case. - //For now the clientVersion field is simply ignored + //For now the clientVersion field is simply ignored long clientVersion = rpcRequest.getClientProtocolVersion(); if (verbose) { @@ -333,10 +333,10 @@ ", method=" + methodName); } - status.setRPC(rpcRequest.getMethodName(), + status.setRPC(rpcRequest.getMethodName(), new Object[]{rpcRequest.getRequest()}, receiveTime); status.setRPCPacket(rpcRequest); - status.resume("Servicing call"); + status.resume("Servicing call"); //get an instance of the method arg type Message protoType = getMethodArgType(method); Message param = protoType.newBuilderForType() @@ -366,10 +366,11 @@ int qTime = (int) (startTime-receiveTime); if (TRACELOG.isDebugEnabled()) { TRACELOG.debug("Call #" + CurCall.get().id + - "; Served: " + protocol.getSimpleName()+"#"+method.getName() + - " queueTime=" + qTime + - " processingTime=" + processingTime + - " contents=" + param.toString()); + "; served=" + protocol.getSimpleName() + "#" + method.getName() + + ", queueTime=" + qTime + + ", processingTime=" + processingTime + + ", request=" + param.toString() + + " response=" + result.toString()); } rpcMetrics.rpcQueueTime.inc(qTime); rpcMetrics.rpcProcessingTime.inc(processingTime); @@ -393,7 +394,7 @@ buffer.append(param.getClass().getName()); buffer.append(")"); buffer.append(", client version="+clientVersion); - logResponse(new Object[]{rpcRequest.getRequest()}, + logResponse(new Object[]{rpcRequest.getRequest()}, methodName, buffer.toString(), (tooLarge ? "TooLarge" : "TooSlow"), status.getClient(), startTime, processingTime, qTime, responseSize);