Index: src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java =================================================================== --- src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java (revision 1163519) +++ src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java (working copy) @@ -366,19 +366,21 @@ // note that large responses will often also be slow. logResponse(call, (tooLarge ? "TooLarge" : "TooSlow"), startTime, processingTime, qTime, responseSize); + /* TODO implement a working global slow RPC response metric // provides a count of log-reported slow responses if (tooSlow) { rpcMetrics.inc(call.getMethodName() + ".slowResponse.", processingTime); - } + } */ } + /* TODO implement a working aboveOneSec metric if (processingTime > 1000) { // we use a hard-coded one second period so that we can clearly // indicate the time period we're warning about in the name of the // metric itself rpcMetrics.inc(call.getMethodName() + ".aboveOneSec.", processingTime); - } + } */ return retVal; } catch (InvocationTargetException e) { @@ -440,7 +442,7 @@ } else if (params.length == 1 && instance instanceof HRegionServer && params[0] instanceof Operation) { // annotate the response map with operation details - responseInfo.putAll(((Operation) params[1]).toMap()); + responseInfo.putAll(((Operation) params[0]).toMap()); // report to the log file LOG.warn("(operation" + tag + "): " + mapper.writeValueAsString(responseInfo));