Index: src/docbkx/developer.xml =================================================================== --- src/docbkx/developer.xml (revision 1163368) +++ src/docbkx/developer.xml (working copy) @@ -183,6 +183,7 @@
Create Patch Patch files can be easily generated from Eclipse, for example by selecting "Team -> Create Patch". + Patches can also be created by git diff and svn diff. Please submit one patch-file per Jira. For example, if multiple files are changed make sure the selected resource when generating the patch is a directory. Patch files can reflect changes in multiple files. @@ -191,13 +192,16 @@
Patch File Naming The patch file should have the HBase Jira ticket in the name. For example, if a patch was submitted for Foo.java, then - a patch file called Foo_HBASE_XXX.patch would be acceptable where XXX is the HBase Jira number. + a patch file called Foo_HBASE_XXXX.patch would be acceptable where XXXX is the HBase Jira number. + + If you generating from a branch, then including the target branch in the filename is advised, e.g., HBASE-XXXX-0.90.patch.
Unit Tests - Yes, please. Please try to include unit tests with every code patch (and especially new classes and large changes). - Also, please make sure unit tests pass locally before submitting the patch. + Yes, please. Please try to include unit tests with every code patch (and especially new classes and large changes). + Make sure unit tests pass locally before submitting the patch. + Also, see .
Attach Patch to Jira @@ -312,11 +316,13 @@ But the preference is to add something descriptive and useful.
-
- Unrelated Code Formating or Auto-Reformating +
+ One Thing At A Time, Folks If you submit a patch for one thing, don't do auto-reformatting or unrelated reformatting of code on a completely different area of code. + Likewise, don't add unrelated cleanup or refactorings outside the scope of your Jira. +
Ambigious Unit Tests