Index: java/org/apache/hadoop/hbase/regionserver/HRegionServer.java =================================================================== --- java/org/apache/hadoop/hbase/regionserver/HRegionServer.java (revision 1099334) +++ java/org/apache/hadoop/hbase/regionserver/HRegionServer.java (working copy) @@ -1144,7 +1144,7 @@ protected void metrics() { this.metrics.regions.set(this.onlineRegions.size()); - this.metrics.incrementRequests(this.requestCount.get()); + this.metrics.requests.set(this.requestCount.get()); // Is this too expensive every three seconds getting a lock on onlineRegions // and then per store carried? Can I make metrics be sloppier and avoid // the synchronizations? Index: java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java =================================================================== --- java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java (revision 1099334) +++ java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java (working copy) @@ -23,7 +23,6 @@ import org.apache.commons.logging.LogFactory; import org.apache.hadoop.hbase.io.hfile.HFile; import org.apache.hadoop.hbase.metrics.HBaseInfo; -import org.apache.hadoop.hbase.metrics.MetricsRate; import org.apache.hadoop.hbase.metrics.PersistentMetricsTimeVaryingRate; import org.apache.hadoop.hbase.regionserver.wal.HLog; import org.apache.hadoop.hbase.util.Pair; @@ -112,10 +111,10 @@ */ public final MetricsIntValue blockCacheHitCachingRatio = new MetricsIntValue("blockCacheHitCachingRatio", registry); - /* + /** * Count of requests to the regionservers since last call to metrics update */ - private final MetricsRate requests = new MetricsRate("requests", registry); + public final MetricsIntValue requests = new MetricsIntValue("requests", registry); /** * Count of stores open on the regionserver. @@ -307,13 +306,6 @@ } /** - * @return Count of requests. - */ - public float getRequests() { - return this.requests.getPreviousIntervalValue(); - } - - /** * @param compact history in */ public synchronized void addCompaction(final Pair compact) { @@ -331,12 +323,6 @@ } } - /** - * @param inc How much to add to requests. - */ - public void incrementRequests(final int inc) { - this.requests.inc(inc); - } @Override public String toString() { @@ -345,8 +331,8 @@ if (seconds == 0) { seconds = 1; } - sb = Strings.appendKeyValue(sb, "request", - Float.valueOf(this.requests.getPreviousIntervalValue())); + sb = Strings.appendKeyValue(sb, "requests", + Integer.valueOf(this.requests.get())); sb = Strings.appendKeyValue(sb, "regions", Integer.valueOf(this.regions.get())); sb = Strings.appendKeyValue(sb, "stores",