Index: src/test/java/org/apache/james/mailbox/jpa/host/JPAHostSystem.java =================================================================== --- src/test/java/org/apache/james/mailbox/jpa/host/JPAHostSystem.java (revision 1074958) +++ src/test/java/org/apache/james/mailbox/jpa/host/JPAHostSystem.java (working copy) @@ -25,7 +25,6 @@ import javax.persistence.EntityManagerFactory; import org.apache.commons.io.FileUtils; -import org.apache.commons.logging.impl.SimpleLog; import org.apache.james.imap.api.process.ImapProcessor; import org.apache.james.imap.encode.main.DefaultImapEncoderFactory; import org.apache.james.imap.main.DefaultImapDecoderFactory; @@ -49,6 +48,7 @@ import org.apache.james.mailbox.jpa.user.model.JPASubscription; import org.apache.james.mailbox.store.MockAuthenticator; import org.apache.openjpa.persistence.OpenJPAPersistence; +import org.slf4j.LoggerFactory; public class JPAHostSystem extends ImapHostSystem { @@ -132,7 +132,7 @@ public void resetData() throws Exception { resetUserMetaData(); - MailboxSession session = mailboxManager.createSystemSession("test", new SimpleLog("TestLog")); + MailboxSession session = mailboxManager.createSystemSession("test", LoggerFactory.getLogger("TestLog")); mailboxManager.startProcessingRequest(session); mailboxManager.deleteEverything(session); mailboxManager.endProcessingRequest(session); Index: src/test/java/org/apache/james/mailbox/jcr/host/JCRHostSystem.java =================================================================== --- src/test/java/org/apache/james/mailbox/jcr/host/JCRHostSystem.java (revision 1074958) +++ src/test/java/org/apache/james/mailbox/jcr/host/JCRHostSystem.java (working copy) @@ -21,7 +21,6 @@ import java.io.File; import org.apache.commons.io.FileUtils; -import org.apache.commons.logging.impl.SimpleLog; import org.apache.jackrabbit.core.RepositoryImpl; import org.apache.jackrabbit.core.config.RepositoryConfig; import org.apache.james.imap.api.process.ImapProcessor; @@ -38,6 +37,7 @@ import org.apache.james.mailbox.jcr.JCRUtils; import org.apache.james.mailbox.jcr.mail.JCRCachingUidProvider; import org.apache.james.mailbox.store.MockAuthenticator; +import org.slf4j.LoggerFactory; import org.xml.sax.InputSource; public class JCRHostSystem extends ImapHostSystem{ @@ -78,7 +78,7 @@ final ImapProcessor defaultImapProcessorFactory = DefaultImapProcessorFactory.createDefaultProcessor(mailboxManager, new JCRSubscriptionManager(mf)); resetUserMetaData(); - MailboxSession session = mailboxManager.createSystemSession("test", new SimpleLog("TestLog")); + MailboxSession session = mailboxManager.createSystemSession("test", LoggerFactory.getLogger("TestLog")); mailboxManager.startProcessingRequest(session); //mailboxManager.deleteEverything(session); mailboxManager.endProcessingRequest(session); Index: src/main/java/org/apache/james/imap/tester/SilentLog.java =================================================================== --- src/main/java/org/apache/james/imap/tester/SilentLog.java (revision 1074958) +++ src/main/java/org/apache/james/imap/tester/SilentLog.java (working copy) @@ -19,9 +19,10 @@ package org.apache.james.imap.tester; -import org.apache.commons.logging.Log; +import org.slf4j.Logger; +import org.slf4j.Marker; -final class SilentLog implements Log { +final class SilentLog implements Logger { public void debug(Object arg0) { } @@ -93,4 +94,179 @@ public void trace(Object arg0, Throwable arg1) { } + + public String getName() { + return "SilentLog"; + } + + public void trace(String msg) { + } + + public void trace(String format, Object arg) { + } + + public void trace(String format, Object arg1, Object arg2) { + } + + public void trace(String format, Object[] argArray) { + } + + public void trace(String msg, Throwable t) { + } + + public boolean isTraceEnabled(Marker marker) { + return false; + } + + public void trace(Marker marker, String msg) { + } + + public void trace(Marker marker, String format, Object arg) { + } + + public void trace(Marker marker, String format, Object arg1, Object arg2) { + } + + public void trace(Marker marker, String format, Object[] argArray) { + } + + public void trace(Marker marker, String msg, Throwable t) { + } + + public void debug(String msg) { + } + + public void debug(String format, Object arg) { + } + + public void debug(String format, Object arg1, Object arg2) { + } + + public void debug(String format, Object[] argArray) { + } + + public void debug(String msg, Throwable t) { + } + + public boolean isDebugEnabled(Marker marker) { + return false; + } + + public void debug(Marker marker, String msg) { + } + + public void debug(Marker marker, String format, Object arg) { + } + + public void debug(Marker marker, String format, Object arg1, Object arg2) { + } + + public void debug(Marker marker, String format, Object[] argArray) { + } + + public void debug(Marker marker, String msg, Throwable t) { + } + + public void info(String msg) { + } + + public void info(String format, Object arg) { + } + + public void info(String format, Object arg1, Object arg2) { + } + + public void info(String format, Object[] argArray) { + } + + public void info(String msg, Throwable t) { + } + + public boolean isInfoEnabled(Marker marker) { + return false; + } + + public void info(Marker marker, String msg) { + } + + public void info(Marker marker, String format, Object arg) { + } + + public void info(Marker marker, String format, Object arg1, Object arg2) { + } + + public void info(Marker marker, String format, Object[] argArray) { + } + + public void info(Marker marker, String msg, Throwable t) { + } + + public void warn(String msg) { + } + + public void warn(String format, Object arg) { + } + + public void warn(String format, Object[] argArray) { + } + + public void warn(String format, Object arg1, Object arg2) { + } + + public void warn(String msg, Throwable t) { + } + + public boolean isWarnEnabled(Marker marker) { + return false; + } + + public void warn(Marker marker, String msg) { + } + + public void warn(Marker marker, String format, Object arg) { + } + + public void warn(Marker marker, String format, Object arg1, Object arg2) { + } + + public void warn(Marker marker, String format, Object[] argArray) { + } + + public void warn(Marker marker, String msg, Throwable t) { + } + + public void error(String msg) { + } + + public void error(String format, Object arg) { + } + + public void error(String format, Object arg1, Object arg2) { + } + + public void error(String format, Object[] argArray) { + } + + public void error(String msg, Throwable t) { + } + + public boolean isErrorEnabled(Marker marker) { + return false; + } + + public void error(Marker marker, String msg) { + } + + public void error(Marker marker, String format, Object arg) { + } + + public void error(Marker marker, String format, Object arg1, Object arg2) { + } + + public void error(Marker marker, String format, Object[] argArray) { + } + + public void error(Marker marker, String msg, Throwable t) { + } + } \ No newline at end of file Index: src/main/java/org/apache/james/imap/tester/ImapSessionImpl.java =================================================================== --- src/main/java/org/apache/james/imap/tester/ImapSessionImpl.java (revision 1074958) +++ src/main/java/org/apache/james/imap/tester/ImapSessionImpl.java (working copy) @@ -21,11 +21,11 @@ import java.util.Map; import java.util.concurrent.ConcurrentHashMap; -import org.apache.commons.logging.Log; import org.apache.james.imap.api.ImapSessionState; import org.apache.james.imap.api.process.ImapLineHandler; import org.apache.james.imap.api.process.ImapSession; import org.apache.james.imap.api.process.SelectedMailbox; +import org.slf4j.Logger; public class ImapSessionImpl implements ImapSession{ @@ -36,9 +36,9 @@ private final Map attributesByKey; - private Log log; + private Logger log; - public ImapSessionImpl(Log log) { + public ImapSessionImpl(Logger log) { this.attributesByKey = new ConcurrentHashMap(); this.log = log; } @@ -91,7 +91,7 @@ } } - public Log getLog() { + public Logger getLog() { return log; } Index: src/main/java/org/apache/james/imap/tester/VerboseConsoleLog.java =================================================================== --- src/main/java/org/apache/james/imap/tester/VerboseConsoleLog.java (revision 1074958) +++ src/main/java/org/apache/james/imap/tester/VerboseConsoleLog.java (working copy) @@ -18,91 +18,307 @@ ****************************************************************/ package org.apache.james.imap.tester; -import org.apache.commons.logging.Log; +import org.slf4j.Logger; +import org.slf4j.Marker; -public class VerboseConsoleLog implements Log { +public class VerboseConsoleLog implements Logger { - public void debug(Object message) { - System.out.println(message); + public String getName() { + return "MockLogger to System out"; } - public void debug(Object message, Throwable t) { - System.out.println(message); - t.printStackTrace(); + public boolean isTraceEnabled() { + return true; } - public void error(Object message) { - System.out.println(message); - + public void trace(String msg) { + SysPrint(msg); } - public void error(Object message, Throwable t) { - System.out.println(message); - t.printStackTrace(); + public void trace(String format, Object arg) { + SysPrint(format, arg); } - public void fatal(Object message) { - System.out.println(message); - + public void trace(String format, Object arg1, Object arg2) { + SysPrint(format, arg1, arg2); } - public void fatal(Object message, Throwable t) { - System.out.println(message); - t.printStackTrace(); + public void trace(String format, Object[] argArray) { + SysPrint(format, argArray); } - public void info(Object message) { - System.out.println(message); - + public void trace(String msg, Throwable t) { + SysPrint(msg, t); } - public void info(Object message, Throwable t) { - System.out.println(message); - t.printStackTrace(); + public boolean isTraceEnabled(Marker marker) { + return true; } + public void trace(Marker marker, String msg) { + SysPrint(marker, msg); + } + + public void trace(Marker marker, String format, Object arg) { + SysPrint(marker, format, arg); + } + + public void trace(Marker marker, String format, Object arg1, Object arg2) { + SysPrint(marker, format, arg1, arg2); + } + + public void trace(Marker marker, String format, Object[] argArray) { + SysPrint(marker, format, argArray); + } + + public void trace(Marker marker, String msg, Throwable t) { + SysPrint(marker, msg, t); + } + public boolean isDebugEnabled() { return true; } - public boolean isErrorEnabled() { - return true; + public void debug(String msg) { + SysPrint(msg); } - public boolean isFatalEnabled() { + public void debug(String format, Object arg) { + SysPrint(format, arg); + } + + public void debug(String format, Object arg1, Object arg2) { + SysPrint(format, arg1, arg2); + } + + public void debug(String format, Object[] argArray) { + SysPrint(format, argArray); + } + + public void debug(String msg, Throwable t) { + SysPrint(msg, t); + } + + public boolean isDebugEnabled(Marker marker) { return true; } + public void debug(Marker marker, String msg) { + SysPrint(marker, msg); + } + + public void debug(Marker marker, String format, Object arg) { + SysPrint(marker, format, arg); + } + + public void debug(Marker marker, String format, Object arg1, Object arg2) { + SysPrint(marker, format, arg1, arg2); + } + + public void debug(Marker marker, String format, Object[] argArray) { + SysPrint(marker, format, argArray); + } + + public void debug(Marker marker, String msg, Throwable t) { + SysPrint(marker, msg, t); + } + public boolean isInfoEnabled() { return true; } - public boolean isTraceEnabled() { + public void info(String msg) { + SysPrint(msg); + } + + public void info(String format, Object arg) { + SysPrint(format, arg); + } + + public void info(String format, Object arg1, Object arg2) { + SysPrint(format, arg1, arg2); + } + + public void info(String format, Object[] argArray) { + SysPrint(format, argArray); + } + + public void info(String msg, Throwable t) { + SysPrint(msg, t); + } + + public boolean isInfoEnabled(Marker marker) { return true; } + public void info(Marker marker, String msg) { + SysPrint(marker, msg); + } + + public void info(Marker marker, String format, Object arg) { + SysPrint(marker, format, arg); + } + + public void info(Marker marker, String format, Object arg1, Object arg2) { + SysPrint(marker, format, arg1, arg2); + } + + public void info(Marker marker, String format, Object[] argArray) { + SysPrint(marker, format, argArray); + } + + public void info(Marker marker, String msg, Throwable t) { + SysPrint(marker, msg, t); + } + public boolean isWarnEnabled() { return true; } - public void trace(Object message) { - System.out.println(message); - + public void warn(String msg) { + SysPrint(msg); } - public void trace(Object message, Throwable t) { - System.out.println(message); - t.printStackTrace(); + public void warn(String format, Object arg) { + SysPrint(format, arg); } - public void warn(Object message) { - System.out.println(message); - + public void warn(String format, Object[] argArray) { + SysPrint(format, argArray); } - public void warn(Object message, Throwable t) { - System.out.println(message); - t.printStackTrace(); + public void warn(String format, Object arg1, Object arg2) { + SysPrint(format, arg1, arg2); } + public void warn(String msg, Throwable t) { + SysPrint(msg, t); + } + + public boolean isWarnEnabled(Marker marker) { + return true; + } + + public void warn(Marker marker, String msg) { + } + + public void warn(Marker marker, String format, Object arg) { + SysPrint(marker, format, arg); + } + + public void warn(Marker marker, String format, Object arg1, Object arg2) { + SysPrint(marker, format, arg1, arg2); + } + + public void warn(Marker marker, String format, Object[] argArray) { + SysPrint(marker, format, argArray); + } + + public void warn(Marker marker, String msg, Throwable t) { + SysPrint(marker, msg, t); + } + + public boolean isErrorEnabled() { + return true; + } + + public void error(String msg) { + SysPrint(msg); + } + + public void error(String format, Object arg) { + SysPrint(format, arg); + } + + public void error(String format, Object arg1, Object arg2) { + SysPrint(format, arg1, arg2); + } + + public void error(String format, Object[] argArray) { + SysPrint(format, argArray); + } + + public void error(String msg, Throwable t) { + SysPrint(msg, t); + } + + public boolean isErrorEnabled(Marker marker) { + return true; + } + + public void error(Marker marker, String msg) { + SysPrint(marker, msg); + } + + public void error(Marker marker, String format, Object arg) { + SysPrint(marker, format, arg); + } + + public void error(Marker marker, String format, Object arg1, Object arg2) { + SysPrint(marker, format, arg1, arg2); + } + + public void error(Marker marker, String format, Object[] argArray) { + SysPrint(marker, format, argArray); + } + + public void error(Marker marker, String msg, Throwable t) { + SysPrint(marker, msg, t); + } + + private void SysPrint(Marker marker, String msg, Object... obj) { + if (obj != null) { + Throwable t = null; + StringBuffer s = new StringBuffer("["); + s.append(marker.toString()).append("] ").append(msg); + s.append(" args=["); + boolean first = true; + for (Object o : obj) { + if (o instanceof Throwable) { + t = (Throwable) o; + } else { + if (first) { + s.append(o.toString()); + first = false; + } else { + s.append(", ").append(o.toString()); + } + } + } + System.out.println(s.toString()); + if (t != null) { + t.printStackTrace(); + } + } else { + System.out.println(msg); + } + } + + private void SysPrint(String msg, Object... obj) { + if (obj != null) { + Throwable t = null; + StringBuffer s = new StringBuffer(msg); + s.append(" args=["); + boolean first = true; + for (Object o : obj) { + if (o instanceof Throwable) { + t = (Throwable) o; + } else { + if (first) { + s.append(o.toString()); + first = false; + } else { + s.append(", ").append(o.toString()); + } + } + } + System.out.println(s.toString()); + if (t != null) { + t.printStackTrace(); + } + } else { + System.out.println(msg); + } + } + } Index: pom.xml =================================================================== --- pom.xml (revision 1074958) +++ pom.xml (working copy) @@ -62,8 +62,9 @@ ${javax.mail.artifactId} - commons-logging - commons-logging + org.slf4j + slf4j-api + 1.6.1 org.apache.james @@ -131,6 +132,7 @@ org.slf4j slf4j-log4j12 + 1.6.1 test