Index: ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsPublisher.java =================================================================== --- ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsPublisher.java (revision 1073447) +++ ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsPublisher.java (working copy) @@ -41,7 +41,10 @@ private final Log LOG = LogFactory.getLog(this.getClass().getName()); private PreparedStatement selStmt, updStmt, insStmt; private int timeout = 30; // default timeout in sec. for JDBC connection and statements + // SQL comment that identifies where the SQL statement comes from + private final String comment = "Hive stats publishing: " + this.getClass().getName(); + public JDBCStatsPublisher() { selStmt = updStmt = insStmt = null; } @@ -58,17 +61,17 @@ // prepare the SELECT/UPDATE/INSERT statements String select = - "SELECT " + JDBCStatsSetupConstants.PART_STAT_ROW_COUNT_COLUMN_NAME + + "SELECT /* " + comment + " */ " + JDBCStatsSetupConstants.PART_STAT_ROW_COUNT_COLUMN_NAME + " FROM " + JDBCStatsSetupConstants.PART_STAT_TABLE_NAME + " WHERE " + JDBCStatsSetupConstants.PART_STAT_ID_COLUMN_NAME + " = ?"; String update = - "UPDATE " + JDBCStatsSetupConstants.PART_STAT_TABLE_NAME + + "UPDATE /* " + comment + " */ "+ JDBCStatsSetupConstants.PART_STAT_TABLE_NAME + " SET " + JDBCStatsSetupConstants.PART_STAT_ROW_COUNT_COLUMN_NAME + "= ? " + " WHERE " + JDBCStatsSetupConstants.PART_STAT_ID_COLUMN_NAME + " = ?"; String insert = - "INSERT INTO " + JDBCStatsSetupConstants.PART_STAT_TABLE_NAME + + "INSERT INTO /* " + comment + " */ " + JDBCStatsSetupConstants.PART_STAT_TABLE_NAME + " VALUES (?, ?)"; selStmt = conn.prepareStatement(select); Index: ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsAggregator.java =================================================================== --- ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsAggregator.java (revision 1073447) +++ ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsAggregator.java (working copy) @@ -38,6 +38,7 @@ private Configuration hiveconf; private final Log LOG = LogFactory.getLog(this.getClass().getName()); private int timeout = 30; + private final String comment = "Hive stats aggregation: " + this.getClass().getName(); public boolean connect(Configuration hiveconf) { try { @@ -72,7 +73,8 @@ Statement stmt = conn.createStatement(); stmt.setQueryTimeout(timeout); String select = - "SELECT SUM" + "(" + JDBCStatsSetupConstants.PART_STAT_ROW_COUNT_COLUMN_NAME + ")" + + "SELECT /* " + comment + " */ " + + " SUM(" + JDBCStatsSetupConstants.PART_STAT_ROW_COUNT_COLUMN_NAME + ")" + " FROM " + JDBCStatsSetupConstants.PART_STAT_TABLE_NAME + " WHERE " + JDBCStatsSetupConstants.PART_STAT_ID_COLUMN_NAME + " LIKE '" + fileID + "%'"; @@ -94,7 +96,8 @@ through a separate method which the developer has to call it manually in the code. */ String delete = - "DELETE FROM " + JDBCStatsSetupConstants.PART_STAT_TABLE_NAME + + "DELETE /* " + comment + " */ " + + " FROM " + JDBCStatsSetupConstants.PART_STAT_TABLE_NAME + " WHERE " + JDBCStatsSetupConstants.PART_STAT_ID_COLUMN_NAME + " LIKE '" + fileID + "%'"; stmt.executeUpdate(delete); stmt.close(); @@ -138,7 +141,8 @@ Statement stmt = conn.createStatement(); String delete = - "DELETE FROM " + JDBCStatsSetupConstants.PART_STAT_TABLE_NAME + + "DELETE /* " + comment + " */ " + + " FROM " + JDBCStatsSetupConstants.PART_STAT_TABLE_NAME + " WHERE " + JDBCStatsSetupConstants.PART_STAT_ID_COLUMN_NAME + " LIKE '" + rowID + "%'"; stmt.executeUpdate(delete); stmt.close();