From 23add414648091e106c8be34cbda6a6d3d3279b4 Mon Sep 17 00:00:00 2001 From: paulgb Date: Thu, 2 Dec 2010 16:50:26 -0800 Subject: [PATCH] warning on drop nonexistant table --- .../org/apache/hadoop/hive/ql/exec/DDLTask.java | 1 + ql/src/test/queries/clientpositive/drop_warn.q | 7 +++++++ ql/src/test/results/clientpositive/drop_warn.q.out | 18 ++++++++++++++++++ 3 files changed, 26 insertions(+), 0 deletions(-) create mode 100644 ql/src/test/queries/clientpositive/drop_warn.q create mode 100644 ql/src/test/results/clientpositive/drop_warn.q.out diff --git a/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java b/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java index 7168884..7ba3823 100644 --- a/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java +++ b/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java @@ -2265,6 +2265,7 @@ public class DDLTask extends Task implements Serializable { try { tbl = db.getTable(dropTbl.getTableName()); } catch (InvalidTableException e) { + console.printError("Unknown table " + dropTbl.getTableName()); // drop table is idempotent } diff --git a/ql/src/test/queries/clientpositive/drop_warn.q b/ql/src/test/queries/clientpositive/drop_warn.q new file mode 100644 index 0000000..362c4fa --- /dev/null +++ b/ql/src/test/queries/clientpositive/drop_warn.q @@ -0,0 +1,7 @@ + +CREATE TABLE existant_table LIKE src; + +drop table existant_table; + +drop table nonexistant_table; + diff --git a/ql/src/test/results/clientpositive/drop_warn.q.out b/ql/src/test/results/clientpositive/drop_warn.q.out new file mode 100644 index 0000000..3a3cc88 --- /dev/null +++ b/ql/src/test/results/clientpositive/drop_warn.q.out @@ -0,0 +1,18 @@ +PREHOOK: query: CREATE TABLE existant_table LIKE src +PREHOOK: type: CREATETABLE +POSTHOOK: query: CREATE TABLE existant_table LIKE src +POSTHOOK: type: CREATETABLE +POSTHOOK: Output: default@existant_table +PREHOOK: query: drop table existant_table +PREHOOK: type: DROPTABLE +PREHOOK: Input: default@existant_table +PREHOOK: Output: default@existant_table +POSTHOOK: query: drop table existant_table +POSTHOOK: type: DROPTABLE +POSTHOOK: Input: default@existant_table +POSTHOOK: Output: default@existant_table +PREHOOK: query: drop table nonexistant_table +PREHOOK: type: DROPTABLE +Unknown table nonexistant_table +POSTHOOK: query: drop table nonexistant_table +POSTHOOK: type: DROPTABLE -- 1.6.6.5.g743753