commit dba02849f3809fa2af527333739e86b7fb7f68b0 Author: Todd Lipcon Date: Mon Jun 21 15:23:26 2010 -0700 HBASE-2764. Force all Chore threads to have a name diff --git src/main/java/org/apache/hadoop/hbase/Chore.java src/main/java/org/apache/hadoop/hbase/Chore.java index 5b425ff..25bf1a0 100644 --- src/main/java/org/apache/hadoop/hbase/Chore.java +++ src/main/java/org/apache/hadoop/hbase/Chore.java @@ -46,8 +46,8 @@ public abstract class Chore extends Thread { * @param s When this flag is set to true, this thread will cleanup and exit * cleanly. */ - public Chore(final int p, final AtomicBoolean s) { - super(); + public Chore(String name, final int p, final AtomicBoolean s) { + super(name); this.sleeper = new Sleeper(p, s); this.stop = s; } diff --git src/main/java/org/apache/hadoop/hbase/master/BaseScanner.java src/main/java/org/apache/hadoop/hbase/master/BaseScanner.java index 94f403e..ec1402a 100644 --- src/main/java/org/apache/hadoop/hbase/master/BaseScanner.java +++ src/main/java/org/apache/hadoop/hbase/master/BaseScanner.java @@ -132,7 +132,8 @@ abstract class BaseScanner extends Chore { BaseScanner(final HMaster master, final boolean rootRegion, final AtomicBoolean stop) { - super(master.getConfiguration(). + super("Scanner for " + (rootRegion ? "-ROOT-":".META.") + " table", + master.getConfiguration(). getInt("hbase.master.meta.thread.rescanfrequency", 60 * 1000), stop); this.rootRegion = rootRegion; this.master = master; diff --git src/main/java/org/apache/hadoop/hbase/master/OldLogsCleaner.java src/main/java/org/apache/hadoop/hbase/master/OldLogsCleaner.java index 372f588..07e69b4 100644 --- src/main/java/org/apache/hadoop/hbase/master/OldLogsCleaner.java +++ src/main/java/org/apache/hadoop/hbase/master/OldLogsCleaner.java @@ -61,7 +61,7 @@ public class OldLogsCleaner extends Chore { public OldLogsCleaner(final int p, final AtomicBoolean s, Configuration conf, FileSystem fs, Path oldLogDir) { - super(p, s); + super("OldLogsCleaner", p, s); this.maxDeletedLogs = conf.getInt("hbase.master.logcleaner.maxdeletedlogs", 20); this.fs = fs; diff --git src/main/java/org/apache/hadoop/hbase/master/ServerManager.java src/main/java/org/apache/hadoop/hbase/master/ServerManager.java index 819c9a7..94c167c 100644 --- src/main/java/org/apache/hadoop/hbase/master/ServerManager.java +++ src/main/java/org/apache/hadoop/hbase/master/ServerManager.java @@ -104,7 +104,7 @@ public class ServerManager { */ class ServerMonitor extends Chore { ServerMonitor(final int period, final AtomicBoolean stop) { - super(period, stop); + super("ServerMonitor", period, stop); } @Override diff --git src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java index 5091257..6570b66 100644 --- src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java +++ src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java @@ -867,7 +867,7 @@ public class HRegionServer implements HRegionInterface, MajorCompactionChecker(final HRegionServer h, final int sleepTime, final AtomicBoolean stopper) { - super(sleepTime, stopper); + super("MajorCompactionChecker", sleepTime, stopper); this.instance = h; LOG.info("Runs every " + sleepTime + "ms"); }