commit 73a95ba3532df93969999363953e13d04eda8a6f Author: Todd Lipcon Date: Wed Apr 14 13:12:50 2010 -0700 HBASE-2488. Add some warnings for unexpected events: - Add logging when a RS known to be dead reports - Duplicate assignment should be a warning diff --git src/java/org/apache/hadoop/hbase/master/ServerManager.java src/java/org/apache/hadoop/hbase/master/ServerManager.java index 6de6193..a7f907b 100644 --- src/java/org/apache/hadoop/hbase/master/ServerManager.java +++ src/java/org/apache/hadoop/hbase/master/ServerManager.java @@ -249,6 +249,8 @@ class ServerManager implements HConstants { throws IOException { HServerInfo info = new HServerInfo(serverInfo); if (isDead(info.getServerName())) { + LOG.info("Received report from region server " + info.getServerName() + + " previously marked dead. Rejecting report."); throw new Leases.LeaseStillHeldException(info.getServerName()); } if (msgs.length > 0) { @@ -582,10 +584,8 @@ class ServerManager implements HConstants { } if (duplicateAssignment) { - if (LOG.isDebugEnabled()) { - LOG.debug("region server " + serverInfo.getServerAddress().toString() - + " should not have opened region " + Bytes.toString(region.getRegionName())); - } + LOG.warn("region server " + serverInfo.getServerAddress().toString() + + " should not have opened region " + Bytes.toString(region.getRegionName())); // This Region should not have been opened. // Ask the server to shut it down, but don't report it as closed.