Index: metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java =================================================================== --- metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java (revision 4990) +++ metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java (working copy) @@ -171,6 +171,18 @@ assertTrue(ret); assertFalse(fs.exists(partPath)); + // Test append_partition_by_name + client.appendPartitionByName(dbName, tblName, partName); + Partition part4 = client.getPartition(dbName, tblName, part.getValues()); + assertTrue("Append partition by name failed", part4.getValues().equals(vals));; + Path part4Path = new Path(part4.getSd().getLocation()); + assertTrue(fs.exists(part4Path)); + + // Test drop_partition_by_name + assertTrue("Drop partition by name failed", + client.dropPartitionByName(dbName, tblName, partName, true)); + assertFalse(fs.exists(part4Path)); + // add the partition again so that drop table with a partition can be // tested retp = client.add_partition(part); @@ -191,15 +203,6 @@ client.dropPartition(dbName, tblName, part.getValues(), true); assertTrue(fs.exists(partPath)); - // Test append_partition_by_name - client.appendPartitionByName(dbName, tblName, partName); - Partition part4 = client.getPartition(dbName, tblName, part.getValues()); - assertTrue("Append partition by name failed", part4.getValues().equals(vals));; - - // Test drop_partition_by_name - assertTrue("Drop partition by name failed", - client.dropPartitionByName(dbName, tblName, partName, false)); - ret = client.dropDatabase(dbName); assertTrue("Unable to create the databse " + dbName, ret); Index: metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java =================================================================== --- metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java (revision 4990) +++ metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java (working copy) @@ -867,8 +867,8 @@ String part_name) throws InvalidObjectException, AlreadyExistsException, MetaException, TException { incrementCounter("append_partition_by_name"); - logStartFunction("append_partition_by_name: db=" + db_name + " tbl_name=" - + tbl_name + " part_name=" + part_name); + logStartFunction("append_partition_by_name: db=" + db_name + " tbl=" + + tbl_name + " part=" + part_name); List partVals = getPartValsFromName(db_name, tbl_name, part_name); return append_partition_common(db_name, tbl_name, partVals); @@ -880,7 +880,7 @@ MetaException, TException { incrementCounter("drop_partition_by_name"); logStartFunction("drop_partition_by_name: db=" + db_name + " tbl=" - + tbl_name + " part_name=" + part_name); + + tbl_name + " part=" + part_name); List partVals = null; try { @@ -889,7 +889,7 @@ throw new NoSuchObjectException(e.getMessage()); } - return getMS().dropPartition(db_name, tbl_name, partVals); + return drop_partition_common(db_name, tbl_name, partVals, deleteData); } }