Index: src/test/org/apache/lucene/analysis/TestCharArraySet.java =================================================================== --- src/test/org/apache/lucene/analysis/TestCharArraySet.java (revision 907200) +++ src/test/org/apache/lucene/analysis/TestCharArraySet.java (working copy) @@ -41,7 +41,7 @@ public void testRehash() throws Exception { - CharArraySet cas = new CharArraySet(Version.LUCENE_CURRENT, 0, true); + CharArraySet cas = new CharArraySet(TEST_VERSION_CURRENT, 0, true); for(int i=0;i would not hit any element of the CAS and therefor never call // remove() on the iterator try{ - set.removeAll(new CharArraySet(Version.LUCENE_CURRENT, Arrays.asList(TEST_STOP_WORDS), true)); + set.removeAll(new CharArraySet(TEST_VERSION_CURRENT, Arrays.asList(TEST_STOP_WORDS), true)); fail("Modified unmodifiable set"); }catch (UnsupportedOperationException e) { // expected @@ -158,7 +158,7 @@ } try{ - set.retainAll(new CharArraySet(Version.LUCENE_CURRENT, Arrays.asList(NOT_IN_SET), true)); + set.retainAll(new CharArraySet(TEST_VERSION_CURRENT, Arrays.asList(NOT_IN_SET), true)); fail("Modified unmodifiable set"); }catch (UnsupportedOperationException e) { // expected @@ -179,7 +179,7 @@ } public void testUnmodifiableSet(){ - CharArraySet set = new CharArraySet(Version.LUCENE_CURRENT, 10,true); + CharArraySet set = new CharArraySet(TEST_VERSION_CURRENT, 10,true); set.addAll(Arrays.asList(TEST_STOP_WORDS)); set.add(Integer.valueOf(1)); final int size = set.size(); @@ -209,7 +209,7 @@ "\ud801\udc1c\ud801\udc1cCDE", "A\ud801\udc1cB"}; String[] lowerArr = new String[] {"abc\ud801\udc44", "\ud801\udc44\ud801\udc44cde", "a\ud801\udc44b"}; - CharArraySet set = new CharArraySet(Version.LUCENE_31, Arrays.asList(TEST_STOP_WORDS), true); + CharArraySet set = new CharArraySet(TEST_VERSION_CURRENT, Arrays.asList(TEST_STOP_WORDS), true); for (String upper : upperArr) { set.add(upper); } @@ -217,7 +217,7 @@ assertTrue(String.format(missing, upperArr[i]), set.contains(upperArr[i])); assertTrue(String.format(missing, lowerArr[i]), set.contains(lowerArr[i])); } - set = new CharArraySet(Version.LUCENE_31, Arrays.asList(TEST_STOP_WORDS), false); + set = new CharArraySet(TEST_VERSION_CURRENT, Arrays.asList(TEST_STOP_WORDS), false); for (String upper : upperArr) { set.add(upper); } @@ -235,7 +235,7 @@ String[] lowerArr = new String[] { "abc\uD800", "abc\uD800efg", "\uD800efg", "\uD800\ud801\udc44b" }; - CharArraySet set = new CharArraySet(Version.LUCENE_31, Arrays + CharArraySet set = new CharArraySet(TEST_VERSION_CURRENT, Arrays .asList(TEST_STOP_WORDS), true); for (String upper : upperArr) { set.add(upper); @@ -244,7 +244,7 @@ assertTrue(String.format(missing, upperArr[i]), set.contains(upperArr[i])); assertTrue(String.format(missing, lowerArr[i]), set.contains(lowerArr[i])); } - set = new CharArraySet(Version.LUCENE_31, Arrays.asList(TEST_STOP_WORDS), + set = new CharArraySet(TEST_VERSION_CURRENT, Arrays.asList(TEST_STOP_WORDS), false); for (String upper : upperArr) { set.add(upper); @@ -328,8 +328,8 @@ } public void testCopyCharArraySetBWCompat() { - CharArraySet setIngoreCase = new CharArraySet(Version.LUCENE_CURRENT, 10, true); - CharArraySet setCaseSensitive = new CharArraySet(Version.LUCENE_CURRENT, 10, false); + CharArraySet setIngoreCase = new CharArraySet(TEST_VERSION_CURRENT, 10, true); + CharArraySet setCaseSensitive = new CharArraySet(TEST_VERSION_CURRENT, 10, false); List stopwords = Arrays.asList(TEST_STOP_WORDS); List stopwordsUpper = new ArrayList(); @@ -375,8 +375,8 @@ * Test the static #copy() function with a CharArraySet as a source */ public void testCopyCharArraySet() { - CharArraySet setIngoreCase = new CharArraySet(Version.LUCENE_CURRENT, 10, true); - CharArraySet setCaseSensitive = new CharArraySet(Version.LUCENE_CURRENT, 10, false); + CharArraySet setIngoreCase = new CharArraySet(TEST_VERSION_CURRENT, 10, true); + CharArraySet setCaseSensitive = new CharArraySet(TEST_VERSION_CURRENT, 10, false); List stopwords = Arrays.asList(TEST_STOP_WORDS); List stopwordsUpper = new ArrayList(); @@ -388,8 +388,8 @@ setCaseSensitive.addAll(Arrays.asList(TEST_STOP_WORDS)); setCaseSensitive.add(Integer.valueOf(1)); - CharArraySet copy = CharArraySet.copy(Version.LUCENE_CURRENT, setIngoreCase); - CharArraySet copyCaseSens = CharArraySet.copy(Version.LUCENE_CURRENT, setCaseSensitive); + CharArraySet copy = CharArraySet.copy(TEST_VERSION_CURRENT, setIngoreCase); + CharArraySet copyCaseSens = CharArraySet.copy(TEST_VERSION_CURRENT, setCaseSensitive); assertEquals(setIngoreCase.size(), copy.size()); assertEquals(setCaseSensitive.size(), copy.size()); @@ -431,7 +431,7 @@ } set.addAll(Arrays.asList(TEST_STOP_WORDS)); - CharArraySet copy = CharArraySet.copy(Version.LUCENE_CURRENT, set); + CharArraySet copy = CharArraySet.copy(TEST_VERSION_CURRENT, set); assertEquals(set.size(), copy.size()); assertEquals(set.size(), copy.size()); @@ -461,7 +461,7 @@ */ public void testCopyEmptySet() { assertSame(CharArraySet.EMPTY_SET, - CharArraySet.copy(Version.LUCENE_CURRENT, CharArraySet.EMPTY_SET)); + CharArraySet.copy(TEST_VERSION_CURRENT, CharArraySet.EMPTY_SET)); } /** @@ -483,7 +483,7 @@ * Test for NPE */ public void testContainsWithNull() { - CharArraySet set = new CharArraySet(Version.LUCENE_CURRENT, 1, true); + CharArraySet set = new CharArraySet(TEST_VERSION_CURRENT, 1, true); try { set.contains((char[]) null, 0, 10); fail("null value must raise NPE"); @@ -506,7 +506,7 @@ assertTrue("in 3.0 version, iterator should be CharArraySetIterator", ((Iterator) CharArraySet.copy(Version.LUCENE_30, hset).iterator()) instanceof CharArraySet.CharArraySetIterator); - CharArraySet set = CharArraySet.copy(Version.LUCENE_CURRENT, hset); + CharArraySet set = CharArraySet.copy(TEST_VERSION_CURRENT, hset); assertFalse("in current version, iterator should not be CharArraySetIterator", ((Iterator) set.iterator()) instanceof CharArraySet.CharArraySetIterator); @@ -525,7 +525,7 @@ } public void testToString() { - CharArraySet set = CharArraySet.copy(Version.LUCENE_CURRENT, Collections.singleton("test")); + CharArraySet set = CharArraySet.copy(TEST_VERSION_CURRENT, Collections.singleton("test")); assertEquals("[test]", set.toString()); set.add("test2"); assertTrue(set.toString().contains(", ")); Index: src/test/org/apache/lucene/util/LuceneTestCase.java =================================================================== --- src/test/org/apache/lucene/util/LuceneTestCase.java (revision 907200) +++ src/test/org/apache/lucene/util/LuceneTestCase.java (working copy) @@ -53,6 +53,8 @@ @Deprecated public abstract class LuceneTestCase extends TestCase { + public static final Version TEST_VERSION_CURRENT = LuceneTestCaseJ4.TEST_VERSION_CURRENT; + public LuceneTestCase() { super(); } Index: src/test/org/apache/lucene/util/LuceneTestCaseJ4.java =================================================================== --- src/test/org/apache/lucene/util/LuceneTestCaseJ4.java (revision 907200) +++ src/test/org/apache/lucene/util/LuceneTestCaseJ4.java (working copy) @@ -73,6 +73,9 @@ //@RunWith(RunBareWrapper.class) public class LuceneTestCaseJ4 extends TestWatchman { + /** Change this when development starts for new Lucene version: */ + public static final Version TEST_VERSION_CURRENT = Version.LUCENE_31; + // This is how we get control when errors occur. // Think of this as start/end/success/failed // events. @@ -226,7 +229,7 @@ */ public Random newRandom(long seed) { if (this.seed != null) { - throw new IllegalStateException("please call LuceneTestCase.newRandom only once per test"); + throw new IllegalStateException("please call LuceneTestCase4J.newRandom only once per test"); } this.seed = Long.valueOf(seed); return new Random(seed);