Index: src/test/org/apache/hadoop/hbase/regionserver/TestWideScanner.java =================================================================== --- src/test/org/apache/hadoop/hbase/regionserver/TestWideScanner.java (revision 895567) +++ src/test/org/apache/hadoop/hbase/regionserver/TestWideScanner.java (working copy) @@ -21,7 +21,7 @@ public class TestWideScanner extends HBaseTestCase { private final Log LOG = LogFactory.getLog(this.getClass()); - final int BATCH = 1000; + static final int BATCH = 1000; private MiniDFSCluster cluster = null; private HRegion r; Index: src/test/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java =================================================================== --- src/test/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java (revision 895567) +++ src/test/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java (working copy) @@ -193,7 +193,7 @@ public void testFindMemstoresWithEditsOlderThan() throws IOException { Map regionsToSeqids = new HashMap(); for (int i = 0; i < 10; i++) { - Long l = new Long(i); + Long l = Long.valueOf(i); regionsToSeqids.put(l.toString().getBytes(), l); } byte [][] regions = Index: src/test/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java =================================================================== --- src/test/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java (revision 895567) +++ src/test/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java (working copy) @@ -34,7 +34,7 @@ import org.apache.hadoop.hbase.util.Bytes; public class TestStoreScanner extends TestCase { - private final String CF_STR = "cf"; + private static final String CF_STR = "cf"; final byte [] CF = Bytes.toBytes(CF_STR); /** Index: src/test/org/apache/hadoop/hbase/regionserver/TestStoreReconstruction.java =================================================================== --- src/test/org/apache/hadoop/hbase/regionserver/TestStoreReconstruction.java (revision 895567) +++ src/test/org/apache/hadoop/hbase/regionserver/TestStoreReconstruction.java (working copy) @@ -40,8 +40,8 @@ private Path dir; private MiniDFSCluster cluster; - private final String TABLE = "testtable"; - private final int TOTAL_EDITS = 10000; + private static final String TABLE = "testtable"; + private static final int TOTAL_EDITS = 10000; private HBaseConfiguration conf; /** Index: src/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java =================================================================== --- src/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java (revision 895567) +++ src/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java (working copy) @@ -3666,7 +3666,7 @@ public Object getFieldValue(int fieldID) { switch (fieldID) { case SUCCESS: - return new Boolean(isSuccess()); + return Boolean.valueOf(isSuccess()); case IO: return getIo(); Index: src/java/org/apache/hadoop/hbase/regionserver/KeyValueHeap.java =================================================================== --- src/java/org/apache/hadoop/hbase/regionserver/KeyValueHeap.java (revision 895567) +++ src/java/org/apache/hadoop/hbase/regionserver/KeyValueHeap.java (working copy) @@ -130,7 +130,7 @@ return next(result, -1); } - private class KVScannerComparator implements Comparator { + private static class KVScannerComparator implements Comparator { private KVComparator kvComparator; /** * Constructor Index: src/java/org/apache/hadoop/hbase/client/Scan.java =================================================================== --- src/java/org/apache/hadoop/hbase/client/Scan.java (revision 895567) +++ src/java/org/apache/hadoop/hbase/client/Scan.java (working copy) @@ -595,26 +595,26 @@ * @deprecated */ public String getInputColumns() { - String cols = ""; + StringBuilder cols = new StringBuilder(""); for (Map.Entry> e : familyMap.entrySet()) { byte[] fam = e.getKey(); - if (cols.length() > 0) cols += " "; + if (cols.length() > 0) cols.append(" "); NavigableSet quals = e.getValue(); // check if this family has qualifiers if (quals != null && quals.size() > 0) { - String cs = ""; + StringBuilder cs = new StringBuilder(""); for (byte[] qual : quals) { - if (cs.length() > 0) cs += " "; + if (cs.length() > 0) cs.append(" "); // encode values to make parsing easier later - cs += Bytes.toStringBinary(fam) + ":" + Bytes.toStringBinary(qual); + cs.append(Bytes.toStringBinary(fam) + ":" + Bytes.toStringBinary(qual)); } - cols += cs; + cols.append(cs); } else { // only add the family but with old style delimiter - cols += Bytes.toStringBinary(fam) + ":"; + cols.append(Bytes.toStringBinary(fam) + ":"); } } - return cols; + return cols.toString(); } }