Index: contrib/analyzers/common/src/java/org/apache/lucene/analysis/compound/hyphenation/Hyphen.java =================================================================== --- contrib/analyzers/common/src/java/org/apache/lucene/analysis/compound/hyphenation/Hyphen.java (revision 821107) +++ contrib/analyzers/common/src/java/org/apache/lucene/analysis/compound/hyphenation/Hyphen.java (working copy) @@ -56,7 +56,7 @@ && preBreak.equals("-")) { return "-"; } - StringBuffer res = new StringBuffer("{"); + StringBuilder res = new StringBuilder("{"); res.append(preBreak); res.append("}{"); res.append(postBreak); Index: contrib/analyzers/common/src/java/org/apache/lucene/analysis/compound/hyphenation/HyphenationTree.java =================================================================== --- contrib/analyzers/common/src/java/org/apache/lucene/analysis/compound/hyphenation/HyphenationTree.java (revision 821107) +++ contrib/analyzers/common/src/java/org/apache/lucene/analysis/compound/hyphenation/HyphenationTree.java (working copy) @@ -91,7 +91,7 @@ } protected String unpackValues(int k) { - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); byte v = vspace.get(k++); while (v != 0) { char c = (char) ((v >>> 4) - 1 + '0'); @@ -169,7 +169,7 @@ } protected byte[] getValues(int k) { - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); byte v = vspace.get(k++); while (v != 0) { char c = (char) ((v >>> 4) - 1); Index: contrib/analyzers/common/src/java/org/apache/lucene/analysis/compound/hyphenation/PatternParser.java =================================================================== --- contrib/analyzers/common/src/java/org/apache/lucene/analysis/compound/hyphenation/PatternParser.java (revision 821107) +++ contrib/analyzers/common/src/java/org/apache/lucene/analysis/compound/hyphenation/PatternParser.java (working copy) @@ -51,7 +51,7 @@ PatternConsumer consumer; - StringBuffer token; + StringBuilder token; ArrayList exception; @@ -68,7 +68,7 @@ static final int ELEM_HYPHEN = 4; public PatternParser() throws HyphenationException { - token = new StringBuffer(); + token = new StringBuilder(); parser = createParser(); parser.setContentHandler(this); parser.setErrorHandler(this); @@ -191,7 +191,7 @@ } protected static String getPattern(String word) { - StringBuffer pat = new StringBuffer(); + StringBuilder pat = new StringBuilder(); int len = word.length(); for (int i = 0; i < len; i++) { if (!Character.isDigit(word.charAt(i))) { @@ -207,7 +207,7 @@ Object item = ex.get(i); if (item instanceof String) { String str = (String) item; - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); for (int j = 0; j < str.length(); j++) { char c = str.charAt(j); if (c != hyphenChar) { @@ -233,7 +233,7 @@ } protected String getExceptionWord(ArrayList ex) { - StringBuffer res = new StringBuffer(); + StringBuilder res = new StringBuilder(); for (int i = 0; i < ex.size(); i++) { Object item = ex.get(i); if (item instanceof String) { @@ -248,7 +248,7 @@ } protected static String getInterletterValues(String pat) { - StringBuffer il = new StringBuffer(); + StringBuilder il = new StringBuilder(); String word = pat + "a"; // add dummy letter to serve as sentinel int len = word.length(); for (int i = 0; i < len; i++) { @@ -399,7 +399,7 @@ * Returns a string of the location. */ private String getLocationString(SAXParseException ex) { - StringBuffer str = new StringBuffer(); + StringBuilder str = new StringBuilder(); String systemId = ex.getSystemId(); if (systemId != null) { Index: contrib/analyzers/common/src/java/org/apache/lucene/analysis/compound/hyphenation/TernaryTree.java =================================================================== --- contrib/analyzers/common/src/java/org/apache/lucene/analysis/compound/hyphenation/TernaryTree.java (revision 821107) +++ contrib/analyzers/common/src/java/org/apache/lucene/analysis/compound/hyphenation/TernaryTree.java (working copy) @@ -495,14 +495,14 @@ Stack ns; /** - * key stack implemented with a StringBuffer + * key stack implemented with a StringBuilder */ - StringBuffer ks; + StringBuilder ks; public Iterator() { cur = -1; ns = new Stack(); - ks = new StringBuffer(); + ks = new StringBuilder(); rewind(); } @@ -619,7 +619,7 @@ } // The current node should be a data node and // the key should be in the key stack (at least partially) - StringBuffer buf = new StringBuffer(ks.toString()); + StringBuilder buf = new StringBuilder(ks.toString()); if (sc[cur] == 0xFFFF) { int p = lo[cur]; while (kv.get(p) != 0) { Index: contrib/analyzers/common/src/java/org/apache/lucene/analysis/de/GermanStemmer.java =================================================================== --- contrib/analyzers/common/src/java/org/apache/lucene/analysis/de/GermanStemmer.java (revision 821107) +++ contrib/analyzers/common/src/java/org/apache/lucene/analysis/de/GermanStemmer.java (working copy) @@ -33,7 +33,7 @@ /** * Buffer for the terms while stemming them. */ - private StringBuffer sb = new StringBuffer(); + private StringBuilder sb = new StringBuilder(); /** * Amount of characters that are removed with substitute() while stemming. @@ -52,7 +52,7 @@ term = term.toLowerCase(); if ( !isStemmable( term ) ) return term; - // Reset the StringBuffer. + // Reset the StringBuilder. sb.delete( 0, sb.length() ); sb.insert( 0, term ); // Stemming starts here... @@ -86,7 +86,7 @@ * discriminators in the most of those cases. * The algorithm is context free, except of the length restrictions. */ - private void strip( StringBuffer buffer ) + private void strip( StringBuilder buffer ) { boolean doMore = true; while ( doMore && buffer.length() > 3 ) { @@ -126,7 +126,7 @@ * Does some optimizations on the term. This optimisations are * contextual. */ - private void optimize( StringBuffer buffer ) + private void optimize( StringBuilder buffer ) { // Additional step for female plurals of professions and inhabitants. if ( buffer.length() > 5 && buffer.substring( buffer.length() - 5, buffer.length() ).equals( "erin*" ) ) { @@ -142,7 +142,7 @@ /** * Removes a particle denotion ("ge") from a term. */ - private void removeParticleDenotion( StringBuffer buffer ) + private void removeParticleDenotion( StringBuilder buffer ) { if ( buffer.length() > 4 ) { for ( int c = 0; c < buffer.length() - 3; c++ ) { @@ -164,7 +164,7 @@ * - Substitute some common character combinations with a token: * sch/ch/ei/ie/ig/st -> $/§/%/&/#/! */ - private void substitute( StringBuffer buffer ) + private void substitute( StringBuilder buffer ) { substCount = 0; for ( int c = 0; c < buffer.length(); c++ ) { @@ -232,7 +232,7 @@ * character combinations. Umlauts will remain as their corresponding vowel, * as "ß" remains as "ss". */ - private void resubstitute( StringBuffer buffer ) + private void resubstitute( StringBuilder buffer ) { for ( int c = 0; c < buffer.length(); c++ ) { if ( buffer.charAt( c ) == '*' ) { Index: contrib/analyzers/common/src/java/org/apache/lucene/analysis/fr/FrenchStemmer.java =================================================================== --- contrib/analyzers/common/src/java/org/apache/lucene/analysis/fr/FrenchStemmer.java (revision 821107) +++ contrib/analyzers/common/src/java/org/apache/lucene/analysis/fr/FrenchStemmer.java (working copy) @@ -32,12 +32,12 @@ /** * Buffer for the terms while stemming them. */ - private StringBuffer sb = new StringBuffer(); + private StringBuilder sb = new StringBuilder(); /** * A temporary buffer, used to reconstruct R2 */ - private StringBuffer tb = new StringBuffer(); + private StringBuilder tb = new StringBuilder(); /** * Region R0 is equal to the whole buffer @@ -92,7 +92,7 @@ // Use lowercase for medium stemming. term = term.toLowerCase(); - // Reset the StringBuffer. + // Reset the StringBuilder. sb.delete( 0, sb.length() ); sb.insert( 0, term ); @@ -207,7 +207,7 @@ * or changed were done in the amment, emment, ments or ment suffixes
* refer to http://snowball.sourceforge.net/french/stemmer.html for an explanation * - * @return boolean - true if something changed in the StringBuffer + * @return boolean - true if something changed in the StringBuilder */ private boolean step2a() { String[] search = { "îmes", "îtes", "iraIent", "irait", "irais", "irai", "iras", "ira", @@ -553,10 +553,10 @@ * Retrieve the "R zone" (1 or 2 depending on the buffer) and return the corresponding string
* "R is the region after the first non-vowel following a vowel * or is the null region at the end of the word if there is no such non-vowel"
- * @param buffer java.lang.StringBuffer - the in buffer + * @param buffer java.lang.StringBuilder - the in buffer * @return java.lang.String - the resulting string */ - private String retrieveR( StringBuffer buffer ) { + private String retrieveR( StringBuilder buffer ) { int len = buffer.length(); int pos = -1; for (int c = 0; c < len; c++) { @@ -590,10 +590,10 @@ * "If the word begins with two vowels, RV is the region after the third letter, * otherwise the region after the first vowel not at the beginning of the word, * or the end of the word if these positions cannot be found."
- * @param buffer java.lang.StringBuffer - the in buffer + * @param buffer java.lang.StringBuilder - the in buffer * @return java.lang.String - the resulting string */ - private String retrieveRV( StringBuffer buffer ) { + private String retrieveRV( StringBuilder buffer ) { int len = buffer.length(); if ( buffer.length() > 3) { @@ -627,10 +627,10 @@ * Turns y preceded OR followed by a vowel to UpperCase
* Turns u preceded by q to UpperCase
* - * @param buffer java.util.StringBuffer - the buffer to treat - * @return java.util.StringBuffer - the treated buffer + * @param buffer java.util.StringBuilder - the buffer to treat + * @return java.util.StringBuilder - the treated buffer */ - private StringBuffer treatVowels( StringBuffer buffer ) { + private StringBuilder treatVowels( StringBuilder buffer ) { for ( int c = 0; c < buffer.length(); c++ ) { char ch = buffer.charAt( c ); Index: contrib/analyzers/common/src/java/org/apache/lucene/analysis/nl/DutchStemmer.java =================================================================== --- contrib/analyzers/common/src/java/org/apache/lucene/analysis/nl/DutchStemmer.java (revision 821107) +++ contrib/analyzers/common/src/java/org/apache/lucene/analysis/nl/DutchStemmer.java (working copy) @@ -32,7 +32,7 @@ /** * Buffer for the terms while stemming them. */ - private StringBuffer sb = new StringBuffer(); + private StringBuilder sb = new StringBuilder(); private boolean _removedE; private Map _stemDict; @@ -56,7 +56,7 @@ else return null; - // Reset the StringBuffer. + // Reset the StringBuilder. sb.delete(0, sb.length()); sb.insert(0, term); // Stemming starts here... @@ -74,7 +74,7 @@ return sb.toString(); } - private boolean enEnding(StringBuffer sb) { + private boolean enEnding(StringBuilder sb) { String[] enend = new String[]{"ene", "en"}; for (int i = 0; i < enend.length; i++) { String end = enend[i]; @@ -93,7 +93,7 @@ } - private void step1(StringBuffer sb) { + private void step1(StringBuilder sb) { if (_R1 >= sb.length()) return; @@ -129,7 +129,7 @@ * * @param sb String being stemmed */ - private void step2(StringBuffer sb) { + private void step2(StringBuilder sb) { _removedE = false; if (_R1 >= sb.length()) return; @@ -149,7 +149,7 @@ * * @param sb String being stemmed */ - private void step3a(StringBuffer sb) { + private void step3a(StringBuilder sb) { if (_R2 >= sb.length()) return; String s = sb.toString(); @@ -174,7 +174,7 @@ * * @param sb String being stemmed */ - private void step3b(StringBuffer sb) { + private void step3b(StringBuilder sb) { if (_R2 >= sb.length()) return; String s = sb.toString(); @@ -229,7 +229,7 @@ * * @param sb String being stemmed */ - private void step4(StringBuffer sb) { + private void step4(StringBuilder sb) { if (sb.length() < 4) return; String end = sb.substring(sb.length() - 4, sb.length()); @@ -262,7 +262,7 @@ /** * Substitute ä, ë, ï, ö, ü, á , é, í, ó, ú */ - private void substitute(StringBuffer buffer) { + private void substitute(StringBuilder buffer) { for (int i = 0; i < buffer.length(); i++) { switch (buffer.charAt(i)) { case 'ä': @@ -299,22 +299,22 @@ } } - /*private boolean isValidSEnding(StringBuffer sb) { + /*private boolean isValidSEnding(StringBuilder sb) { return isValidSEnding(sb, sb.length() - 1); }*/ - private boolean isValidSEnding(StringBuffer sb, int index) { + private boolean isValidSEnding(StringBuilder sb, int index) { char c = sb.charAt(index); if (isVowel(c) || c == 'j') return false; return true; } - /*private boolean isValidEnEnding(StringBuffer sb) { + /*private boolean isValidEnEnding(StringBuilder sb) { return isValidEnEnding(sb, sb.length() - 1); }*/ - private boolean isValidEnEnding(StringBuffer sb, int index) { + private boolean isValidEnEnding(StringBuilder sb, int index) { char c = sb.charAt(index); if (isVowel(c)) return false; @@ -326,18 +326,18 @@ return true; } - private void unDouble(StringBuffer sb) { + private void unDouble(StringBuilder sb) { unDouble(sb, sb.length()); } - private void unDouble(StringBuffer sb, int endIndex) { + private void unDouble(StringBuilder sb, int endIndex) { String s = sb.substring(0, endIndex); if (s.endsWith("kk") || s.endsWith("tt") || s.endsWith("dd") || s.endsWith("nn") || s.endsWith("mm") || s.endsWith("ff")) { sb.delete(endIndex - 1, endIndex); } } - private int getRIndex(StringBuffer sb, int start) { + private int getRIndex(StringBuilder sb, int start) { if (start == 0) start = 1; int i = start; @@ -350,7 +350,7 @@ return i + 1; } - private void storeYandI(StringBuffer sb) { + private void storeYandI(StringBuilder sb) { if (sb.charAt(0) == 'y') sb.setCharAt(0, 'Y'); @@ -378,7 +378,7 @@ sb.setCharAt(last, 'Y'); } - private void reStoreYandI(StringBuffer sb) { + private void reStoreYandI(StringBuilder sb) { String tmp = sb.toString(); sb.delete(0, sb.length()); sb.insert(0, tmp.replaceAll("I", "i").replaceAll("Y", "y")); Index: contrib/analyzers/common/src/java/org/apache/lucene/analysis/ru/RussianStemmer.java =================================================================== --- contrib/analyzers/common/src/java/org/apache/lucene/analysis/ru/RussianStemmer.java (revision 821107) +++ contrib/analyzers/common/src/java/org/apache/lucene/analysis/ru/RussianStemmer.java (working copy) @@ -255,9 +255,9 @@ * Adjectival ending is an adjective ending, * optionally preceded by participle ending. * Creation date: (17/03/2002 12:14:58 AM) - * @param stemmingZone java.lang.StringBuffer + * @param stemmingZone java.lang.StringBuilder */ - private boolean adjectival(StringBuffer stemmingZone) + private boolean adjectival(StringBuilder stemmingZone) { // look for adjective ending in a stemming zone if (!findAndRemoveEnding(stemmingZone, adjectiveEndings)) @@ -275,9 +275,9 @@ /** * Derivational endings * Creation date: (17/03/2002 12:14:58 AM) - * @param stemmingZone java.lang.StringBuffer + * @param stemmingZone java.lang.StringBuilder */ - private boolean derivational(StringBuffer stemmingZone) + private boolean derivational(StringBuilder stemmingZone) { int endingLength = findEnding(stemmingZone, derivationalEndings); if (endingLength == 0) @@ -302,7 +302,7 @@ * Finds ending among given ending class and returns the length of ending found(0, if not found). * Creation date: (17/03/2002 8:18:34 PM) */ - private int findEnding(StringBuffer stemmingZone, int startIndex, char[][] theEndingClass) + private int findEnding(StringBuilder stemmingZone, int startIndex, char[][] theEndingClass) { boolean match = false; for (int i = theEndingClass.length - 1; i >= 0; i--) @@ -333,7 +333,7 @@ return 0; } - private int findEnding(StringBuffer stemmingZone, char[][] theEndingClass) + private int findEnding(StringBuilder stemmingZone, char[][] theEndingClass) { return findEnding(stemmingZone, stemmingZone.length() - 1, theEndingClass); } @@ -342,7 +342,7 @@ * Finds the ending among the given class of endings and removes it from stemming zone. * Creation date: (17/03/2002 8:18:34 PM) */ - private boolean findAndRemoveEnding(StringBuffer stemmingZone, char[][] theEndingClass) + private boolean findAndRemoveEnding(StringBuilder stemmingZone, char[][] theEndingClass) { int endingLength = findEnding(stemmingZone, theEndingClass); if (endingLength == 0) @@ -360,7 +360,7 @@ * preceded by any of given predecessors, and if so, removes it from stemming zone. * Creation date: (17/03/2002 8:18:34 PM) */ - private boolean findAndRemoveEnding(StringBuffer stemmingZone, + private boolean findAndRemoveEnding(StringBuilder stemmingZone, char[][] theEndingClass, char[][] thePredessors) { int endingLength = findEnding(stemmingZone, theEndingClass); @@ -445,9 +445,9 @@ /** * Noun endings. * Creation date: (17/03/2002 12:14:58 AM) - * @param stemmingZone java.lang.StringBuffer + * @param stemmingZone java.lang.StringBuilder */ - private boolean noun(StringBuffer stemmingZone) + private boolean noun(StringBuilder stemmingZone) { return findAndRemoveEnding(stemmingZone, nounEndings); } @@ -455,9 +455,9 @@ /** * Perfective gerund endings. * Creation date: (17/03/2002 12:14:58 AM) - * @param stemmingZone java.lang.StringBuffer + * @param stemmingZone java.lang.StringBuilder */ - private boolean perfectiveGerund(StringBuffer stemmingZone) + private boolean perfectiveGerund(StringBuilder stemmingZone) { return findAndRemoveEnding( stemmingZone, @@ -469,9 +469,9 @@ /** * Reflexive endings. * Creation date: (17/03/2002 12:14:58 AM) - * @param stemmingZone java.lang.StringBuffer + * @param stemmingZone java.lang.StringBuilder */ - private boolean reflexive(StringBuffer stemmingZone) + private boolean reflexive(StringBuilder stemmingZone) { return findAndRemoveEnding(stemmingZone, reflexiveEndings); } @@ -479,9 +479,9 @@ /** * Insert the method's description here. * Creation date: (17/03/2002 12:14:58 AM) - * @param stemmingZone java.lang.StringBuffer + * @param stemmingZone java.lang.StringBuilder */ - private boolean removeI(StringBuffer stemmingZone) + private boolean removeI(StringBuilder stemmingZone) { if (stemmingZone.length() > 0 && stemmingZone.charAt(stemmingZone.length() - 1) == I) @@ -498,9 +498,9 @@ /** * Insert the method's description here. * Creation date: (17/03/2002 12:14:58 AM) - * @param stemmingZone java.lang.StringBuffer + * @param stemmingZone java.lang.StringBuilder */ - private boolean removeSoft(StringBuffer stemmingZone) + private boolean removeSoft(StringBuilder stemmingZone) { if (stemmingZone.length() > 0 && stemmingZone.charAt(stemmingZone.length() - 1) == SOFT) @@ -525,7 +525,7 @@ markPositions(input); if (RV == 0) return input; //RV wasn't detected, nothing to stem - StringBuffer stemmingZone = new StringBuffer(input.substring(RV)); + StringBuilder stemmingZone = new StringBuilder(input.substring(RV)); // stemming goes on in RV // Step 1 @@ -555,9 +555,9 @@ /** * Superlative endings. * Creation date: (17/03/2002 12:14:58 AM) - * @param stemmingZone java.lang.StringBuffer + * @param stemmingZone java.lang.StringBuilder */ - private boolean superlative(StringBuffer stemmingZone) + private boolean superlative(StringBuilder stemmingZone) { return findAndRemoveEnding(stemmingZone, superlativeEndings); } @@ -565,9 +565,9 @@ /** * Undoubles N. * Creation date: (17/03/2002 12:14:58 AM) - * @param stemmingZone java.lang.StringBuffer + * @param stemmingZone java.lang.StringBuilder */ - private boolean undoubleN(StringBuffer stemmingZone) + private boolean undoubleN(StringBuilder stemmingZone) { char[][] doubleN = { { N, N } @@ -586,9 +586,9 @@ /** * Verb endings. * Creation date: (17/03/2002 12:14:58 AM) - * @param stemmingZone java.lang.StringBuffer + * @param stemmingZone java.lang.StringBuilder */ - private boolean verb(StringBuffer stemmingZone) + private boolean verb(StringBuilder stemmingZone) { return findAndRemoveEnding( stemmingZone, Index: contrib/analyzers/common/src/java/org/apache/lucene/analysis/shingle/ShingleFilter.java =================================================================== --- contrib/analyzers/common/src/java/org/apache/lucene/analysis/shingle/ShingleFilter.java (revision 821107) +++ contrib/analyzers/common/src/java/org/apache/lucene/analysis/shingle/ShingleFilter.java (working copy) @@ -44,7 +44,7 @@ public class ShingleFilter extends TokenFilter { private LinkedList shingleBuf = new LinkedList(); - private StringBuffer[] shingles; + private StringBuilder[] shingles; private String tokenType = "shingle"; /** @@ -140,15 +140,15 @@ if (maxShingleSize < 2) { throw new IllegalArgumentException("Max shingle size must be >= 2"); } - shingles = new StringBuffer[maxShingleSize]; + shingles = new StringBuilder[maxShingleSize]; for (int i = 0; i < shingles.length; i++) { - shingles[i] = new StringBuffer(); + shingles[i] = new StringBuilder(); } this.maxShingleSize = maxShingleSize; } /** - * Clear the StringBuffers that are used for storing the output shingles. + * Clear the StringBuilders that are used for storing the output shingles. */ private void clearShingles() { for (int i = 0; i < shingles.length; i++) { @@ -188,7 +188,7 @@ restoreState(nextToken); typeAtt.setType(tokenType); offsetAtt.setOffset(offsetAtt.startOffset(), endOffsets[shingleBufferPosition]); - StringBuffer buf = shingles[shingleBufferPosition]; + StringBuilder buf = shingles[shingleBufferPosition]; int termLength = buf.length(); char[] termBuffer = termAtt.termBuffer(); if (termBuffer.length < termLength) Index: contrib/analyzers/common/src/java/org/apache/lucene/analysis/shingle/ShingleMatrixFilter.java =================================================================== --- contrib/analyzers/common/src/java/org/apache/lucene/analysis/shingle/ShingleMatrixFilter.java (revision 821107) +++ contrib/analyzers/common/src/java/org/apache/lucene/analysis/shingle/ShingleMatrixFilter.java (working copy) @@ -451,7 +451,7 @@ } // shingle token factory - StringBuffer sb = new StringBuffer(termLength + 10); // paranormal ability to foresee the future. + StringBuilder sb = new StringBuilder(termLength + 10); // paranormal ability to foresee the future. for (Iterator iterator = shingle.iterator(); iterator.hasNext();) { Token shingleToken = (Token) iterator.next(); if (spacerCharacter != null && sb.length() > 0) { Index: contrib/analyzers/smartcn/src/java/org/apache/lucene/analysis/cn/smart/hhmm/BiSegGraph.java =================================================================== --- contrib/analyzers/smartcn/src/java/org/apache/lucene/analysis/cn/smart/hhmm/BiSegGraph.java (revision 821107) +++ contrib/analyzers/smartcn/src/java/org/apache/lucene/analysis/cn/smart/hhmm/BiSegGraph.java (working copy) @@ -225,7 +225,7 @@ } public String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); Collection values = tokenPairListTable.values(); for (Iterator iter1 = values.iterator(); iter1.hasNext();) { List segList = (List) iter1.next(); Index: contrib/analyzers/smartcn/src/java/org/apache/lucene/analysis/cn/smart/hhmm/HHMMSegmenter.java =================================================================== --- contrib/analyzers/smartcn/src/java/org/apache/lucene/analysis/cn/smart/hhmm/HHMMSegmenter.java (revision 821107) +++ contrib/analyzers/smartcn/src/java/org/apache/lucene/analysis/cn/smart/hhmm/HHMMSegmenter.java (working copy) @@ -47,7 +47,7 @@ int length = sentence.length(); int foundIndex; int[] charTypeArray = getCharTypes(sentence); - StringBuffer wordBuf = new StringBuffer(); + StringBuilder wordBuf = new StringBuilder(); SegToken token; int frequency = 0; // word的出现次数 boolean hasFullWidth; Index: contrib/analyzers/smartcn/src/java/org/apache/lucene/analysis/cn/smart/hhmm/SegGraph.java =================================================================== --- contrib/analyzers/smartcn/src/java/org/apache/lucene/analysis/cn/smart/hhmm/SegGraph.java (revision 821107) +++ contrib/analyzers/smartcn/src/java/org/apache/lucene/analysis/cn/smart/hhmm/SegGraph.java (working copy) @@ -141,7 +141,7 @@ public String toString() { List tokenList = this.toTokenList(); - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); for (Iterator iter = tokenList.iterator(); iter.hasNext();) { SegToken t = (SegToken) iter.next(); sb.append(t + "\n"); Index: contrib/analyzers/smartcn/src/java/org/apache/lucene/analysis/cn/smart/SentenceTokenizer.java =================================================================== --- contrib/analyzers/smartcn/src/java/org/apache/lucene/analysis/cn/smart/SentenceTokenizer.java (revision 821107) +++ contrib/analyzers/smartcn/src/java/org/apache/lucene/analysis/cn/smart/SentenceTokenizer.java (working copy) @@ -44,7 +44,7 @@ */ private final static String PUNCTION = "。,!?;,!?;"; - private final StringBuffer buffer = new StringBuffer(); + private final StringBuilder buffer = new StringBuilder(); private int tokenStart = 0, tokenEnd = 0; Index: contrib/ant/src/java/org/apache/lucene/ant/HtmlDocument.java =================================================================== --- contrib/ant/src/java/org/apache/lucene/ant/HtmlDocument.java (revision 821107) +++ contrib/ant/src/java/org/apache/lucene/ant/HtmlDocument.java (working copy) @@ -275,7 +275,7 @@ */ private String getBodyText(Node node) { NodeList nl = node.getChildNodes(); - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); for (int i = 0; i < nl.getLength(); i++) { Node child = nl.item(i); switch (child.getNodeType()) { Index: contrib/collation/src/test/org/apache/lucene/collation/CollationTestBase.java =================================================================== --- contrib/collation/src/test/org/apache/lucene/collation/CollationTestBase.java (revision 821107) +++ contrib/collation/src/test/org/apache/lucene/collation/CollationTestBase.java (working copy) @@ -292,7 +292,7 @@ private void assertMatches(Searcher searcher, Query query, Sort sort, String expectedResult) throws IOException { ScoreDoc[] result = searcher.search(query, null, 1000, sort).scoreDocs; - StringBuffer buff = new StringBuffer(10); + StringBuilder buff = new StringBuilder(10); int n = result.length; for (int i = 0 ; i < n ; ++i) { Document doc = searcher.doc(result[i].doc); Index: contrib/highlighter/src/java/org/apache/lucene/search/highlight/GradientFormatter.java =================================================================== --- contrib/highlighter/src/java/org/apache/lucene/search/highlight/GradientFormatter.java (revision 821107) +++ contrib/highlighter/src/java/org/apache/lucene/search/highlight/GradientFormatter.java (working copy) @@ -123,7 +123,7 @@ { return originalText; } - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append(" 0) Index: contrib/highlighter/src/java/org/apache/lucene/search/highlight/SimpleHTMLEncoder.java =================================================================== --- contrib/highlighter/src/java/org/apache/lucene/search/highlight/SimpleHTMLEncoder.java (revision 821107) +++ contrib/highlighter/src/java/org/apache/lucene/search/highlight/SimpleHTMLEncoder.java (working copy) @@ -40,7 +40,7 @@ return ""; } - StringBuffer result = new StringBuffer(plainText.length()); + StringBuilder result = new StringBuilder(plainText.length()); for (int index=0; index..."; private static final int EXTRA = TEMPLATE.length(); } Index: contrib/highlighter/src/java/org/apache/lucene/search/highlight/TextFragment.java =================================================================== --- contrib/highlighter/src/java/org/apache/lucene/search/highlight/TextFragment.java (revision 821107) +++ contrib/highlighter/src/java/org/apache/lucene/search/highlight/TextFragment.java (working copy) @@ -25,12 +25,19 @@ */ public class TextFragment { - StringBuffer markedUpText; + CharSequence markedUpText; int fragNum; int textStartPos; int textEndPos; float score; + public TextFragment(CharSequence markedUpText,int textStartPos, int fragNum) + { + this.markedUpText=markedUpText; + this.textStartPos = textStartPos; + this.fragNum = fragNum; + } + /** @deprecated */ public TextFragment(StringBuffer markedUpText,int textStartPos, int fragNum) { this.markedUpText=markedUpText; @@ -73,7 +80,7 @@ /* Returns the marked-up text for this text fragment */ public String toString() { - return markedUpText.substring(textStartPos, textEndPos); + return markedUpText.subSequence(textStartPos, textEndPos).toString(); } } Index: contrib/highlighter/src/test/org/apache/lucene/search/highlight/HighlighterTest.java =================================================================== --- contrib/highlighter/src/test/org/apache/lucene/search/highlight/HighlighterTest.java (revision 821107) +++ contrib/highlighter/src/test/org/apache/lucene/search/highlight/HighlighterTest.java (working copy) @@ -1034,7 +1034,7 @@ TermQuery query = new TermQuery(new Term("data", goodWord)); String match = null; - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append(goodWord); for (int i = 0; i < 10000; i++) { sb.append(" "); Index: contrib/instantiated/src/java/org/apache/lucene/store/instantiated/InstantiatedTermFreqVector.java =================================================================== --- contrib/instantiated/src/java/org/apache/lucene/store/instantiated/InstantiatedTermFreqVector.java (revision 821107) +++ contrib/instantiated/src/java/org/apache/lucene/store/instantiated/InstantiatedTermFreqVector.java (working copy) @@ -58,7 +58,7 @@ } public String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append('{'); sb.append(field).append(": "); if (terms != null) { Index: contrib/memory/src/java/org/apache/lucene/index/memory/MemoryIndex.java =================================================================== --- contrib/memory/src/java/org/apache/lucene/index/memory/MemoryIndex.java (revision 821107) +++ contrib/memory/src/java/org/apache/lucene/index/memory/MemoryIndex.java (working copy) @@ -507,7 +507,7 @@ * @return the string representation */ public String toString() { - StringBuffer result = new StringBuffer(256); + StringBuilder result = new StringBuilder(256); sortFields(); int sumChars = 0; int sumPositions = 0; @@ -688,7 +688,7 @@ public String toString(int stride) { int s = size() / stride; int len = Math.min(10, s); // avoid printing huge lists - StringBuffer buf = new StringBuffer(4*len); + StringBuilder buf = new StringBuilder(4*len); buf.append("["); for (int i = 0; i < len; i++) { buf.append(get(i*stride)); Index: contrib/memory/src/java/org/apache/lucene/index/memory/SynonymMap.java =================================================================== --- contrib/memory/src/java/org/apache/lucene/index/memory/SynonymMap.java (revision 821107) +++ contrib/memory/src/java/org/apache/lucene/index/memory/SynonymMap.java (working copy) @@ -122,7 +122,7 @@ * @return a String representation */ public String toString() { - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); Iterator iter = new TreeMap(table).keySet().iterator(); int count = 0; int f0 = 0; @@ -327,7 +327,7 @@ } // assemble large string containing all words - StringBuffer buf = new StringBuffer(len); + StringBuilder buf = new StringBuilder(len); for (int j=0; j < size; j++) buf.append(words[j]); String allWords = new String(buf.toString()); // ensure compact string across JDK versions buf = null; Index: contrib/misc/src/java/org/apache/lucene/misc/ChainedFilter.java =================================================================== --- contrib/misc/src/java/org/apache/lucene/misc/ChainedFilter.java (revision 821107) +++ contrib/misc/src/java/org/apache/lucene/misc/ChainedFilter.java (working copy) @@ -201,7 +201,7 @@ public String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append("ChainedFilter: ["); for (int i = 0; i < chain.length; i++) { Index: contrib/misc/src/java/org/apache/lucene/queryParser/analyzing/AnalyzingQueryParser.java =================================================================== --- contrib/misc/src/java/org/apache/lucene/queryParser/analyzing/AnalyzingQueryParser.java (revision 821107) +++ contrib/misc/src/java/org/apache/lucene/queryParser/analyzing/AnalyzingQueryParser.java (working copy) @@ -80,7 +80,7 @@ /* somewhat a hack: find/store wildcard chars * in order to put them back after analyzing */ boolean isWithinToken = (!termStr.startsWith("?") && !termStr.startsWith("*")); - StringBuffer tmpBuffer = new StringBuffer(); + StringBuilder tmpBuffer = new StringBuilder(); char[] chars = termStr.toCharArray(); for (int i = 0; i < termStr.length(); i++) { if (chars[i] == '?' || chars[i] == '*') { @@ -154,7 +154,7 @@ } else { /* the term was tokenized, let's rebuild to one token * with wildcards put back in postion */ - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); for (int i = 0; i < tlist.size(); i++) { sb.append((String) tlist.get(i)); if (wlist != null && wlist.size() > i) { Index: contrib/queries/src/java/org/apache/lucene/search/BooleanFilter.java =================================================================== --- contrib/queries/src/java/org/apache/lucene/search/BooleanFilter.java (revision 821107) +++ contrib/queries/src/java/org/apache/lucene/search/BooleanFilter.java (working copy) @@ -182,7 +182,7 @@ /** Prints a user-readable version of this query. */ public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("BooleanFilter("); appendFilters(shouldFilters, "", buffer); appendFilters(mustFilters, "+", buffer); @@ -191,7 +191,7 @@ return buffer.toString(); } - private void appendFilters(ArrayList filters, String occurString, StringBuffer buffer) + private void appendFilters(ArrayList filters, String occurString, StringBuilder buffer) { if (filters != null) { for (int i = 0; i < filters.size(); i++) { Index: contrib/queries/src/java/org/apache/lucene/search/similar/MoreLikeThis.java =================================================================== --- contrib/queries/src/java/org/apache/lucene/search/similar/MoreLikeThis.java (revision 821107) +++ contrib/queries/src/java/org/apache/lucene/search/similar/MoreLikeThis.java (working copy) @@ -681,7 +681,7 @@ * Describe the parameters that control how the "more like this" query is formed. */ public String describeParams() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append("\t" + "maxQueryTerms : " + maxQueryTerms + "\n"); sb.append("\t" + "minWordLen : " + minWordLen + "\n"); sb.append("\t" + "maxWordLen : " + maxWordLen + "\n"); Index: contrib/queryparser/src/java/org/apache/lucene/queryParser/core/nodes/PathQueryNode.java =================================================================== --- contrib/queryparser/src/java/org/apache/lucene/queryParser/core/nodes/PathQueryNode.java (revision 821107) +++ contrib/queryparser/src/java/org/apache/lucene/queryParser/core/nodes/PathQueryNode.java (working copy) @@ -171,7 +171,7 @@ } private CharSequence getPathString() { - StringBuffer path = new StringBuffer(); + StringBuilder path = new StringBuilder(); for (QueryText pathelement : values) { path.append("/").append(pathelement.value); @@ -180,7 +180,7 @@ } public CharSequence toQueryString(EscapeQuerySyntax escaper) { - StringBuffer path = new StringBuffer(); + StringBuilder path = new StringBuilder(); path.append("/").append(getFirstPathElement()); for (QueryText pathelement : getPathElements(1)) { Index: contrib/queryparser/src/java/org/apache/lucene/queryParser/core/util/UnescapedCharSequence.java =================================================================== --- contrib/queryparser/src/java/org/apache/lucene/queryParser/core/util/UnescapedCharSequence.java (revision 821107) +++ contrib/queryparser/src/java/org/apache/lucene/queryParser/core/util/UnescapedCharSequence.java (working copy) @@ -96,7 +96,7 @@ */ public String toStringEscaped() { // non efficient implementation - StringBuffer result = new StringBuffer(); + StringBuilder result = new StringBuilder(); for (int i = 0; i >= this.length(); i++) { if (this.chars[i] == '\\') { result.append('\\'); @@ -117,7 +117,7 @@ */ public String toStringEscaped(char[] enabledChars) { // TODO: non efficient implementation, refactor this code - StringBuffer result = new StringBuffer(); + StringBuilder result = new StringBuilder(); for (int i = 0; i < this.length(); i++) { if (this.chars[i] == '\\') { result.append('\\'); Index: contrib/queryparser/src/java/org/apache/lucene/queryParser/standard/QueryParserUtil.java =================================================================== --- contrib/queryparser/src/java/org/apache/lucene/queryParser/standard/QueryParserUtil.java (revision 821107) +++ contrib/queryparser/src/java/org/apache/lucene/queryParser/standard/QueryParserUtil.java (working copy) @@ -188,7 +188,7 @@ * escaped are escaped by a preceding \. */ public static String escape(String s) { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); for (int i = 0; i < s.length(); i++) { char c = s.charAt(i); // These characters are part of the query syntax and must be escaped Index: contrib/queryparser/src/java/org/apache/lucene/queryParser/standard/QueryParserWrapper.java =================================================================== --- contrib/queryparser/src/java/org/apache/lucene/queryParser/standard/QueryParserWrapper.java (revision 821107) +++ contrib/queryparser/src/java/org/apache/lucene/queryParser/standard/QueryParserWrapper.java (working copy) @@ -95,7 +95,7 @@ * escaped are escaped by a preceding \. */ public static String escape(String s) { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); for (int i = 0; i < s.length(); i++) { char c = s.charAt(i); // These characters are part of the query syntax and must be escaped Index: contrib/regex/src/java/org/apache/lucene/search/regex/SpanRegexQuery.java =================================================================== --- contrib/regex/src/java/org/apache/lucene/search/regex/SpanRegexQuery.java (revision 821107) +++ contrib/regex/src/java/org/apache/lucene/search/regex/SpanRegexQuery.java (working copy) @@ -107,7 +107,7 @@ } public String toString(String field) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("spanRegexQuery("); buffer.append(term); buffer.append(")"); Index: contrib/remote/src/test/org/apache/lucene/search/TestRemoteSort.java =================================================================== --- contrib/remote/src/test/org/apache/lucene/search/TestRemoteSort.java (revision 821107) +++ contrib/remote/src/test/org/apache/lucene/search/TestRemoteSort.java (working copy) @@ -146,7 +146,7 @@ } public String getRandomNumberString(int num, int low, int high) { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); for (int i = 0; i < num; i++) { sb.append(getRandomNumber(low, high)); } @@ -158,7 +158,7 @@ } public String getRandomCharString(int num, int start, int end) { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); for (int i = 0; i < num; i++) { sb.append(new Character((char) getRandomNumber(start, end))); } @@ -394,7 +394,7 @@ TopDocs hits = searcher.search (query, null, expectedResult.length(), sort); ScoreDoc[] result = hits.scoreDocs; assertEquals(hits.totalHits, expectedResult.length()); - StringBuffer buff = new StringBuffer(10); + StringBuilder buff = new StringBuilder(10); int n = result.length; for (int i=0; i 0) { Index: src/java/org/apache/lucene/index/MergePolicy.java =================================================================== --- src/java/org/apache/lucene/index/MergePolicy.java (revision 821107) +++ src/java/org/apache/lucene/index/MergePolicy.java (working copy) @@ -123,7 +123,7 @@ } String segString(Directory dir) { - StringBuffer b = new StringBuffer(); + StringBuilder b = new StringBuilder(); final int numSegments = segments.size(); for(int i=0;i 0) b.append(' '); @@ -159,7 +159,7 @@ } public String segString(Directory dir) { - StringBuffer b = new StringBuffer(); + StringBuilder b = new StringBuilder(); b.append("MergeSpec:\n"); final int count = merges.size(); for(int i=0;i 0) { Index: src/java/org/apache/lucene/index/SegmentTermVector.java =================================================================== --- src/java/org/apache/lucene/index/SegmentTermVector.java (revision 821107) +++ src/java/org/apache/lucene/index/SegmentTermVector.java (working copy) @@ -40,7 +40,7 @@ } public String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append('{'); sb.append(field).append(": "); if(terms != null){ Index: src/java/org/apache/lucene/queryParser/QueryParser.java =================================================================== --- src/java/org/apache/lucene/queryParser/QueryParser.java (revision 821107) +++ src/java/org/apache/lucene/queryParser/QueryParser.java (working copy) @@ -1131,7 +1131,7 @@ * expects to be escaped are escaped by a preceding \. */ public static String escape(String s) { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); for (int i = 0; i < s.length(); i++) { char c = s.charAt(i); // These characters are part of the query syntax and must be escaped Index: src/java/org/apache/lucene/queryParser/QueryParser.jj =================================================================== --- src/java/org/apache/lucene/queryParser/QueryParser.jj (revision 821107) +++ src/java/org/apache/lucene/queryParser/QueryParser.jj (working copy) @@ -1155,7 +1155,7 @@ * expects to be escaped are escaped by a preceding \. */ public static String escape(String s) { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); for (int i = 0; i < s.length(); i++) { char c = s.charAt(i); // These characters are part of the query syntax and must be escaped Index: src/java/org/apache/lucene/search/BooleanQuery.java =================================================================== --- src/java/org/apache/lucene/search/BooleanQuery.java (revision 821107) +++ src/java/org/apache/lucene/search/BooleanQuery.java (working copy) @@ -464,7 +464,7 @@ /** Prints a user-readable version of this query. */ public String toString(String field) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); boolean needParens=(getBoost() != 1.0) || (getMinimumNumberShouldMatch()>0) ; if (needParens) { buffer.append("("); Index: src/java/org/apache/lucene/search/BooleanScorer.java =================================================================== --- src/java/org/apache/lucene/search/BooleanScorer.java (revision 821107) +++ src/java/org/apache/lucene/search/BooleanScorer.java (working copy) @@ -357,7 +357,7 @@ } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("boolean("); for (SubScorer sub = scorers; sub != null; sub = sub.next) { buffer.append(sub.scorer.toString()); Index: src/java/org/apache/lucene/search/DisjunctionMaxQuery.java =================================================================== --- src/java/org/apache/lucene/search/DisjunctionMaxQuery.java (revision 821107) +++ src/java/org/apache/lucene/search/DisjunctionMaxQuery.java (working copy) @@ -224,7 +224,7 @@ * @return a string that shows what we do, of the form "(disjunct1 | disjunct2 | ... | disjunctn)^boost" */ public String toString(String field) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("("); int numDisjunctions = disjuncts.size(); for (int i = 0 ; i < numDisjunctions; i++) { Index: src/java/org/apache/lucene/search/Explanation.java =================================================================== --- src/java/org/apache/lucene/search/Explanation.java (revision 821107) +++ src/java/org/apache/lucene/search/Explanation.java (working copy) @@ -86,7 +86,7 @@ return toString(0); } protected String toString(int depth) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); for (int i = 0; i < depth; i++) { buffer.append(" "); } @@ -106,7 +106,7 @@ /** Render an explanation as HTML. */ public String toHtml() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("
    \n"); buffer.append("
  • "); Index: src/java/org/apache/lucene/search/FieldCache.java =================================================================== --- src/java/org/apache/lucene/search/FieldCache.java (revision 821107) +++ src/java/org/apache/lucene/search/FieldCache.java (working copy) @@ -563,7 +563,7 @@ public String toString() { - StringBuffer b = new StringBuffer(); + StringBuilder b = new StringBuilder(); b.append("'").append(getReaderKey()).append("'=>"); b.append("'").append(getFieldName()).append("',"); b.append(getCacheType()).append(",").append(getCustom()); Index: src/java/org/apache/lucene/search/FieldCacheRangeFilter.java =================================================================== --- src/java/org/apache/lucene/search/FieldCacheRangeFilter.java (revision 821107) +++ src/java/org/apache/lucene/search/FieldCacheRangeFilter.java (working copy) @@ -431,7 +431,7 @@ } public final String toString() { - final StringBuffer sb = new StringBuffer(field).append(":"); + final StringBuilder sb = new StringBuilder(field).append(":"); return sb.append(includeLower ? '[' : '{') .append((lowerVal == null) ? "*" : lowerVal.toString()) .append(" TO ") Index: src/java/org/apache/lucene/search/FieldDoc.java =================================================================== --- src/java/org/apache/lucene/search/FieldDoc.java (revision 821107) +++ src/java/org/apache/lucene/search/FieldDoc.java (working copy) @@ -63,7 +63,7 @@ public String toString() { // super.toString returns the doc and score information, so just add the // fields information - StringBuffer sb = new StringBuffer(super.toString()); + StringBuilder sb = new StringBuilder(super.toString()); sb.append("["); for (int i = 0; i < fields.length; i++) { sb.append(fields[i]).append(", "); Index: src/java/org/apache/lucene/search/FilteredQuery.java =================================================================== --- src/java/org/apache/lucene/search/FilteredQuery.java (revision 821107) +++ src/java/org/apache/lucene/search/FilteredQuery.java (working copy) @@ -206,7 +206,7 @@ /** Prints a user-readable version of this query. */ public String toString (String s) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("filtered("); buffer.append(query.toString(s)); buffer.append(")->"); Index: src/java/org/apache/lucene/search/function/CustomScoreQuery.java =================================================================== --- src/java/org/apache/lucene/search/function/CustomScoreQuery.java (revision 821107) +++ src/java/org/apache/lucene/search/function/CustomScoreQuery.java (working copy) @@ -118,7 +118,7 @@ /* (non-Javadoc) @see org.apache.lucene.search.Query#toString(java.lang.String) */ public String toString(String field) { - StringBuffer sb = new StringBuffer(name()).append("("); + StringBuilder sb = new StringBuilder(name()).append("("); sb.append(subQuery.toString(field)); for(int i = 0; i < valSrcQueries.length; i++) { sb.append(", ").append(valSrcQueries[i].toString(field)); Index: src/java/org/apache/lucene/search/FuzzyQuery.java =================================================================== --- src/java/org/apache/lucene/search/FuzzyQuery.java (revision 821107) +++ src/java/org/apache/lucene/search/FuzzyQuery.java (working copy) @@ -173,7 +173,7 @@ } public String toString(String field) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); if (!term.field().equals(field)) { buffer.append(term.field()); buffer.append(":"); Index: src/java/org/apache/lucene/search/Hit.java =================================================================== --- src/java/org/apache/lucene/search/Hit.java (revision 821107) +++ src/java/org/apache/lucene/search/Hit.java (working copy) @@ -113,7 +113,7 @@ * Prints the parameters to be used to discover the promised result. */ public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("Hit<"); buffer.append(hits.toString()); buffer.append(" ["); Index: src/java/org/apache/lucene/search/MatchAllDocsQuery.java =================================================================== --- src/java/org/apache/lucene/search/MatchAllDocsQuery.java (revision 821107) +++ src/java/org/apache/lucene/search/MatchAllDocsQuery.java (working copy) @@ -150,7 +150,7 @@ } public String toString(String field) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("*:*"); buffer.append(ToStringUtils.boost(getBoost())); return buffer.toString(); Index: src/java/org/apache/lucene/search/MultiPhraseQuery.java =================================================================== --- src/java/org/apache/lucene/search/MultiPhraseQuery.java (revision 821107) +++ src/java/org/apache/lucene/search/MultiPhraseQuery.java (working copy) @@ -271,7 +271,7 @@ /** Prints a user-readable version of this query. */ public final String toString(String f) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); if (!field.equals(f)) { buffer.append(field); buffer.append(":"); Index: src/java/org/apache/lucene/search/MultiTermQuery.java =================================================================== --- src/java/org/apache/lucene/search/MultiTermQuery.java (revision 821107) +++ src/java/org/apache/lucene/search/MultiTermQuery.java (working copy) @@ -393,7 +393,7 @@ */ @Override public String toString(String field) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); if (term != null) { if (!term.field().equals(field)) { buffer.append(term.field()); Index: src/java/org/apache/lucene/search/NumericRangeQuery.java =================================================================== --- src/java/org/apache/lucene/search/NumericRangeQuery.java (revision 821107) +++ src/java/org/apache/lucene/search/NumericRangeQuery.java (working copy) @@ -317,7 +317,7 @@ @Override public String toString(final String field) { - final StringBuffer sb = new StringBuffer(); + final StringBuilder sb = new StringBuilder(); if (!this.field.equals(field)) sb.append(this.field).append(':'); return sb.append(minInclusive ? '[' : '{') .append((min == null) ? "*" : min.toString()) Index: src/java/org/apache/lucene/search/payloads/PayloadNearQuery.java =================================================================== --- src/java/org/apache/lucene/search/payloads/PayloadNearQuery.java (revision 821107) +++ src/java/org/apache/lucene/search/payloads/PayloadNearQuery.java (working copy) @@ -85,7 +85,7 @@ } public String toString(String field) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("payloadNear(["); Iterator i = clauses.iterator(); while (i.hasNext()) { Index: src/java/org/apache/lucene/search/PhraseQuery.java =================================================================== --- src/java/org/apache/lucene/search/PhraseQuery.java (revision 821107) +++ src/java/org/apache/lucene/search/PhraseQuery.java (working copy) @@ -167,8 +167,8 @@ Explanation result = new Explanation(); result.setDescription("weight("+getQuery()+" in "+doc+"), product of:"); - StringBuffer docFreqs = new StringBuffer(); - StringBuffer query = new StringBuffer(); + StringBuilder docFreqs = new StringBuilder(); + StringBuilder query = new StringBuilder(); query.append('\"'); docFreqs.append(idfExp.explain()); for (int i = 0; i < terms.size(); i++) { @@ -259,7 +259,7 @@ /** Prints a user-readable version of this query. */ public String toString(String f) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); if (field != null && !field.equals(f)) { buffer.append(field); buffer.append(":"); Index: src/java/org/apache/lucene/search/PrefixFilter.java =================================================================== --- src/java/org/apache/lucene/search/PrefixFilter.java (revision 821107) +++ src/java/org/apache/lucene/search/PrefixFilter.java (working copy) @@ -33,7 +33,7 @@ /** Prints a user-readable version of this query. */ public String toString () { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("PrefixFilter("); buffer.append(getPrefix().toString()); buffer.append(")"); Index: src/java/org/apache/lucene/search/PrefixQuery.java =================================================================== --- src/java/org/apache/lucene/search/PrefixQuery.java (revision 821107) +++ src/java/org/apache/lucene/search/PrefixQuery.java (working copy) @@ -47,7 +47,7 @@ /** Prints a user-readable version of this query. */ public String toString(String field) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); if (!prefix.field().equals(field)) { buffer.append(prefix.field()); buffer.append(":"); Index: src/java/org/apache/lucene/search/QueryTermVector.java =================================================================== --- src/java/org/apache/lucene/search/QueryTermVector.java (revision 821107) +++ src/java/org/apache/lucene/search/QueryTermVector.java (working copy) @@ -108,7 +108,7 @@ } public final String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append('{'); for (int i=0; i0) sb.append(", "); Index: src/java/org/apache/lucene/search/Similarity.java =================================================================== --- src/java/org/apache/lucene/search/Similarity.java (revision 821107) +++ src/java/org/apache/lucene/search/Similarity.java (working copy) @@ -826,7 +826,7 @@ } final int max = searcher.maxDoc(); float idf = 0.0f; - final StringBuffer exp = new StringBuffer(); + final StringBuilder exp = new StringBuilder(); Iterator i = terms.iterator(); while (i.hasNext()) { Term term = (Term)i.next(); Index: src/java/org/apache/lucene/search/Sort.java =================================================================== --- src/java/org/apache/lucene/search/Sort.java (revision 821107) +++ src/java/org/apache/lucene/search/Sort.java (working copy) @@ -229,7 +229,7 @@ } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); for (int i = 0; i < fields.length; i++) { buffer.append(fields[i].toString()); Index: src/java/org/apache/lucene/search/SortField.java =================================================================== --- src/java/org/apache/lucene/search/SortField.java (revision 821107) +++ src/java/org/apache/lucene/search/SortField.java (working copy) @@ -347,7 +347,7 @@ } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); switch (type) { case SCORE: buffer.append(""); Index: src/java/org/apache/lucene/search/spans/FieldMaskingSpanQuery.java =================================================================== --- src/java/org/apache/lucene/search/spans/FieldMaskingSpanQuery.java (revision 821107) +++ src/java/org/apache/lucene/search/spans/FieldMaskingSpanQuery.java (working copy) @@ -128,7 +128,7 @@ } public String toString(String field) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("mask("); buffer.append(maskedQuery.toString(field)); buffer.append(")"); Index: src/java/org/apache/lucene/search/spans/SpanFirstQuery.java =================================================================== --- src/java/org/apache/lucene/search/spans/SpanFirstQuery.java (revision 821107) +++ src/java/org/apache/lucene/search/spans/SpanFirstQuery.java (working copy) @@ -54,7 +54,7 @@ public Collection getTerms() { return match.getTerms(); } public String toString(String field) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("spanFirst("); buffer.append(match.toString(field)); buffer.append(", "); Index: src/java/org/apache/lucene/search/spans/SpanNearQuery.java =================================================================== --- src/java/org/apache/lucene/search/spans/SpanNearQuery.java (revision 821107) +++ src/java/org/apache/lucene/search/spans/SpanNearQuery.java (working copy) @@ -104,7 +104,7 @@ public String toString(String field) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("spanNear(["); Iterator i = clauses.iterator(); while (i.hasNext()) { Index: src/java/org/apache/lucene/search/spans/SpanNotQuery.java =================================================================== --- src/java/org/apache/lucene/search/spans/SpanNotQuery.java (revision 821107) +++ src/java/org/apache/lucene/search/spans/SpanNotQuery.java (working copy) @@ -58,7 +58,7 @@ public void extractTerms(Set terms) { include.extractTerms(terms); } public String toString(String field) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("spanNot("); buffer.append(include.toString(field)); buffer.append(", "); Index: src/java/org/apache/lucene/search/spans/SpanOrQuery.java =================================================================== --- src/java/org/apache/lucene/search/spans/SpanOrQuery.java (revision 821107) +++ src/java/org/apache/lucene/search/spans/SpanOrQuery.java (working copy) @@ -112,7 +112,7 @@ } public String toString(String field) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("spanOr(["); Iterator i = clauses.iterator(); while (i.hasNext()) { Index: src/java/org/apache/lucene/search/spans/SpanTermQuery.java =================================================================== --- src/java/org/apache/lucene/search/spans/SpanTermQuery.java (revision 821107) +++ src/java/org/apache/lucene/search/spans/SpanTermQuery.java (working copy) @@ -52,7 +52,7 @@ } public String toString(String field) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); if (term.field().equals(field)) buffer.append(term.text()); else Index: src/java/org/apache/lucene/search/TermQuery.java =================================================================== --- src/java/org/apache/lucene/search/TermQuery.java (revision 821107) +++ src/java/org/apache/lucene/search/TermQuery.java (working copy) @@ -152,7 +152,7 @@ /** Prints a user-readable version of this query. */ public String toString(String field) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); if (!term.field().equals(field)) { buffer.append(term.field()); buffer.append(":"); Index: src/java/org/apache/lucene/search/TermRangeQuery.java =================================================================== --- src/java/org/apache/lucene/search/TermRangeQuery.java (revision 821107) +++ src/java/org/apache/lucene/search/TermRangeQuery.java (working copy) @@ -137,7 +137,7 @@ /** Prints a user-readable version of this query. */ public String toString(String field) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); if (!getField().equals(field)) { buffer.append(getField()); buffer.append(":"); Index: src/java/org/apache/lucene/search/WildcardQuery.java =================================================================== --- src/java/org/apache/lucene/search/WildcardQuery.java (revision 821107) +++ src/java/org/apache/lucene/search/WildcardQuery.java (working copy) @@ -65,7 +65,7 @@ /** Prints a user-readable version of this query. */ public String toString(String field) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); if (!term.field().equals(field)) { buffer.append(term.field()); buffer.append(":"); Index: src/java/org/apache/lucene/store/FSDirectory.java =================================================================== --- src/java/org/apache/lucene/store/FSDirectory.java (revision 821107) +++ src/java/org/apache/lucene/store/FSDirectory.java (working copy) @@ -718,7 +718,7 @@ synchronized (DIGESTER) { digest = DIGESTER.digest(dirName.getBytes()); } - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); buf.append("lucene-"); for (int i = 0; i < digest.length; i++) { int b = digest[i]; Index: src/java/org/apache/lucene/util/FieldCacheSanityChecker.java =================================================================== --- src/java/org/apache/lucene/util/FieldCacheSanityChecker.java (revision 821107) +++ src/java/org/apache/lucene/util/FieldCacheSanityChecker.java (working copy) @@ -366,7 +366,7 @@ * own line prefaced by a tab character */ public String toString() { - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); buf.append(getType()).append(": "); String m = getMsg(); Index: src/test/org/apache/lucene/analysis/TestASCIIFoldingFilter.java =================================================================== --- src/test/org/apache/lucene/analysis/TestASCIIFoldingFilter.java (revision 821107) +++ src/test/org/apache/lucene/analysis/TestASCIIFoldingFilter.java (working copy) @@ -1872,7 +1872,7 @@ // Construct input text and expected output tokens List expectedOutputTokens = new ArrayList(); - StringBuffer inputText = new StringBuffer(); + StringBuilder inputText = new StringBuilder(); for (int n = 0 ; n < foldings.length ; n += 2) { if (n > 0) { inputText.append(' '); // Space between tokens @@ -1881,7 +1881,7 @@ // Construct the expected output token: the ASCII string to fold to, // duplicated as many times as the number of characters in the input text. - StringBuffer expected = new StringBuffer(); + StringBuilder expected = new StringBuilder(); int numChars = foldings[n].length(); for (int m = 0 ; m < numChars; ++m) { expected.append(foldings[n + 1]); Index: src/test/org/apache/lucene/analysis/TestCharArraySet.java =================================================================== --- src/test/org/apache/lucene/analysis/TestCharArraySet.java (revision 821107) +++ src/test/org/apache/lucene/analysis/TestCharArraySet.java (working copy) @@ -108,7 +108,7 @@ } try{ - set.add(new StringBuffer(NOT_IN_SET)); + set.add(new StringBuilder(NOT_IN_SET)); fail("Modified unmodifiable set"); }catch (UnsupportedOperationException e) { // expected Index: src/test/org/apache/lucene/analysis/TestStopFilter.java =================================================================== --- src/test/org/apache/lucene/analysis/TestStopFilter.java (revision 821107) +++ src/test/org/apache/lucene/analysis/TestStopFilter.java (working copy) @@ -71,7 +71,7 @@ * Test Position increments applied by StopFilter with and without enabling this option. */ public void testStopPositons() throws IOException { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); ArrayList a = new ArrayList(); for (int i=0; i<20; i++) { String w = English.intToEnglish(i).trim(); Index: src/test/org/apache/lucene/analysis/TestTeeSinkTokenFilter.java =================================================================== --- src/test/org/apache/lucene/analysis/TestTeeSinkTokenFilter.java (revision 821107) +++ src/test/org/apache/lucene/analysis/TestTeeSinkTokenFilter.java (working copy) @@ -32,8 +32,8 @@ * tests for the TestTeeSinkTokenFilter */ public class TestTeeSinkTokenFilter extends BaseTokenStreamTestCase { - protected StringBuffer buffer1; - protected StringBuffer buffer2; + protected StringBuilder buffer1; + protected StringBuilder buffer2; protected String[] tokens1; protected String[] tokens2; @@ -46,12 +46,12 @@ super.setUp(); tokens1 = new String[]{"The", "quick", "Burgundy", "Fox", "jumped", "over", "the", "lazy", "Red", "Dogs"}; tokens2 = new String[]{"The", "Lazy", "Dogs", "should", "stay", "on", "the", "porch"}; - buffer1 = new StringBuffer(); + buffer1 = new StringBuilder(); for (int i = 0; i < tokens1.length; i++) { buffer1.append(tokens1[i]).append(' '); } - buffer2 = new StringBuffer(); + buffer2 = new StringBuilder(); for (int i = 0; i < tokens2.length; i++) { buffer2.append(tokens2[i]).append(' '); } @@ -161,7 +161,7 @@ int[] tokCount = {100, 500, 1000, 2000, 5000, 10000}; int[] modCounts = {1, 2, 5, 10, 20, 50, 100, 200, 500}; for (int k = 0; k < tokCount.length; k++) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); System.out.println("-----Tokens: " + tokCount[k] + "-----"); for (int i = 0; i < tokCount[k]; i++) { buffer.append(English.intToEnglish(i).toUpperCase()).append(' '); Index: src/test/org/apache/lucene/analysis/TestTeeTokenFilter.java =================================================================== --- src/test/org/apache/lucene/analysis/TestTeeTokenFilter.java (revision 821107) +++ src/test/org/apache/lucene/analysis/TestTeeTokenFilter.java (working copy) @@ -30,8 +30,8 @@ * tests for the TeeTokenFilter and SinkTokenizer */ public class TestTeeTokenFilter extends LuceneTestCase { - protected StringBuffer buffer1; - protected StringBuffer buffer2; + protected StringBuilder buffer1; + protected StringBuilder buffer2; protected String[] tokens1; protected String[] tokens2; @@ -44,12 +44,12 @@ super.setUp(); tokens1 = new String[]{"The", "quick", "Burgundy", "Fox", "jumped", "over", "the", "lazy", "Red", "Dogs"}; tokens2 = new String[]{"The", "Lazy", "Dogs", "should", "stay", "on", "the", "porch"}; - buffer1 = new StringBuffer(); + buffer1 = new StringBuilder(); for (int i = 0; i < tokens1.length; i++) { buffer1.append(tokens1[i]).append(' '); } - buffer2 = new StringBuffer(); + buffer2 = new StringBuilder(); for (int i = 0; i < tokens2.length; i++) { buffer2.append(tokens2[i]).append(' '); @@ -147,7 +147,7 @@ int[] tokCount = {100, 500, 1000, 2000, 5000, 10000}; int[] modCounts = {1, 2, 5, 10, 20, 50, 100, 200, 500}; for (int k = 0; k < tokCount.length; k++) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); System.out.println("-----Tokens: " + tokCount[k] + "-----"); for (int i = 0; i < tokCount[k]; i++) { buffer.append(English.intToEnglish(i).toUpperCase()).append(' '); Index: src/test/org/apache/lucene/analysis/TestToken.java =================================================================== --- src/test/org/apache/lucene/analysis/TestToken.java (revision 821107) +++ src/test/org/apache/lucene/analysis/TestToken.java (working copy) @@ -71,7 +71,7 @@ public void testGrow() { Token t = new Token(); - StringBuffer buf = new StringBuffer("ab"); + StringBuilder buf = new StringBuilder("ab"); for (int i = 0; i < 20; i++) { char[] content = buf.toString().toCharArray(); @@ -85,7 +85,7 @@ // now as a string, first variant t = new Token(); - buf = new StringBuffer("ab"); + buf = new StringBuilder("ab"); for (int i = 0; i < 20; i++) { String content = buf.toString(); @@ -99,7 +99,7 @@ // now as a string, second variant t = new Token(); - buf = new StringBuffer("ab"); + buf = new StringBuilder("ab"); for (int i = 0; i < 20; i++) { String content = buf.toString(); @@ -113,7 +113,7 @@ // Test for slow growth to a long term t = new Token(); - buf = new StringBuffer("a"); + buf = new StringBuilder("a"); for (int i = 0; i < 20000; i++) { String content = buf.toString(); @@ -127,7 +127,7 @@ // Test for slow growth to a long term t = new Token(); - buf = new StringBuffer("a"); + buf = new StringBuilder("a"); for (int i = 0; i < 20000; i++) { String content = buf.toString(); Index: src/test/org/apache/lucene/analysis/tokenattributes/TestTermAttributeImpl.java =================================================================== --- src/test/org/apache/lucene/analysis/tokenattributes/TestTermAttributeImpl.java (revision 821107) +++ src/test/org/apache/lucene/analysis/tokenattributes/TestTermAttributeImpl.java (working copy) @@ -39,7 +39,7 @@ public void testGrow() { TermAttributeImpl t = new TermAttributeImpl(); - StringBuffer buf = new StringBuffer("ab"); + StringBuilder buf = new StringBuilder("ab"); for (int i = 0; i < 20; i++) { char[] content = buf.toString().toCharArray(); @@ -53,7 +53,7 @@ // now as a string, first variant t = new TermAttributeImpl(); - buf = new StringBuffer("ab"); + buf = new StringBuilder("ab"); for (int i = 0; i < 20; i++) { String content = buf.toString(); @@ -67,7 +67,7 @@ // now as a string, second variant t = new TermAttributeImpl(); - buf = new StringBuffer("ab"); + buf = new StringBuilder("ab"); for (int i = 0; i < 20; i++) { String content = buf.toString(); @@ -81,7 +81,7 @@ // Test for slow growth to a long term t = new TermAttributeImpl(); - buf = new StringBuffer("a"); + buf = new StringBuilder("a"); for (int i = 0; i < 20000; i++) { String content = buf.toString(); @@ -95,7 +95,7 @@ // Test for slow growth to a long term t = new TermAttributeImpl(); - buf = new StringBuffer("a"); + buf = new StringBuilder("a"); for (int i = 0; i < 20000; i++) { String content = buf.toString(); Index: src/test/org/apache/lucene/index/DocHelper.java =================================================================== --- src/test/org/apache/lucene/index/DocHelper.java (revision 821107) +++ src/test/org/apache/lucene/index/DocHelper.java (working copy) @@ -152,7 +152,7 @@ static { //Initialize the large Lazy Field - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); for (int i = 0; i < 10000; i++) { buffer.append("Lazily loading lengths of language in lieu of laughing "); Index: src/test/org/apache/lucene/index/TestIndexReaderReopen.java =================================================================== --- src/test/org/apache/lucene/index/TestIndexReaderReopen.java (revision 821107) +++ src/test/org/apache/lucene/index/TestIndexReaderReopen.java (working copy) @@ -955,7 +955,7 @@ } public static Document createDocument(int n, int numFields) { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); Document doc = new Document(); sb.append("a"); sb.append(n); Index: src/test/org/apache/lucene/index/TestIndexWriter.java =================================================================== --- src/test/org/apache/lucene/index/TestIndexWriter.java (revision 821107) +++ src/test/org/apache/lucene/index/TestIndexWriter.java (working copy) @@ -1440,7 +1440,7 @@ // occurs but the terms are very long (heavy on // char[] arrays) for(int j=0;j<100;j++) { - StringBuffer b = new StringBuffer(); + StringBuilder b = new StringBuilder(); String x = Integer.toString(j) + "."; for(int k=0;k<1000;k++) b.append(x); @@ -1513,7 +1513,7 @@ IndexWriter writer = new IndexWriter(dir, new WhitespaceAnalyzer(), true, new IndexWriter.MaxFieldLength(100000000)); writer.setRAMBufferSizeMB(0.01); // Massive doc that has 128 K a's - StringBuffer b = new StringBuffer(1024*1024); + StringBuilder b = new StringBuilder(1024*1024); for(int i=0;i<4096;i++) { b.append(" a a a a a a a a"); b.append(" a a a a a a a a"); @@ -2677,7 +2677,7 @@ IndexWriter writer = new IndexWriter(dir, new WhitespaceAnalyzer(), IndexWriter.MaxFieldLength.UNLIMITED); Document doc = new Document(); - StringBuffer b = new StringBuffer(); + StringBuilder b = new StringBuilder(); for(int i=0;i<10000;i++) b.append(" a"); b.append(" x"); @@ -2957,7 +2957,7 @@ IndexWriter writer = new IndexWriter(dir, new WhitespaceAnalyzer(), new IndexWriter.MaxFieldLength(100000)); Document doc = new Document(); - StringBuffer b = new StringBuffer(); + StringBuilder b = new StringBuilder(); for(int i=0;i<10000;i++) b.append(" a"); b.append(" x"); Index: src/test/org/apache/lucene/index/TestIndexWriterReader.java =================================================================== --- src/test/org/apache/lucene/index/TestIndexWriterReader.java (revision 821107) +++ src/test/org/apache/lucene/index/TestIndexWriterReader.java (working copy) @@ -509,7 +509,7 @@ public static Document createDocument(int n, String indexName, int numFields) { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); Document doc = new Document(); doc.add(new Field("id", Integer.toString(n), Store.YES, Index.NOT_ANALYZED, TermVector.WITH_POSITIONS_OFFSETS)); doc.add(new Field("indexname", indexName, Store.YES, Index.NOT_ANALYZED, TermVector.WITH_POSITIONS_OFFSETS)); Index: src/test/org/apache/lucene/index/TestOmitTf.java =================================================================== --- src/test/org/apache/lucene/index/TestOmitTf.java (revision 821107) +++ src/test/org/apache/lucene/index/TestOmitTf.java (working copy) @@ -242,7 +242,7 @@ writer.setSimilarity(new SimpleSimilarity()); - StringBuffer sb = new StringBuffer(265); + StringBuilder sb = new StringBuilder(265); String term = "term"; for(int i = 0; i<30; i++){ Document d = new Document(); Index: src/test/org/apache/lucene/index/TestPayloads.java =================================================================== --- src/test/org/apache/lucene/index/TestPayloads.java (revision 821107) +++ src/test/org/apache/lucene/index/TestPayloads.java (working copy) @@ -179,7 +179,7 @@ int numDocs = skipInterval + 1; // create content for the test documents with just a few terms Term[] terms = generateTerms(fieldName, numTerms); - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); for (int i = 0; i < terms.length; i++) { sb.append(terms[i].text); sb.append(" "); @@ -350,7 +350,7 @@ private Term[] generateTerms(String fieldName, int n) { int maxDigits = (int) (Math.log(n) / Math.log(10)); Term[] terms = new Term[n]; - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); for (int i = 0; i < n; i++) { sb.setLength(0); sb.append("t"); Index: src/test/org/apache/lucene/search/BaseTestRangeFilter.java =================================================================== --- src/test/org/apache/lucene/search/BaseTestRangeFilter.java (revision 821107) +++ src/test/org/apache/lucene/search/BaseTestRangeFilter.java (working copy) @@ -65,7 +65,7 @@ * a simple padding function that should work with any int */ public static String pad(int n) { - StringBuffer b = new StringBuffer(40); + StringBuilder b = new StringBuilder(40); String p = "0"; if (n < 0) { p = "-"; Index: src/test/org/apache/lucene/search/CheckHits.java =================================================================== --- src/test/org/apache/lucene/search/CheckHits.java (revision 821107) +++ src/test/org/apache/lucene/search/CheckHits.java (working copy) @@ -223,7 +223,7 @@ } public static String hits2str(ScoreDoc[] hits1, ScoreDoc[] hits2, int start, int end) throws IOException { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); int len1=hits1==null ? 0 : hits1.length; int len2=hits2==null ? 0 : hits2.length; if (end<=0) { @@ -251,7 +251,7 @@ public static String topdocsString(TopDocs docs, int start, int end) { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append("TopDocs totalHits=").append(docs.totalHits).append(" top=").append(docs.scoreDocs.length).append('\n'); if (end<=0) end=docs.scoreDocs.length; else end=Math.min(end,docs.scoreDocs.length); Index: src/test/org/apache/lucene/search/QueryUtils.java =================================================================== --- src/test/org/apache/lucene/search/QueryUtils.java (revision 821107) +++ src/test/org/apache/lucene/search/QueryUtils.java (working copy) @@ -312,7 +312,7 @@ float scorerDiff = Math.abs(scorerScore2 - scorerScore); if (!more || doc != sdoc[0] || scoreDiff > maxDiff || scorerDiff > maxDiff) { - StringBuffer sbord = new StringBuffer(); + StringBuilder sbord = new StringBuilder(); for (int i = 0; i < order.length; i++) sbord.append(order[i] == skip_op ? " skip()" : " next()"); throw new RuntimeException("ERROR matching docs:" + "\n\t" Index: src/test/org/apache/lucene/search/TestCustomSearcherSort.java =================================================================== --- src/test/org/apache/lucene/search/TestCustomSearcherSort.java (revision 821107) +++ src/test/org/apache/lucene/search/TestCustomSearcherSort.java (working copy) @@ -195,7 +195,7 @@ luceneId = new Integer(hits[docnum].doc); if(idMap.containsKey(luceneId)) { - StringBuffer message = new StringBuffer(prefix); + StringBuilder message = new StringBuilder(prefix); message.append("Duplicate key for hit index = "); message.append(docnum); message.append(", previous index = "); Index: src/test/org/apache/lucene/search/TestMultiThreadTermVectors.java =================================================================== --- src/test/org/apache/lucene/search/TestMultiThreadTermVectors.java (revision 821107) +++ src/test/org/apache/lucene/search/TestMultiThreadTermVectors.java (working copy) @@ -177,7 +177,7 @@ } private void verifyVectors(TermFreqVector[] vectors, int num) { - StringBuffer temp = new StringBuffer(); + StringBuilder temp = new StringBuilder(); String[] terms = null; for (int i = 0; i < vectors.length; i++) { terms = vectors[i].getTerms(); Index: src/test/org/apache/lucene/search/TestSort.java =================================================================== --- src/test/org/apache/lucene/search/TestSort.java (revision 821107) +++ src/test/org/apache/lucene/search/TestSort.java (working copy) @@ -164,7 +164,7 @@ } public String getRandomNumberString(int num, int low, int high) { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); for (int i = 0; i < num; i++) { sb.append(getRandomNumber(low, high)); } @@ -176,7 +176,7 @@ } public String getRandomCharString(int num, int start, int end) { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); for (int i = 0; i < num; i++) { sb.append(new Character((char) getRandomNumber(start, end))); } @@ -277,7 +277,7 @@ result = searcher.search(new MatchAllDocsQuery(), null, 500, sort).scoreDocs; - StringBuffer buff = new StringBuffer(); + StringBuilder buff = new StringBuilder(); int n = result.length; String last = null; String lastSub = null; @@ -998,7 +998,7 @@ TopDocs hits = searcher.search (query, null, expectedResult.length(), sort); ScoreDoc[] result = hits.scoreDocs; assertEquals(hits.totalHits, expectedResult.length()); - StringBuffer buff = new StringBuffer(10); + StringBuilder buff = new StringBuilder(10); int n = result.length; for (int i=0; i 0) { @@ -101,7 +101,7 @@ * @deprecated -- in 3.0 we can use Arrays.toString * instead */ public static String arrayToString(Object[] array) { - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); buf.append("["); for(int i=0;i 0) { Index: src/test/org/apache/lucene/util/English.java =================================================================== --- src/test/org/apache/lucene/util/English.java (revision 821107) +++ src/test/org/apache/lucene/util/English.java (working copy) @@ -21,12 +21,12 @@ public class English { public static String intToEnglish(int i) { - StringBuffer result = new StringBuffer(); + StringBuilder result = new StringBuilder(); intToEnglish(i, result); return result.toString(); } - public static void intToEnglish(int i, StringBuffer result) { + public static void intToEnglish(int i, StringBuilder result) { if (i == 0) { result.append("zero"); return; Index: src/test/org/apache/lucene/util/TestIndexableBinaryStringTools.java =================================================================== --- src/test/org/apache/lucene/util/TestIndexableBinaryStringTools.java (revision 821107) +++ src/test/org/apache/lucene/util/TestIndexableBinaryStringTools.java (working copy) @@ -152,7 +152,7 @@ } public String binaryDump(ByteBuffer binaryBuf) { - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); int numBytes = binaryBuf.limit() - binaryBuf.arrayOffset(); byte[] binary = binaryBuf.array(); for (int byteNum = 0 ; byteNum < numBytes ; ++byteNum) { @@ -169,7 +169,7 @@ } public String charArrayDump(CharBuffer charBuf) { - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); int numBytes = charBuf.limit() - charBuf.arrayOffset(); char[] charArray = charBuf.array(); for (int charNum = 0 ; charNum < numBytes ; ++charNum) {